From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37BD1A0562; Tue, 4 May 2021 10:15:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB8D640147; Tue, 4 May 2021 10:15:43 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 335F14003E for ; Tue, 4 May 2021 10:15:43 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 565337F501; Tue, 4 May 2021 11:15:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 565337F501 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1620116142; bh=mAymi8eH14FNgBwiN7NbI//fAoXcwLYBhC/cZ0RNDn4=; h=Subject:To:References:From:Cc:Date:In-Reply-To; b=lCLjE4uMjMq171iFqpMP5+fpDor6567Z0aQJi3VNYxHzAoiZi57xolRGLNTHIjxXZ E1gTH5HtoF0DRH0IvSSbQdmdgeyK0/0hF9TTAAxqf/WEXfmRXF0Yx7bZF6Mike26mj XmzmRa8b423j/30zihbA1N0LfRZybOjrKtTtRC0M= To: Ferruh Yigit , Ivan Malov References: <20210428094926.22185-1-ivan.malov@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Cc: dev@dpdk.org Message-ID: <7db26a55-c931-4772-3762-8a1b8ef31c31@oktetlabs.ru> Date: Tue, 4 May 2021 11:15:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On 5/4/21 10:50 AM, Ferruh Yigit wrote: > On 4/30/2021 6:05 PM, Ivan Malov wrote: >> Hi Ferruh, >> >> These changes are imported. Furthermore, originally, these files are >> auto-generated, so in order to fix spelling I can't just apply my edits to the >> imported changes. The fixes are to be made in the original source, and I believe >> this should be somehow discussed internally. >> >> So, the changeset is either to be applied "as it is" (meaning that the fixes are >> expected to be submitted with future updates) or postponed. Maybe Andrew can >> advise. >> >> Yes, I see the spelling warnings, they're pretty much valid. But some of them >> are.. questionable. In particular, "misspelling" of the word HIST in >> MC_CMD_LTSSM_HIST_MSGSET. For sure, the suggested replacement doesn't quite fit >> the intended meaning of the macro. >> > > You can ignore invalid warnings. We'll provide v2 with spell fixes. Thanks for noticing and paying attention to it. >> Thank you. >> >> On 30/04/2021 18:56, Ferruh Yigit wrote: >>> On 4/28/2021 10:49 AM, Ivan Malov wrote: >>>> From: Andrew Rybchenko >>>> >>>> Signed-off-by: Andrew Rybchenko >>>> Signed-off-by: Ivan Malov >>>> --- >>>>   drivers/common/sfc_efx/base/efx_regs_mcdi.h   | 3509 +++++++++++++++-- >>>>   .../common/sfc_efx/base/efx_regs_mcdi_aoe.h   |  142 +- >>>>   .../common/sfc_efx/base/efx_regs_mcdi_strs.h  |    2 +- >>>>   3 files changed, 3312 insertions(+), 341 deletions(-) >>> >>> Hi Ivan, >>> >>> There are some checkpatch spelling warnings, can you please check them? >>> >>> Also is there a versioning on the MCDI, if so you may want to document the >>> updated version in driver guide and/or release notes. I think it is not required. Thanks, Andrew.