From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0068.outbound.protection.outlook.com [104.47.33.68]) by dpdk.org (Postfix) with ESMTP id 491D56CC1 for ; Wed, 12 Oct 2016 06:28:51 +0200 (CEST) Received: from DM5PR03CA0024.namprd03.prod.outlook.com (10.175.104.34) by BLUPR03MB1412.namprd03.prod.outlook.com (10.163.81.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Wed, 12 Oct 2016 04:28:48 +0000 Received: from BL2FFO11FD013.protection.gbl (2a01:111:f400:7c09::148) by DM5PR03CA0024.outlook.office365.com (2603:10b6:3:118::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5 via Frontend Transport; Wed, 12 Oct 2016 04:28:48 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD013.mail.protection.outlook.com (10.173.160.221) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Wed, 12 Oct 2016 04:28:47 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9C4Si2b001291; Tue, 11 Oct 2016 21:28:45 -0700 To: Neil Horman , Thomas Monjalon References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <20161011133824.GA31866@hmsreliant.think-freely.org> <2554688.6PDizipyct@xps13> <20161011145718.GB31866@hmsreliant.think-freely.org> CC: "david.marchand@6wind.com" , From: Shreyansh Jain Message-ID: <7dc0c499-a777-ec21-d68a-f81270fb42dd@nxp.com> Date: Wed, 12 Oct 2016 09:59:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161011145718.GB31866@hmsreliant.think-freely.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131207201277371738; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(377424004)(24454002)(377454003)(2950100002)(65806001)(65956001)(230700001)(31696002)(586003)(626004)(105606002)(93886004)(8936002)(33646002)(54356999)(50986999)(5660300001)(11100500001)(76176999)(77096005)(106466001)(36756003)(65826007)(356003)(31686004)(87936001)(305945005)(23746002)(85426001)(2906002)(5001770100001)(92566002)(4001150100001)(4326007)(83506001)(6666003)(7846002)(97736004)(8676002)(64126003)(50466002)(81156014)(86362001)(4001350100001)(81166006)(68736007)(104016004)(47776003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB1412; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD013; 1:4VnbjsKgBZYuUQUsoNVoicG5wJ1LeNR80MkHKNrRTO4xtUd1hTTT22BMQM3AOV7OjE8L1ipw1qn5HtYsj1Zp5boSHSTRftZB+wege7bxziK6bNSKIytkLXT9zROMmQWqTCVjJM9ma3VA2F8jwceuechu7ZAJ9LBOevRJKD9t7SrzLD1h3HSkN/VXJbsampX/ZHx+iHjEP529LRxOKY49PVuKjnG/nU2p77a7LWvwmF0/Gxl7sFS1c9OGnMJ+T914WTYLV5Jb02+oReSqUzOg48ab0C3j6SL0NB741WK6AUWoy3kJznoHVZp63yEPY+aNs6h1Sa4q+AZnrviuGE620FKjb+JoPDAxLqsgIRyfEZiso2+7Np8dFB/hLL/MzoAXItmgEINy+b585Nfgr0+UaSI+0NWh0wepnuVnnnUh9y90jiRLMIgYv7L/lp3F4KrjTlms+Lez0oQwkv0R+hrWbXVOI/3wjiV+RiqNYWaPswUc7kpvdmmeniuGTKnYFgxKYHhceoX46wjLZnGIldurlWNJ2/I0gtWMmK0nH+ew2H5yNe4pXsTj7TYG71qZ7l9v86sG5FbuaX3tkTxw7vYZhg== X-MS-Office365-Filtering-Correlation-Id: a8d655f3-37e9-4f7c-03f9-08d3f2584291 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1412; 2:eOrVu7eNEildjYqvUOscb9MQ3hO9+xy0DvXQh4G+klbsyRXIF5yQiNYLzA6riCO7BMLl4ZFwH/Djgx8z0ahYDfWj7AyfLof8wW9r5hJFdph9GFLzm0NqZeRXgvvnDLztj16TJ6vS9ljKMCcbSk8PTUnBr0WFlJE4WKvfuBYAXRyycNjRIlF73m74c3zqqKOtVw1Ld+NP4s8xgePANqmkuA==; 3:nrN3LLQjnjAzYH9omvWR6tGxrcUjG83n93CTcoaJEpL8hWeab+AKABGlZq8FKbTg0XOmu2ZbvNOUiDyFXgNj+TQvr+VOsF8em84vBaPADwTiA0K2ZkM81BNmykkdmFsMIKlqLv4vT6POzQQLt+dcU2UGPac0Ddo2uu5kk0bgZkj4dcLf4Yhl2ou8+k6iuUo4TW7DRKKDyYNLK36v3ldrNyeY6/SHvmk+fNN6pGFfRWskqaanYAuXfnzWEfVvYnqx X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1412; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1412; 25:1BcbmlMg6Ielp5nqSI21FnsjYSs27AM15IDkPNGn5bqLQNm09mssf0cPx8JQ1qeKPyShq8fgJFCmooJM3/WxdeX3OZb9n5d5FarRp+9G2REFdl01ZW/RTs+0BA9Tht5L0GitNdGc5CJrzbHwz7KLxjCMzTnho5+2fb+x/VIVtumiGnLCeunsO1UHQgkA9+pFYj5QxI7jqSG9nC0hnPGJ4VVHVhVxF6iiigeA8HbOiOvPqHKsWnq1GvzRYh+JWPlodwdhb61nosKrnNTtl4PLTRsgnGXYqtVsUgPIbAGQTAo2/ratdDbL2+NO6I+aq0yBewQgN8J647byJ4ARfJPtSXD/X3Ao8FRgK55EBqDBgVgL1rmi3ir0FGC9ouH7QO5cRhWKIW1Ev59NkNy1m+6cbqq/swrMomrczsgOa6xTG4WXPpr/NZwiDufCZ9BDv5b0CCKByaOfXiQN1SYvyRIIAC2DyEYuBeuLBXuFo/GJzYMIr3hgwZcrq6Mmp4VBOcJqtD7Ukh7r2SehTRH2sNlERInNlmZ3DQPibGj9FaRkKSEmu/PA8C2OdCzQSZAKZ6UdvJlNDg8aVbTlLWbpfOYJO14aVV3c+toYrRUv5+Ggks7+ujQfcfDOrc6pYtB8FmC0ekhmihdt1ciNWM2uruOD+fUEckF1WHSTO86erC5Mi3PDdpYrdAuVe5t71AyUFhBgNx7QKT8kSMjOrPJXd57Lad6a3jpYo5BE9QaWYOf4CI+VG3YKh3v3Dbau1RXevpuAMZqEc7EEE98iaaR7Ze7NOHoLieWW7s7qJ8PT4foL6Vw= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1412; 31:ncW0hLcCb8aWUKrvXCvax/PQQPvBEGNqghXTdCpUn8LlE9y8AffZAyCTvU9XCnabT8QnKneXkb7GmjdP2dWmu3pImwUI91xdVywpe2o/2IJaKSrzZj7NrtmgpxzIjyXu1T/TW6YfqNV1jKcjjcMZMGCHTGZDXHnXIaQZontjVjOGTm962RFsr2DZi+eFLZ2FPNAMU7fW3s90aZ6ipnpeptPOAusitKW1WgP6D0HonCUTRD/PDpk5dDjTHY9Uizg+H33ION6sm0YTvVj8NZJiyw==; 4:UV5IAmRNALdaF1ebp28jV4lPZYeSexu0tkBZ47F8ERzbJI0sL6HGNFQwuQUKCzyOW76Ff+WLaWHcVU1lVUKcYq6GSVDpRsNDwCYProfSSWgwD5oPjY4qXrhPmuy/d1w2CfgJofWEj64V/dRh9hMSOUc0Hbg48p+BDbsPjzuQzxnBAJCdt7zN0CZOzotCmCFpPxhZiGOX0o7OUDLyCdHdhDOLHDlB9moLP4lR+ci2B1ROuZkRmygTOmOpgtEbZn/imA1n132Zoe97KPbbSyIaz7aRlF3slUtIhAYc9L1qBRRgVmfLM3+72hqj8uside9IkZrEhlm/LswBfh3u9VgfI1yZOcQ9r5K87/+TKv2qne+CtojzawErWNK/EcJW6DT3q5UQbTwoEXRDhPH6RwRPgwZeYiykSqo/reZI+reIGikvw+R7c9m0gpOz/iorj6M9kT1SSWlhWHMYocNDswYG5bjOTozXHzyQpDHvRsHPKxYfGONzRCtPbXYWfbu3bsVsMyNwtkIDLAG05ke5rw8pjg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13024025)(13017025)(13015025)(13018025)(13023025)(5005006)(8121501046)(3002001)(10201501046)(6055026); SRVR:BLUPR03MB1412; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB1412; X-Forefront-PRVS: 0093C80C01 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR03MB1412; 23:C4J6ihYr27CG8C7CAejuQ1L+EImF1DM6BfVNE?= =?Windows-1252?Q?wyDBTTu7MSol6V8KcrDoJynyCtKQVLCUPghvFZHJlQMMdd3pXKED2Eqf?= =?Windows-1252?Q?Z/oTRSBsAe9bB44qCmsuW/DQmRpgrtOgdogjylJrbNOl+WWD11cXXMvs?= =?Windows-1252?Q?WjqTakb4SmpX7+8tkOReCYqKSreqvJ+O/ntDRb/sRrLri2V9NGk1a+fe?= =?Windows-1252?Q?jFFaeKE50l+tW7yCDgv27Jb+jVoHSKJ+MafHf38vInuQSFTHnnTW3/bl?= =?Windows-1252?Q?V6OzvWCYdSw+60JXb8vN3LAdpZwLXbbGaJgU4JFfNmLfu0+UwUn4Enqb?= =?Windows-1252?Q?0Ron+JCD14mjb+XPzRlqyqh22XXqPNzrO+wQlJV0wSRYfJtO0JwhbKpA?= =?Windows-1252?Q?maY65iFZuPN/uLAwFWucfY21IIhp5MafYBiM2oDbR4JT5VuP6dfEwP/E?= =?Windows-1252?Q?8jKKtRLICIxC9TKTYVlsnH3kjvBlhu5s3eBxi3W6n/3ksfvmWYJ1D3h8?= =?Windows-1252?Q?1PplsR4liICEsUriq/qYWoc4oLhUyVGgbXEgtdeUNVe/dsNejreo3qT1?= =?Windows-1252?Q?t6jMlQNYd5Ns861oLSQ84XVXyrdRVNbmUMf21H2wLVAuv/JYbTPx+k8j?= =?Windows-1252?Q?m6FWH49NulnVn1Yf+2glylpXshm7Fj7OIYhve1zTPawljSGO2ktKrZBA?= =?Windows-1252?Q?to/HzMvnO7wY5NDadi8mRVGD76HAv8pHv5V9nAHdpeNCCt/i0rh08G50?= =?Windows-1252?Q?VYyuQ0NIVeei0EeTWR/cDSHHJgIoRr6aUiozfYvHal/z3uTK4UNZSG3E?= =?Windows-1252?Q?zGud0mHMjQdNKVkEfPnJY0wqFnLHd0aK/5dfcxPd1lgEOISYp+qIshLB?= =?Windows-1252?Q?1EcH+lXScXcnMdgPeuULzTxGRePKNAexi2UUypjECD0AhQH9H5YJUk5C?= =?Windows-1252?Q?FYSizoINK7kttGaVc727cPUdgXn+ZDjZhWqghrWy2NWXjxxycGNOTEwR?= =?Windows-1252?Q?7/FsLkoiHwRtbl9cdC/9Nm5fbHJHua4Y7ILsmU1z5Euz7Z5hIYwYw6Kl?= =?Windows-1252?Q?3b+7kdynEjg+B8jtESkn2oBAX7dM/Pc7QqlL7E+/annZow0AYqRl/II3?= =?Windows-1252?Q?iYHI0nrhNgb5Iyjbglo7dAG31JAX1eMwtb5jEmvgdh/sLBk3YnlIURtY?= =?Windows-1252?Q?OswAz6Cf60aB2jULLu19ZKecGjjIL5P8LZsMhgoq53KPCFmQcecOzY/I?= =?Windows-1252?Q?TfPgRhj2QJph4IpBOkiZpKjfzNM6P+QSocXBesEQxmjJTDGiuIBzaPoB?= =?Windows-1252?Q?5iF3XiFQG3IJdsKNu0KsVECT+0+C81H8+FaTzOTLMdm//JFT/UEikcRt?= =?Windows-1252?Q?QMuagpS5+nK2LzdqaWaPtFuQ/O1r8TUYi86LuHxlu+IEw+bd9IJs8QrM?= =?Windows-1252?Q?0dY2FyJlCRbaLER10+1noNT8eMYiiVMLET89F4i0s06rUAxYMslwNbFI?= =?Windows-1252?Q?1GX2G0=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1412; 6:qTfqojvPlQ0+V0WpkmqAo9kMwXZxiGvaejBJ8DLFqUkfh1k3bskdEQfjJ4ZggTD5vyLoiutbJ2nHz+oPgwhFT/usGh/09SeRd5f73QnkOBB1IKsBPcPs0O0rWeD67u+XWNjLmSLQW33OgGJ14CriIeDISxN1qB0Kf4FtFZsyHLTMzIYqzO2LTVZNf9uCby7lG3HS2e/U9cEXirJqcHbahiZLgALKCWh6oeNY/TpTFccTdrPsbhYbQKioODCgoG8he0ZT4i2akeEMLYywFJ99SB7KFnYmcOQUAIwFIOROeT8i15aeNrljt6f5PMMAo0R5; 5:WN7MzRbs8Ubw3HFsfc5bHMz3xtfWF7eFE3yHdDrbe+d9Bj+yQGC+3iOV9vurMba+pbwArWGrhF7u/H5/iq2EnXLijz0zd/lI1QIgcCRLPcbyv2R+SS373Tz87AqDhYQanQ52L+lFpMuXlb3GMohTTdCwY8oa7T2k59/QHL9qvk+MmbKLKy3o1bffR2Wrn9JF; 24:CCS+GX5sV3QWv2qgFLarsEqKRSJTCU7s7gWSLa5at0RmJ7gfS0I+bemuxDODpNuG0W7FnXzGhMPfLeKhUcEujy5+9WRSzwQM9vHF9XhIc8A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1412; 7:X3ehmFMZxAeNmaBBeG5vQqeriKgcKqB7FM+C/24jVsk/U5TGZEs25qKOun2aR/O47VK8w/aHF67HWqjKVPxpMtjxmotghmBuOBs0gn+VCj31f2+3qqPOK6DOV8/C0X0j1j3SLyw1bc8slGG4KEe8iKQIA8jOK2wonsNzipBt4owhGSQHBFBtANraYOpW1mTJzkMeDqNzEWQp0BSlP53vihwPS4pEO8sryCcS5P3/PQUt19Xj2p119AQmcM3jps2LNm8ME8hZlAr/Jo1ltn8JbJd33dUVAQZv+jZXAwh7qO1EPXIIEhn3oM/Bc5C8AOZz3F0VwMa5QoPLPlaNlpDCSlvXCVC3z/PzF6SrNE5+q/E= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2016 04:28:47.5187 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1412 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 04:28:51 -0000 On Tuesday 11 October 2016 08:27 PM, Neil Horman wrote: > On Tue, Oct 11, 2016 at 03:57:29PM +0200, Thomas Monjalon wrote: >> 2016-10-11 09:38, Neil Horman: >>> This also begs the question in my mind, is it really worth changing the macro? >>> I really don't think it is. The registration macros are pretty descriptive as >>> they stand, and have already changed 3 or 4 times in the last 6 months, which >>> suggests to me that any change here is really just churn more than meaningful >>> change. You can make the argument that the name might be more in line with the >>> library its implemented in or what not, but in truth, its easy to understand >>> what the macros do (in their previous or current incantations), and any change >>> that just makes them the same as other macros in their naming is really more >>> trouble than its worth. >> >> Neil, the long term goal is to stop having some identifiers which do not >> start with RTE_ in our exported .h files. >> I think it is a reasonable policy, for a library, to live in a well defined >> namespace. Understood and agreed. >> > > I don't disagree that a consistent namespace is a nice thing, only that we've > had 3 changes to these macros in the last few months, none of which have really > moved us toward that goal. > > At least we can agree that the EAL_ macro being proposed isn't the right thing > to do regardless of motivation :) Macro proposed by this patch is not EAL_*. Thomas had already suggested that change for v1; v3 changes it to RTE_PMD_REGISTER_*. --->8--- DRIVER_REGISTER_PCI -> RTE_PMD_REGISTER_PCI DRIVER_REGISTER_PCI_TABLE -> RTE_PMD_REGISTER_PCI_TABLE DRIVER_REGISTER_VDEV -> RTE_PMD_REGISTER_VDEV DRIVER_REGISTER_PARAM_STRING -> RTE_PMD_REGISTER_PARAM_STRING DRIVER_EXPORT_* -> RTE_PMD_EXPORT_* --->8--- - Shreyansh