From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2F78E1C00 for ; Thu, 7 Dec 2017 10:18:26 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98625550B0; Thu, 7 Dec 2017 09:18:25 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58C515F907; Thu, 7 Dec 2017 09:18:23 +0000 (UTC) To: Tiwei Bie , yliu@fridaylinux.org, dev@dpdk.org References: <20171207053059.19487-1-tiwei.bie@intel.com> <20171207053059.19487-5-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com> Date: Thu, 7 Dec 2017 10:18:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171207053059.19487-5-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 07 Dec 2017 09:18:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: remove redundant macro definitions for vector Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 09:18:26 -0000 On 12/07/2017 06:30 AM, Tiwei Bie wrote: > RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH > have been defined and used in virtio_rxtx_simple.h, but are > defined agained in virtio_rxtx_simple_*.c. It just happens to s/agained/again/ > work. So remove the redundant definitions from the *.c files. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 -- > drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 -- > 2 files changed, 4 deletions(-) Apart from above typo: Reviewed-by: Maxime Coquelin Thanks, Maxime