From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2A1141AEEE for ; Thu, 21 Sep 2017 09:10:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 21 Sep 2017 00:10:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,424,1500966000"; d="scan'208";a="902476827" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.25.106]) ([10.252.25.106]) by FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2017 00:10:30 -0700 To: "Zhao1, Wei" , "dev@dpdk.org" References: <1505282644-40415-1-git-send-email-wei.zhao1@intel.com> <1505445188-70251-1-git-send-email-wei.zhao1@intel.com> <1505445188-70251-2-git-send-email-wei.zhao1@intel.com> <0508ed6a-4301-de07-7bb1-a74a5ff2a871@intel.com> From: Ferruh Yigit Message-ID: <7de926e7-a81c-4cda-59a1-736acdd7cb63@intel.com> Date: Thu, 21 Sep 2017 08:10:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 07:10:32 -0000 On 9/21/2017 7:48 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, September 20, 2017 6:36 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush >> >> On 9/15/2017 4:13 AM, Wei Zhao wrote: >>> This feature enable queue regions configuration for RSS in PF/VF, so >>> that different traffic classes or different packet classification >>> types can be separated to different queues in different queue >>> regions.This patch can set queue region range, it include queue number >>> in a region and the index of first queue. >> >> Is following correct: >> So instead of distributing packets to the multiple queues, this will distribute >> packets into queue reqions which may consists of multiple queues. >> >> If so, is there a way to control how packets distributed within same queue >> region to multiple queues? >> >> And is this feature only supported with RSS? Can it be part of RSS >> configuration instead of PMD specific API? >> >>> This patch enable mapping between different priorities (UP) and >> >> User priorities (UP) >> >>> different traffic classes.It also enable mapping between a region >>> index and a sepcific flowtype(PCTYPE).It also provide the solution of >>> flush all configuration about queue region the above described. >>> >>> Signed-off-by: Wei Zhao <...> >>> + ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); >>> + if (ret) { >>> + PMD_INIT_LOG(ERR, "Failed to configure queue region " >>> + "mapping = %d ", hw->aq.asq_last_status); >> >> Please don't split log message. > > If I do not spli it , the line will has more 80 character, there will be warning in patch check log! > So, which way do you think will be better? Split or warning log? Checkpatch detects log lines and shouldn't complain about them. Even it does I thinks checkpatch warning is better, assuming reasonable length. And you can do as following to reduce the line length: PMD_INIT_LOG(ERR, "Failed to configure queue region mapping = %d ", hw->aq.asq_last_status); <...>