From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Dekel Peled <dekelp@mellanox.com>, <adrien.mazarguil@6wind.com>,
<wenzhuo.lu@intel.com>, <jingjing.wu@intel.com>,
<bernard.iremonger@intel.com>, <yskoh@mellanox.com>,
<shahafs@mellanox.com>, <viacheslavo@mellanox.com>,
<arybchenko@solarflare.com>
Cc: <dev@dpdk.org>, <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: support action with any config object type
Date: Tue, 2 Jul 2019 11:09:08 +0300 [thread overview]
Message-ID: <7e07e792-edd4-b946-641d-4cff9cc2c830@solarflare.com> (raw)
In-Reply-To: <1389143e204e85c90b4fc124f9e561f43f78175e.1561989889.git.dekelp@mellanox.com>
On 01.07.2019 17:10, Dekel Peled wrote:
> In current implementation, an action which requires parameters
> must accept them enclosed in a structure.
> Some actions require a single, trivial type parameter, but it still
> must be enclosed in a structure.
> This obligation results in multiple, action-specific structures, each
> containing a single trivial type parameter.
>
> This patch introduces a new approach, allowing an action configuration
> object of any type, trivial or a structure.
>
> This patch introduces, in test-pmd, a new macro ARG_ENTRY_HTON, to
> allow using a single argument, not enclosed in a structure.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
The term "object" confuses me a bit, but I'm not a native speaker
so it could be just my wrong association. I'd prefer
"configuration data".
Anyway,
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2019-07-02 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 14:10 Dekel Peled
2019-07-02 8:09 ` Andrew Rybchenko [this message]
2019-07-02 8:42 ` Dekel Peled
2019-07-02 9:57 ` Adrien Mazarguil
2019-07-02 10:11 ` Andrew Rybchenko
2019-07-02 10:15 ` Dekel Peled
2019-07-02 10:17 ` Dekel Peled
2019-07-02 14:17 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-07-02 15:07 ` Andrew Rybchenko
2019-07-02 15:15 ` Adrien Mazarguil
2019-07-03 17:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e07e792-edd4-b946-641d-4cff9cc2c830@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).