From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C43A2A0487 for ; Tue, 2 Jul 2019 10:09:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2D6C5B3C; Tue, 2 Jul 2019 10:09:24 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 2E2FB5B3A for ; Tue, 2 Jul 2019 10:09:23 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 1A15380061; Tue, 2 Jul 2019 08:09:21 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.154) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Jul 2019 09:09:13 +0100 To: Dekel Peled , , , , , , , , CC: , References: <1389143e204e85c90b4fc124f9e561f43f78175e.1561989889.git.dekelp@mellanox.com> From: Andrew Rybchenko Message-ID: <7e07e792-edd4-b946-641d-4cff9cc2c830@solarflare.com> Date: Tue, 2 Jul 2019 11:09:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <1389143e204e85c90b4fc124f9e561f43f78175e.1561989889.git.dekelp@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.154] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24734.003 X-TM-AS-Result: No-4.450900-8.000000-10 X-TMASE-MatchedRID: 9zTThWtzImvmLzc6AOD8DfHkpkyUphL9OyBTDrxRCthBDVeC8J7uwT2j /N8mMgrkPKRs/oLIS1F8+iFPtm67BIdiA6DUGBE4nMQdNQ64xffKIqAq0jIHimpQWJR6J/J11ZM tftxbCoXNjdj+CIVISOU3L9KUQPrEkJxwyw8wZNO0YzRwENQzjVReZlHerCDGmyiLZetSf8nJ4y 0wP1A6APkvV+z371TK5MIx11wv+CPiRhduhvElspgtwixx9Aos0dVTSl+eOLWlYBt4rYpMEc4LF oXsiV37Kkz417rV19QuxRXQm52hks1hBI3CzT2LBcvY4QYMz60pgGcjx1Me7U3v6TpFbSBxh8xk x6AsMh4ZTSkqdqz5FucIl+0VmRmLNglg0VTTR7s35c5BnKCu9g== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.450900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24734.003 X-MDID: 1562054962-U8ib4OvfQyeX Subject: Re: [dpdk-dev] [PATCH] ethdev: support action with any config object type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01.07.2019 17:10, Dekel Peled wrote: > In current implementation, an action which requires parameters > must accept them enclosed in a structure. > Some actions require a single, trivial type parameter, but it still > must be enclosed in a structure. > This obligation results in multiple, action-specific structures, each > containing a single trivial type parameter. > > This patch introduces a new approach, allowing an action configuration > object of any type, trivial or a structure. > > This patch introduces, in test-pmd, a new macro ARG_ENTRY_HTON, to > allow using a single argument, not enclosed in a structure. > > Signed-off-by: Dekel Peled The term "object" confuses me a bit, but I'm not a native speaker so it could be just my wrong association. I'd prefer "configuration data". Anyway, Acked-by: Andrew Rybchenko