From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A35C2A0C55; Wed, 13 Oct 2021 16:31:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6022A410DA; Wed, 13 Oct 2021 16:31:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 366F640E64 for ; Wed, 13 Oct 2021 16:31:23 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A49357F50A; Wed, 13 Oct 2021 17:31:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A49357F50A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634135482; bh=r+fBz+Uoyo1sLWeP7LhLxerdA7zHr3OlokqfMKIaKkk=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=iKK812gwieUavIqKq9DfNo5lBJCURT7k39KQQpTVuL8cb4uNVgojWd0w9Vu3EOIma gIlRavnG34TxUJ1XbibgIm3nuMzKmIc2ifWcEGuhpmgRuUD9cJ+jwXiQUxEcyS+dsd mWDtil7rPQRWBoo01XO3gJZhr2zMbuxzmcXaIPSc= To: Konstantin Ananyev , dev@dpdk.org Cc: xiaoyun.li@intel.com, anoobj@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, adwivedi@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, irusskikh@marvell.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, haiyue.wang@intel.com, johndale@cisco.com, hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, heinrich.kuhn@corigine.com, kirankumark@marvell.com, mczekaj@marvell.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, mdr@ashroe.eu, jay.jayatheerthan@intel.com References: <0211007112750.25526-1-konstantin.ananyev@intel.com> <20211013133704.31296-1-konstantin.ananyev@intel.com> <20211013133704.31296-6-konstantin.ananyev@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7e0a4705-dc4c-0b69-ad08-320ff2635386@oktetlabs.ru> Date: Wed, 13 Oct 2021 17:31:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211013133704.31296-6-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 5/6] ethdev: add API to retrieve multiple ethernet addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/21 4:37 PM, Konstantin Ananyev wrote: > Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet ethernet -> Ethernet > addresses assigned to given port. > Change testpmd to use this new function and avoid referencing directly > rte_eth_devices[]. > > Signed-off-by: Konstantin Ananyev Reviewed-by: Andrew Rybchenko except one nit below [snip] > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index f4c92b3b5e..dbc14f4a23 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3007,6 +3007,27 @@ int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, > */ > int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); > > +/** Experimental header is missing > + * Retrieve the Ethernet addresses of an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param ma > + * A pointer to an array of structures of type *ether_addr* to be filled with > + * the Ethernet addresses of the Ethernet device. > + * @param num > + * Number of elements in the @p ma array. > + * Note that rte_eth_dev_info::max_mac_addrs can be used to retrieve > + * max number of Ethernet addresses for given port. > + * @return > + * - number of retrieved addresses if successful > + * - (-ENODEV) if *port_id* invalid. > + * - (-EINVAL) if bad parameter. > + */ > +__rte_experimental > +int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma, > + unsigned int num); > + > /** > * Retrieve the contextual information of an Ethernet device. > * [snip]