From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix compilation issue with old kernels
Date: Thu, 7 May 2020 13:56:01 +0100 [thread overview]
Message-ID: <7e14963d-8792-6406-9daa-2db2083697e7@intel.com> (raw)
In-Reply-To: <20200507094529.7117-1-rasland@mellanox.com>
On 5/7/2020 10:45 AM, Raslan Darawsheh wrote:
> With old kernels that don't have support for extended ack
> the variable one is not used which will cause a compilation
> failure:
> drivers/net/tap/tap_netlink.c:48:6:
> error: unused variable 'one' [-Werror=unused-variable]
> int one = 1;
> ^~~
> cc1: all warnings being treated as errors
> Fixes: f11e38d90980 ("net/tap: use netlink extended ack support")
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
Thanks for reporting and fixing the issue.
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Squashed into relevant commit in next-net, thanks.
next prev parent reply other threads:[~2020-05-07 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 9:45 Raslan Darawsheh
2020-05-07 12:56 ` Ferruh Yigit [this message]
2020-05-10 12:48 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e14963d-8792-6406-9daa-2db2083697e7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).