From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0082.outbound.protection.outlook.com [104.47.34.82]) by dpdk.org (Postfix) with ESMTP id CD4C91518 for ; Thu, 13 Oct 2016 15:15:22 +0200 (CEST) Received: from BN6PR03CA0023.namprd03.prod.outlook.com (10.168.230.161) by BY1PR03MB1417.namprd03.prod.outlook.com (10.162.127.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.12; Thu, 13 Oct 2016 13:15:21 +0000 Received: from BN1BFFO11FD029.protection.gbl (2a01:111:f400:7c10::1:125) by BN6PR03CA0023.outlook.office365.com (2603:10b6:404:23::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11 via Frontend Transport; Thu, 13 Oct 2016 13:15:20 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD029.mail.protection.outlook.com (10.58.144.92) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Thu, 13 Oct 2016 13:15:20 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9DDFEU2020768; Thu, 13 Oct 2016 06:15:18 -0700 To: Olivier Matz References: <1473959607-1951-1-git-send-email-hemant.agrawal@nxp.com> <1474044395-11627-1-git-send-email-hemant.agrawal@nxp.com> <1474044395-11627-2-git-send-email-hemant.agrawal@nxp.com> CC: , , From: Hemant Agrawal Message-ID: <7e26965e-173b-1cf6-0beb-c94712ad615a@nxp.com> Date: Thu, 13 Oct 2016 18:45:14 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131208381207550430; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(189002)(377454003)(230700001)(104016004)(86362001)(47776003)(575784001)(81166006)(81156014)(8676002)(31696002)(106466001)(4001350100001)(97736004)(65956001)(65806001)(11100500001)(31686004)(105606002)(356003)(36756003)(189998001)(7846002)(76176999)(54356999)(305945005)(50986999)(19580395003)(120886001)(586003)(19580405001)(7126002)(6916009)(4326007)(2906002)(64126003)(6666003)(23746002)(77096005)(15975445007)(2950100002)(110136003)(626004)(7246003)(92566002)(8936002)(85426001)(83506001)(15395725005)(87936001)(68736007)(65826007)(5660300001)(93886004)(33646002)(50466002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR03MB1417; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD029; 1:4AYhB/FkdTz3B/Z79zNlVVCGXQfXqzsUHULQUoH0spWRPT3e3ePn/xKv9QgYXYjanEbq4aUOXGODkiRoUuyyjk4dF2j+fy6DZSK8wo//4q5NgDpBTiOtUROQyxOiG1fD+o8VGP0zvpCZosC3Sg/C7d/BqtXy7vKhKiv+nTsBdNJ93ovsXZYNxGC7izS9TbJ3x3sKGerNAB5u+I2HgZd8TtnaY5bx86Ve+vm+RzJjaGsAZiHSEmlnoha4QjvUYGH9oY2+KIXCK3v6yBo8mFjU+Qutvib6ftDe1l9foIYJ4Kne/JvsHEjETi6N5+H7VFHDzXQ6Gm3vV1Bp+ZKhqIfI9Pz4bGhLVHVhd8bLnVAVGP4h014VH/5pCi/YuVyMCGJVKGrJI9PDf73V0E/l5jiPpoOuEK9WDr4zspZ+cXB6+N9orjhkP3eeiGZn9HUhKwAuS4wWc5b2/URKzevvCWpp6RSBM9LDq98/3xvhrgqExgSTvQTSlhsDKCJUfkOiz9VaUm6l8DpvEgul6HEXtGSbC50ohO4ycbiyN/yXWV0I5waYEq7he8ivQWo0+fmEm34PYKlHDJ+00OnmRfVR68pqzU+wkyypmVEBc18mtKP6U88C2nY4oVuSceJ2iSAwuRDB X-MS-Office365-Filtering-Correlation-Id: 2927af1d-082e-4993-19de-08d3f36afbe5 X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1417; 2:U2xzm/BUp2zafiEx2BK8T6Ba3dcKTdTf9waev0FhCK3//SLkayvW3D5tqfWJzCKNEI2mbtdUV5qlK1SKzvB0TVOMIV9dOpFmoQCrTw0sosStd9eB2tI+CwvVOmDv+a11hpVkCZ83n/cWvDj7ywFnpln3+yzqpc9x1HfNtNHBaXnvzrE5+O8CcEx3gHRNcTG63ywAQwKtno6qJGNKTDv3Kg==; 3:15WiElGrbjtg9sq4KCGoK7VCJRbYuE7Vd1KSQF0HyBx1M4Yodm+egq2drMAcwWsmAklINCLizSjGvfqeuQySLLUcNG4wK9ns4fb+1Z+yiDohslxJ1d0ETiewsPoWfcoTmcCqxsP+433rBbjBfvnoZivfSij8K5qWlvKICAzVO7Ownd9FNOX/daJawtIJUt7iSKRQh/yw4G/1scZTIyLUCwL0IWQAr6FJ82hDGiugaouMgIyuVpsCR99UNlprfkUD; 25:NZdQgHqDA9FYCrLYm2CUd9SAhAlzzmq+tBP21WtJwRxAtKPIOa0pkEusUx1NP5AmQpcDKhzNkcvdQR6Hh6vaHgPgsHnoDPPUEFgvKU1WUDaxRGkIheJZ5+6/XGJe+0c/B/cTurdLqTy3j2mX0+PAUecl0SG/HKXxJORHnQ/rO/sm1gLMGwULSeFL1p3Wqqxp2aizKf1dfcG6gPT6iguvTKPOhdIEydhxX1KCAUIzt/LV3eXeQD9QrH6RqjVBS43jzI4iWPVhXxD1IVaVX5qtKxZa2fA0Jdho2gwBcqxRUXf2lnNKmLzXPJFQ5juGEjFQG9zHJ6WbihEuaU6lEbMu+lHNlkmCdT137CU6YuWqo9JdaRzPsCR6IP6niomXNzgkrEAeNWPRu2RG0z1rKipX7Yle6pePlqbvJaGe37KX+vu+K/sypSCFVHAuYyc0EG1FBQ7RVt2DCxlX7jtWBiGFkw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1417; X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1417; 31:ZLcjEaXcT19aLgjdEsKW5hnX+y1LZUt+ARwJBE0z63x0Hor0rmrXFRROVPJzQAS1vJMvRlxjEWEh034UpEylH8+EWxs6nxW8F7IUYQlKlaDWvYbOjw9AFU+/yH3jufi3DG0dCgEAie2mjsTBG/5v+QkR6aPMOqmUhoihaVcNMXYwl1qrmBmNWjFDGeNdOCMKH5tyKY3CpRlQ+21VTJiBg2Tokhf1YG/eIvHEUe1z6kXSLu8mUvhAf4NN1HEkGY+qPA2egzXt+jD8krNUoc7e2w==; 4:ulAZV/AgkM5nIIBCWiexuV/zTzO/RR3w9Nf7Wk1xC1OqBe98cwq0ixh5V2efhPLH4psraPQpokqMuhEPwSLV2yKI4ohy7/DSH6fo4Vgw2BTIwqrlszK5VIHv3wmwlKZNKkhQ9mC7E4O4rF6tK5clOvu+YLJLs74Jn+2P/9OVzXJ5n5/UFV8VVWCFCo8Sp+q8MTHsvLtmcWvCGvTGsygOPCacMiIv7wt4nbZMl+Fi7xLeGTau4PAlgnKPJN7CV4GU584uduZEkVdO+F1wx2Ps04o1BV/x2/e4WTBDhheHUppsyg57CJBYK1bGxu3AEP7iXYyfK510q3Jub6Lx23nqa1eEY/rUWzvJU/A3OPgiigi7ZazCJjf2QXIpUVYh+DyUXuuJVg50tgPZ1n4B/NLvgzopnrGPnHRQXYJdR+Hem1DvHuWmJ13LyZqTJOdZI9RRqLhVLGGQIwnZFnAOAtsbP1AAsYrm6+pnYGYDH+QALGvntnMzXhv/SRR1bK6Yj29niIMg3Oszuce7Bibn0dnN/U+XMyusJDrLSMnBSwoYNjWnOAVejB/eNB6ERoXBx/I+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(13018025)(13023025)(13015025)(13017025)(13024025)(8121501046)(10201501046)(3002001)(6055026); SRVR:BY1PR03MB1417; BCL:0; PCL:0; RULEID:(400006); SRVR:BY1PR03MB1417; X-Forefront-PRVS: 0094E3478A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BY1PR03MB1417; 23:WkTsVWca49p0o7hmw7Z6G0TFgeSkyQ9LfQOI6?= =?Windows-1252?Q?hDo9Zjk0TJyWc91Wud0yklzMKuEtV42T7F6gbCIijArWZRbMQjWNIlxZ?= =?Windows-1252?Q?0RCbtVsXh2yZ+OMnXB8H43NAxTTsdPnp9V2TOnalb0eXLujtEUkjliNZ?= =?Windows-1252?Q?RYU6VLDc8N3bu91qqqnyNis7jDesT0mz3oOEorGtE32gSrzNz6MzFEm2?= =?Windows-1252?Q?9YrFjjd0aHYjeX8Jtc14EBQlweDYAbb7PiZi1NNjlbHikIOqE8iiibyI?= =?Windows-1252?Q?1CjSTwdij6Mdplg9CA6XU5U1t59P1Lp8I0XSZqwQSPHnzPb4/a5/oytW?= =?Windows-1252?Q?+sa9RvvQEQvff2nffCU+LtCxEr1vkrZjz0oi4aSvHQP4hvtowQKjRMZD?= =?Windows-1252?Q?xAXvTVhEXlANoxESd4Id0Ao8uMLR/p9gpSuJyOeu1LY9lPXNEhjmIQKj?= =?Windows-1252?Q?rPZD5MUO6ujxagf51W/8qvRB490B46JRWCUurSWjoat+OEFXpIAS1sM5?= =?Windows-1252?Q?oZWBgXjBqPzftY4HrVbEyAiosNaa7gFLNj0QOQeHHmxHQkRGH696+fDf?= =?Windows-1252?Q?4DvxWbtOc+fYYW/N/E3agdMMrqJu71B1bn8yD0KaMhD41lZ8iP9FmLIg?= =?Windows-1252?Q?neAb4KT1NNonHunouTnAuhcU+ik9N6DyfjO1zQjIhdR18v2CEbNtKTqk?= =?Windows-1252?Q?oPd9Ts9IQTAK0v6gkY9p9ubClZRJ0PyxuQMcvsxf4mnc2I9eAFsQvQ2t?= =?Windows-1252?Q?diBQSesVDrYKdgmI1ARY0Xz1c0GCFcsg9Ih2ukbtq4p06GKd7EwBu2X7?= =?Windows-1252?Q?KEiTy1jPfWSrqjdprpN70+yimsTC2kMVF1XRhZ9NHORyybsVbuWnn074?= =?Windows-1252?Q?yet/uKi3+KnJ5fBSRJOHJbwaP6WndCkmKyhC73cOAffyKcwjRBqJ+vUa?= =?Windows-1252?Q?WWy7kema1n4UqQrME0YOJTM4OUrIfiKBa6wHyF8TswjuwDbsbzIqueh7?= =?Windows-1252?Q?5M1ycP1Z/vlo/F38N/NcgwJr+x2r+4mnmG9WKyGfLwzkK7n/C+M0Q6tU?= =?Windows-1252?Q?oGh1yoZLHPHjtSTc2M+lfEyiQSjxIamyVEtUTcg19tGJNzE9fadSHeJi?= =?Windows-1252?Q?KwH+Ay6LQtqH669fQh6LnXBT3I605Q9PsnkliV3BXl78Za+tZdvKZNgr?= =?Windows-1252?Q?CqP61OKsVqrzH7W5if8kqW5uilNO190KO+Fwl5GLFJXdcAyG3KVO4IEa?= =?Windows-1252?Q?Cacw6lraV9kDzdz50uXm6I5xjlBzop6dA7GmY/Td8hmAHYTrd+CdTDIl?= =?Windows-1252?Q?VHm1J/GYMRNwaykRNiolkYebnjHk+WgiAIrz1OTB6MwaQpiZX7tayaLm?= =?Windows-1252?Q?HDajipIHz3ykq+scQIrGyh487mJSqV/3bVWvDwCoa0Xl6Xi5wcbhFlpX?= =?Windows-1252?Q?g8Y7jveVXiakhnvG78BMv7/HShfwbGy5pIIcqG0Mwt0YkO2+xSGV7utB?= =?Windows-1252?Q?X2GaQWem2nhey497mh0NSeQSVNejsp7auhwCNgzifvi0+VDf7ZlYYYQQ?= =?Windows-1252?Q?qNZd+0NJA1Ji13jBUGbJX0gHyQMlpbSzzMk19Erp1tNhUiW678IqrQOO?= =?Windows-1252?Q?CvaACopAtHaWH/FLTd3VIk=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1417; 6:B/GU8/rzqIRLegrCPx04UWrk4PRv7wWXsQNSMUkdBUdwlEshWg3SJFqcj4Xl0ZRL5vawL2Oos3Nu3+nM5OWCWDCPN8ewpr27Hhs9QHFCyZLKXN/tF8YbfQyXt+1iGmg+EThQltMJ7fu3Eux61ZGr4U0b2n68VBRlOp7e2a7pasS6ntsojodVgwtYqFSONEfGRv6EGeBXfO8Ge38X5t/rH8frCdWFFE0miABfRm89CUNptXyktBsq8u35oQ72tHenWT+nsiI4CD1bD+3RNwZTZHC+hjbz6bhKCGCDhpWZhfVkw57avew7QO7wmOlAKKqd; 5:Wr4znNRrk3tLI6m8SFjItgmKW0tVngBLirtVOS1NEepGtGieNzZSPINNAoS3/eSOfmLpmGTjukKmoRdQNMyn6fTzDBf5OyBR1/eZqxDGMrq2RI9qHSSKc5vJSMFbzM/59417sjdoh+L/gpGefihp9yvpfoOYjRiosidEU9ripH6Ktlsoz2i9yLb77eX0mEi+; 24:mquEwAzvo11oppp16BF+Ml6s7p707queULWKulXcvrsTxEhX8+MUWAefn9pyHE/5Uz/LOfZWDkvF6eqnHy+mBTCO8gDSp6WMdDLbSnp8JDk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR03MB1417; 7:oLeqzjYnoV20DMQ5Mx7NUMk2Ghh98tJkdlgjZ4e+DOtcTyl+6YJDoL3VpVMMG+DWViJ/OQ3B3YF5WqMJAsVFo4Pl+cR7obPIVeCiQfKBUnockumAxNjOmfRNWxj01Nu0umqzITFBDzwnsCIn14HdMFCPJcsFcnpKycP/LWaoX3OmvRW0QZV/wMCgr83QZ1ZDjyIFjQf5H3+4Igrb6ts3LvY6pvcq6a+VlMwrQPKEkIWnsrYgXU2eIyvGJo0L2rhcgh3zLZ2uXp4TUkiEI/893Mmd3MWwskPPjuoHZGEo1rZpRqXBClylgeanK//lzIhMznRNTQqXE0qG3bqGMmOY2Mm8sYcF+Dy/501acCtH9Qg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2016 13:15:20.5210 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1417 Subject: Re: [dpdk-dev] [PATCH v3 2/2] mempool: pktmbuf pool default fallback for mempool ops error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 13:15:23 -0000 Hi Olivier, Any updates w.r.t this patch set? Regards Hemant On 9/22/2016 6:42 PM, Hemant Agrawal wrote: > Hi Olivier > > On 9/19/2016 7:27 PM, Olivier Matz wrote: >> Hi Hemant, >> >> On 09/16/2016 06:46 PM, Hemant Agrawal wrote: >>> In the rte_pktmbuf_pool_create, if the default external mempool is >>> not available, the implementation can default to "ring_mp_mc", which >>> is an software implementation. >>> >>> Signed-off-by: Hemant Agrawal >>> --- >>> Changes in V3: >>> * adding warning message to say that falling back to default sw pool >>> --- >>> lib/librte_mbuf/rte_mbuf.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c >>> index 4846b89..8ab0eb1 100644 >>> --- a/lib/librte_mbuf/rte_mbuf.c >>> +++ b/lib/librte_mbuf/rte_mbuf.c >>> @@ -176,6 +176,14 @@ rte_pktmbuf_pool_create(const char *name, >>> unsigned n, >>> >>> rte_errno = rte_mempool_set_ops_byname(mp, >>> RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL); >>> + >>> + /* on error, try falling back to the software based default pool */ >>> + if (rte_errno == -EOPNOTSUPP) { >>> + RTE_LOG(WARNING, MBUF, "Default HW Mempool not supported. " >>> + "falling back to sw mempool \"ring_mp_mc\""); >>> + rte_errno = rte_mempool_set_ops_byname(mp, "ring_mp_mc", NULL); >>> + } >>> + >>> if (rte_errno != 0) { >>> RTE_LOG(ERR, MBUF, "error setting mempool handler\n"); >>> return NULL; >>> >> >> Without adding a new method ".supported()", the first call to >> rte_mempool_populate() could return the same error ENOTSUP. In this >> case, it is still possible to fallback. >> > It will be bit late. > > On failure, than we have to set the default ops and do a goto before > rte_pktmbuf_pool_init(mp, &mbp_priv); > > >> I've just submitted an RFC, which I think is quite linked: >> http://dpdk.org/ml/archives/dev/2016-September/046974.html >> Assuming a new parameter "mempool_ops" is added to >> rte_pktmbuf_pool_create(), would it make sense to fallback to >> "ring_mp_mc"? What about just returning ENOTSUP? The application could >> do the job and decide which sw fallback to use. > > We ran into this issue when trying to run the standard DPDK examples > (l3fwd) in VM. Do you think, is it practical to add fallback handling in > each of the DPDK examples? > > Typically when someone is writing a application on host, he need not > worry non-availability of the hw offloaded mempool. He may also want to > run the same binary in virtual machine. In VM, it is not guaranteed that > hw offloaded mempools will be available. > > w.r.t your RFC, we can do this: > if the user has specified a mempool_ops in rte_pktmbuf_pool_create(), > don't fallback. It will be responsibility for application to decide on > calling again rte_pktmbuf_pool_create() with different mempool_ops. > >> >> >> Regards, >> Olivier >> > > >