DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: Zhike Wang <wangzhike@jd.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when disable	adminq operation
Date: Fri, 13 Mar 2020 05:57:51 +0000	[thread overview]
Message-ID: <7e2a638522034fc983df93e1d97b4f5d@intel.com> (raw)
In-Reply-To: <20200313052213.GB44839@intel.com>

Yes. But I'm OK if it's applied to later since it won't take effect anyway with the share code change in 20.02.

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Friday, March 13, 2020 13:22
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: Zhike Wang <wangzhike@jd.com>; dev@dpdk.org; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix X722 judgement
> when disable adminq operation
> 
> Hi, Xiaoyun
> 
> Thanks for the review, just want to double check, are you suggesting that this fix
> should just be applied to LTS? Latest code doesn't need it, right?
> 
> Thanks,
> Xiaolong
> 
> On 03/13, Li, Xiaoyun wrote:
> >Hi
> >
> >This issue is already fixed in 20.02 with base code update of the following
> commit.
> >
> >
> >
> >commit 37b091c75b13d2f26359be9b77adbc33c55a7581
> >
> >Author: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> >Date:   Mon Jan 13 10:39:31 2020 +0800
> >
> >
> >
> >    net/i40e/base: extend PHY access AQ command
> >
> >
> >
> >    Currently FW use MDIO I/F number corresponded with current PF for
> > PHY
> >
> >    access. This code allow to specify used MDIO I/F number.
> >
> >
> >
> >    Signed-off-by: Piotr Azarewicz <piotr.azarewicz@intel.com>
> >
> >    Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >
> >    Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> >Acked-by: Beilei Xing
> >beilei.xing@intel.com<mailto:beilei.xing@intel.com>
> >
> >
> >
> >But it makes sense to back port this to stable release so it can work with dpdk
> version <=19.11.
> >
> >Still some comments inline.
> >
> >
> >
> >> -----Original Message-----
> >
> >> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhike Wang
> >
> >> Sent: Thursday, January 16, 2020 09:20
> >
> >> To: dev@dpdk.org
> >
> >> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> >> <qi.z.zhang@intel.com>;
> >
> >> stable@dpdk.org; Zhike Wang <wangzhike@jd.com>
> >
> >> Subject: [dpdk-stable] [PATCH] net/i40e: fix X722 judgement when
> >> disable
> >
> >> adminq operation
> >
> >>
> >
> >> X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722
> >
> >> /I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge whether
> >> it is
> >
> >> X722 or not.
> >
> >>
> >
> >Please be careful about your commit log. If you use mac.type == X722, then
> that's not just X722 SFP but all X722 devices.
> >
> >You can just say something like X722 doesn't support adminq operation so
> disable it.
> >
> >
> >
> >> Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16")
> >
> >Please follow the DPDK community code style. Fix line needs commit id of 12
> bit.
> >
> >In this case, should be: Fixes: 9efa8d28b4da ("net/i40e: fix SFP X722
> >with FW4.16")
> >
> >And since this fix makes sense for <=19.11, please add this line: Cc:
> >stable@dpdk.org
> >
> >
> >
> >> Signed-off-by: Zhike Wang <wangzhike@jd.com<mailto:wangzhike@jd.com>>
> >
> >> ---
> >
> >>  drivers/net/i40e/i40e_ethdev.c | 2 +-
> >
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >>
> >
> >> diff --git a/drivers/net/i40e/i40e_ethdev.c
> >> b/drivers/net/i40e/i40e_ethdev.c
> >
> >> index 5999c96..85ccb76 100644
> >
> >> --- a/drivers/net/i40e/i40e_ethdev.c
> >
> >> +++ b/drivers/net/i40e/i40e_ethdev.c
> >
> >> @@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct
> >
> >> i40e_pf *pf)
> >
> >>                            return -EIO;
> >
> >>             }
> >
> >>             /* Firmware of SFP x722 does not support adminq option */
> >
> >> -          if (hw->device_id == I40E_DEV_ID_SFP_X722)
> >
> >> +          if (hw->mac.type == I40E_MAC_X722)
> >
> >>                            hw->flags &=
> >> ~I40E_HW_FLAG_802_1AD_CAPABLE;
> >
> >>
> >
> >>             PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d
> >
> >> eetrack %04x",
> >
> >> --
> >
> >> 1.8.3.1
> >
> >>

  reply	other threads:[~2020-03-13  5:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16  1:19 [dpdk-dev] " Zhike Wang
2020-03-12  9:13 ` 王志克
2020-03-13  4:40 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2020-03-13  5:22   ` Ye Xiaolong
2020-03-13  5:57     ` Li, Xiaoyun [this message]
2020-03-13 19:16   ` Kevin Traynor
2020-03-16  2:02     ` Li, Xiaoyun
2020-03-16 10:15       ` Kevin Traynor
2020-03-17  1:35         ` Li, Xiaoyun
2020-03-18  3:25           ` 王志克

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e2a638522034fc983df93e1d97b4f5d@intel.com \
    --to=xiaoyun.li@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wangzhike@jd.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).