From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9BA9A0C44; Mon, 12 Apr 2021 18:42:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35BDE14126B; Mon, 12 Apr 2021 18:42:59 +0200 (CEST) Received: from mail-108-mta94.mxroute.com (mail-108-mta94.mxroute.com [136.175.108.94]) by mails.dpdk.org (Postfix) with ESMTP id 0CC84141266 for ; Mon, 12 Apr 2021 18:42:56 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta94.mxroute.com (ZoneMTA) with ESMTPSA id 178c6f6e6e80004964.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 12 Apr 2021 16:42:53 +0000 X-Zone-Loop: 0d00d6ae09cee78ef18405588c54fb0c579bb5fed0dd X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=g4un8bR0A/mwZcO6qjeD6mcfNqNYp0tZ5w8mhyJSrtk=; b=TwnUDB7OtyuwnX9p7CwnvSnXWD Rkm8VYEEbk0DCfYJowY9F5GtWqFcTJ1laFaMrDiP5uYlTBdUbA6sDaV5IcHxRNxk8fz0ByLKkrkj0 87U7vme9Rxnuj2ppIkCazTDE6Y1qY4K2MSFynuuD9SQ7Nyut9H1ClRfF5DONNkiV7/PNzsHSMsbQC XYevUJurDM/uHwkxzN9xcJzWtY74NkfvrNk1csI5FyMiootsYqApPGrXJNpEFVIzrZkrrVXUzqXyR VVqizKKJEKee13IrIsw9TsWmig/xLY1SPSQx7oM3FJtR7Uf4q1zXpVETrflHqk7YjbTi6aonZn897 uGTeIGuw==; To: Xueming Li , Andrew Rybchenko , Ferruh Yigit Cc: dev@dpdk.org, Viacheslav Ovsiienko , Asaf Penso , Olivier Matz , Thomas Monjalon References: <1615468416-10115-1-git-send-email-xuemingl@nvidia.com> <1615468416-10115-6-git-send-email-xuemingl@nvidia.com> From: "Kinsella, Ray" Message-ID: <7e2d3706-9c88-6852-add3-e6ab62cd197b@ashroe.eu> Date: Mon, 12 Apr 2021 17:42:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1615468416-10115-6-git-send-email-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v9 05/10] kvargs: update parser to support multiple lists X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/03/2021 13:13, Xueming Li wrote: > This patch updates kvargs parser to support value of multiple lists or > ranges: > k1=v[1,2]v[3-5] > > Signed-off-by: Xueming Li > Acked-by: Viacheslav Ovsiienko > Acked-by: Thomas Monjalon > --- > app/test/test_kvargs.c | 46 +++++++++++++-- > lib/librte_kvargs/rte_kvargs.c | 101 +++++++++++++++++++++++---------- > 2 files changed, 112 insertions(+), 35 deletions(-) > Hi folks, This is essentially an FYI. This change introduced a weak functional ABI regression into DPDK. When I test librte_kvargs using the v20.11 unit test binary I get the following. EAL: Detected 80 lcore(s) EAL: Detected 2 NUMA nodes EAL: Detected shared linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: 4090 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size APP: HPET is not enabled, using TSC as default timer RTE>>kvargs_autotest == test valid case == == test invalid case == rte_kvargs_parse() returned 0 (but should not) while processing using valid_keys= Test Failed RTE>> The reason this is failing in v20.11 and passing at the HEAD, is that "no value" test case (foo=1,foo=) were removed from test_invalid_kvargs, and was added to test_valid_kvargs. So tokens that were definitely invalid in v20.11, are now is valid in v21.11. My 2c is that as long as the valid values in v20.11 are still OK, there is no regression. Thanks, Ray K