From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F858A0032; Wed, 14 Sep 2022 13:48:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFDB24021F; Wed, 14 Sep 2022 13:48:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0469C40156 for ; Wed, 14 Sep 2022 13:48:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663156113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4UKx1iuV9a2wVYmdjqw64VGp7GxmgHFG9dPEefHiyVo=; b=hbzXxgsNmOxYkBf5JPcr49uTTBQjsXL36DJl4Eg7XWXDmRBZ3fP0DrZ8kvWTnk6K+/xeCL yLjAak+LsPpxim/bP7YE7NxjnC0zjcZ4dLHQHJVlLAm0A4iUClnKukqFAMUhrIKV4UbruP j5jE64gmQtRk7bNSr+aVJstax3JIdns= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-955qVhN9Nx6LGQuq0b7NKw-1; Wed, 14 Sep 2022 07:48:32 -0400 X-MC-Unique: 955qVhN9Nx6LGQuq0b7NKw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 126D029DD9AD; Wed, 14 Sep 2022 11:48:32 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01CD6140EBF3; Wed, 14 Sep 2022 11:48:30 +0000 (UTC) Message-ID: <7e3f6526-7745-f70f-6418-c0c877faa440@redhat.com> Date: Wed, 14 Sep 2022 13:48:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation To: Thomas Monjalon , "Xia, Chenbo" , David Marchand Cc: "stable@dpdk.org" , "dev@dpdk.org" References: <20220722135320.109269-1-david.marchand@redhat.com> <2718825.BEx9A2HvPv@thomas> <4ac23626-27fb-e319-8050-82f504393589@redhat.com> <2571819.k3LOHGUjKi@thomas> From: Maxime Coquelin In-Reply-To: <2571819.k3LOHGUjKi@thomas> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/14/22 11:45, Thomas Monjalon wrote: > 14/09/2022 11:34, Maxime Coquelin: >> >> On 9/14/22 11:15, Thomas Monjalon wrote: >>> 14/09/2022 09:14, Maxime Coquelin: >>>> On 9/14/22 03:05, Xia, Chenbo wrote: >>>>> From: Maxime Coquelin >>>>>> On 7/26/22 09:55, Maxime Coquelin wrote: >>>>>> The bug this patch is fixing is being reproduced downstream. >>>>>> It would be great it gets merged in main branch rapidly so that we can >>>>>> perform the backport. >>>>>> >>>>>> Chenbo, are you planning a pull request for vhost/virtio in the next few >>>>>> days? If not, should the main branch maintainer pick this single patch >>>>>> directly and let the rest of the series more time for reviews? >>>>> >>>>> Based on the status of all patches in the list, I guess PR will not happen >>>>> this week. So it will be good if David/Thomas can directly pick up this. >>>> >>>> OK, sounds good to me. >>>> >>>> Thomas/David, is that good on your side? >>> >>> Is there a blocker to merge the whole series? >> >> No, I reviewed the whole series. >> >> But other patches are an enhancement, so it would not hurt to have more >> reviews. >> >> I am fine either way. > > I prefer not breaking series. > How urgent is it? Should I merge it today? > > It causes failures in some of our QE tests, so it is urgent for us. If you prefer not breaking the series, I am fine if you take it all. Thanks, Maxime