DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>, thomas@monjalon.net
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
	bruce.richardson@intel.com,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers
Date: Wed, 24 Mar 2021 11:27:10 +0000
Message-ID: <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> (raw)
In-Reply-To: <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

On 3/24/2021 4:32 AM, Tyler Retzlaff wrote:
> On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
>>> diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
>>> index c37b2e377..4353fa6b7 100644
>>> --- a/lib/librte_ethdev/meson.build
>>> +++ b/lib/librte_ethdev/meson.build
>>> @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
>>>   	'rte_mtr_driver.h',
>>>   	'rte_tm.h',
>>>   	'rte_tm_driver.h')
>>> +
>>>   indirect_headers += files(
>>>   	'rte_ethdev_core.h',
>>>   	'rte_eth_ctrl.h')
>>> +driver_sdk_headers += files(
>>> +	'ethdev_driver.h',
>>> +	'ethdev_pci.h',
>>> +	'ethdev_vdev.h')
>>> +
>>>   deps += ['net', 'kvargs', 'meter', 'telemetry']
>>
> 
> i feel like i missed a reply here.  but just to clarify only ethdev will
> be covered by this patch. inclusion of other driver headers was
> discussed off list (sorry) and it emerged that it would result in
> withdraw a number of driver api/abi that had not been marked as
> __rte_internal.
> 
> for driver api that were being exported as 'stable' a deprecation notice
> will need to be issued in order to make them part of the
> driver_sdk_headers. for that reason only ethdev is being made available
> under this option for now.
> 
> please ack/nack the patch as-is
> 

I am OK the patch for the ethdev part, hence
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


But not sure how to manage the same problem for whole project, if install all 
headers in one patch, or add them gradually via separate patches by time ...

  reply	other threads:[~2021-03-24 11:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 19:27 [dpdk-dev] [PATCH] " Tyler Retzlaff
2021-03-12 15:19 ` Ferruh Yigit
2021-03-12 15:25   ` David Marchand
2021-03-12 15:34     ` Bruce Richardson
2021-03-12 15:52       ` Thomas Monjalon
2021-03-12 18:43         ` Tyler Retzlaff
2021-03-12 22:20 ` [dpdk-dev] [PATCH v2] " Tyler Retzlaff
2021-03-15 10:06   ` Bruce Richardson
2021-03-23 17:04   ` Ferruh Yigit
2021-03-24  4:32     ` Tyler Retzlaff
2021-03-24 11:27       ` Ferruh Yigit [this message]
2021-03-24 11:30         ` Thomas Monjalon
2021-03-24 16:24           ` Tyler Retzlaff
2021-03-26 12:02             ` Ferruh Yigit
2021-03-26 20:52               ` Tyler Retzlaff
2021-03-29  9:43                 ` Ferruh Yigit
2021-03-29 12:10                   ` Thomas Monjalon
2021-03-29 15:23                     ` Ferruh Yigit
2021-03-29 19:31                       ` Thomas Monjalon
2021-03-30 12:50         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git