From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82479A0A02; Wed, 24 Mar 2021 12:27:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B89D4067B; Wed, 24 Mar 2021 12:27:21 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 762744014F for ; Wed, 24 Mar 2021 12:27:19 +0100 (CET) IronPort-SDR: AIYXYUnn3VbHVvmKfW5+TFHclPoqQhpudaklynfmRaVZlDyCto5db7ZJanVU14zWWUI4KiI6Kj zaBaskFV8Tug== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="252041083" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="252041083" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:27:18 -0700 IronPort-SDR: XS8WBAxzkJ0Q3olAAYaQ7xk2pZSRA3mugnSc4OvMGjYALydibxXSct1CmLM4LJDdR7++xxPlEf J951oZQUNreQ== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="408803956" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141]) ([10.252.28.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:27:15 -0700 To: Tyler Retzlaff , thomas@monjalon.net Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com> <33c030de-ba1c-cfd3-da28-800f151d964f@intel.com> <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: Ferruh Yigit X-User: ferruhy Message-ID: <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> Date: Wed, 24 Mar 2021 11:27:10 +0000 MIME-Version: 1.0 In-Reply-To: <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 4:32 AM, Tyler Retzlaff wrote: > On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote: >>> diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build >>> index c37b2e377..4353fa6b7 100644 >>> --- a/lib/librte_ethdev/meson.build >>> +++ b/lib/librte_ethdev/meson.build >>> @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h', >>> 'rte_mtr_driver.h', >>> 'rte_tm.h', >>> 'rte_tm_driver.h') >>> + >>> indirect_headers += files( >>> 'rte_ethdev_core.h', >>> 'rte_eth_ctrl.h') >>> +driver_sdk_headers += files( >>> + 'ethdev_driver.h', >>> + 'ethdev_pci.h', >>> + 'ethdev_vdev.h') >>> + >>> deps += ['net', 'kvargs', 'meter', 'telemetry'] >> > > i feel like i missed a reply here. but just to clarify only ethdev will > be covered by this patch. inclusion of other driver headers was > discussed off list (sorry) and it emerged that it would result in > withdraw a number of driver api/abi that had not been marked as > __rte_internal. > > for driver api that were being exported as 'stable' a deprecation notice > will need to be issued in order to make them part of the > driver_sdk_headers. for that reason only ethdev is being made available > under this option for now. > > please ack/nack the patch as-is > I am OK the patch for the ethdev part, hence Acked-by: Ferruh Yigit But not sure how to manage the same problem for whole project, if install all headers in one patch, or add them gradually via separate patches by time ...