From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6077A034F; Tue, 30 Mar 2021 08:36:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43F6D140D43; Tue, 30 Mar 2021 08:36:47 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 77EB4140D03 for <dev@dpdk.org>; Tue, 30 Mar 2021 08:36:45 +0200 (CEST) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F8fmX6rSxzmc7s; Tue, 30 Mar 2021 14:34:04 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Tue, 30 Mar 2021 14:36:36 +0800 To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com> References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1617068905-5364-1-git-send-email-humin29@huawei.com> <DM4PR11MB5534CF163FED8DA28DB48A17997D9@DM4PR11MB5534.namprd11.prod.outlook.com> From: "Min Hu (Connor)" <humin29@huawei.com> Message-ID: <7e8f5788-f9ef-bd50-47b4-c3b6b556d677@huawei.com> Date: Tue, 30 Mar 2021 14:36:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <DM4PR11MB5534CF163FED8DA28DB48A17997D9@DM4PR11MB5534.namprd11.prod.outlook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 在 2021/3/30 10:17, Li, Xiaoyun 写道: > Hi > >> -----Original Message----- >> From: Min Hu (Connor) <humin29@huawei.com> >> Sent: Tuesday, March 30, 2021 09:48 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; ajit.khaparde@broadcom.com; Li, >> Xiaoyun <xiaoyun.li@intel.com> >> Subject: [PATCH v8] app/testpmd: support multi-process >> >> From: Lijun Ou <oulijun@huawei.com> >> >> This patch adds multi-process support for testpmd. >> The test cmd example as follows: >> the primary cmd: >> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ >> --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >> >> the secondary cmd: >> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ >> --rxq=4 --txq=4 --num-procs=2 --proc-id=1 >> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >> Signed-off-by: Lijun Ou <oulijun@huawei.com> >> --- >> v8: >> * Added warning info about queue numbers and process numbers. >> >> v7: >> * Fixed compiling error for unexpected unindent. >> >> v6: >> * Add rte flow description for multiple process. >> >> v5: >> * Fixed run_app.rst for multiple process description. >> * Fix compiling error. >> >> v4: >> * Fixed minimum vlaue of Rxq or Txq in doc. >> >> v3: >> * Fixed compiling error using gcc10.0. >> >> v2: >> * Added document for this patch. >> --- >> app/test-pmd/cmdline.c | 12 +++- >> app/test-pmd/config.c | 14 +++- >> app/test-pmd/parameters.c | 11 +++ >> app/test-pmd/testpmd.c | 127 ++++++++++++++++++++++------------ >> app/test-pmd/testpmd.h | 7 ++ >> doc/guides/testpmd_app_ug/run_app.rst | 101 >> +++++++++++++++++++++++++++ >> 6 files changed, 226 insertions(+), 46 deletions(-) >> 2.7.4 > > Many commands shouldn't be allowed but now only have a brief guide in doc. This can be done in the future I think. > Overall, it looks good to me. > Thanks xiaoyun. You are right, Maybe there are more things to do about supporting multiple process for testpmd. We will perfect it continuously in future. > Acked-by: Xiaoyun Li <xiaoyun.li@intel.com> >