DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, dev@dpdk.org
Cc: jianfeng.tan@intel.com, yliu@fridaylinux.org,
	zhihong.wang@intel.com, xiao.w.wang@intel.com,
	cunming.liang@intel.com, dan.daly@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails
Date: Thu, 29 Mar 2018 14:19:35 +0200	[thread overview]
Message-ID: <7e8fb43f-4cef-efb6-069b-469ebcecc800@redhat.com> (raw)
In-Reply-To: <20180306104327.14470-2-tiwei.bie@intel.com>

Hi Tiwei,

On 03/06/2018 11:43 AM, Tiwei Bie wrote:
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>

Could you please elaborate a bit more why this is needed?
Is it fixing a real issue or just an improvement?

Thanks!
Maxime
> ---
>   lib/librte_vhost/socket.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 0354740fa..d703d2114 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -181,7 +181,7 @@ send_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num)
>   	}
>   
>   	do {
> -		ret = sendmsg(sockfd, &msgh, 0);
> +		ret = sendmsg(sockfd, &msgh, MSG_NOSIGNAL);
>   	} while (ret < 0 && errno == EINTR);
>   
>   	if (ret < 0) {
> 

  reply	other threads:[~2018-03-29 12:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 10:43 [dpdk-dev] [PATCH 0/3] Extend vhost to support VFIO based accelerator Tiwei Bie
2018-03-06 10:43 ` [dpdk-dev] [PATCH 1/3] vhost: do not generate signal when sendmsg fails Tiwei Bie
2018-03-29 12:19   ` Maxime Coquelin [this message]
2018-03-29 13:25     ` Tiwei Bie
2018-03-29 13:41       ` Maxime Coquelin
2018-03-29 13:46         ` Tiwei Bie
2018-03-29 13:46   ` Maxime Coquelin
2018-03-06 10:43 ` [dpdk-dev] [PATCH 2/3] vhost: support sending fds via send_vhost_message() Tiwei Bie
2018-03-29 12:23   ` Maxime Coquelin
2018-03-29 12:27   ` Maxime Coquelin
2018-03-06 10:43 ` [dpdk-dev] [PATCH 3/3] vhost: support VFIO based accelerator Tiwei Bie
2018-03-06 14:24   ` Maxime Coquelin
2018-03-07  8:59     ` Tiwei Bie
2018-04-18  5:49 ` [dpdk-dev] [PATCH v2] " Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e8fb43f-4cef-efb6-069b-469ebcecc800@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=cunming.liang@intel.com \
    --cc=dan.daly@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=tiwei.bie@intel.com \
    --cc=xiao.w.wang@intel.com \
    --cc=yliu@fridaylinux.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).