DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matej Vido <vido@cesnet.cz>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: remes@netcope.com
Subject: Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces
Date: Wed, 11 Apr 2018 11:36:14 +0200	[thread overview]
Message-ID: <7ea9c0b5-4d69-e473-95ef-eb43b5bebe59@cesnet.cz> (raw)
In-Reply-To: <26c45c25-7eb1-fd62-f0ef-0e1d929a80f8@intel.com>

On 10.04.2018 17:28, Ferruh Yigit wrote:
> On 4/6/2018 3:12 PM, Matej Vido wrote:
>> NFB cards employ multiple Ethernet ports.
>> Until now, Ethernet port-related operations were performed on all of them
>> (since the whole card was represented as a single port).
>> With new NFB-200G2QL card, this is no longer viable.
>>
>> Since there is no fixed mapping between the queues and Ethernet ports,
>> and since a single card can be represented as two ports in DPDK,
>> there is no way of telling which (if any) physical ports should be
>> associated with individual ports in DPDK.
>>
>> This is also described in documentation in more detail.
>>
>> Signed-off-by: Matej Vido <vido@cesnet.cz>
>> Signed-off-by: Jan Remes <remes@netcope.com>
>> ---
>>   config/common_base                                 |   5 -
>>   .../nics/img/szedata2_nfb200g_architecture.svg     | 171 +++++++++++
> Hi Matej,
>
> This patch fails to apply [1], can you please confirm you can apply it?
>
> [1]
> $ git apply --check
> dpdk-dev-1-3-net-szedata2-do-not-affect-Ethernet-interfaces.patch
> error: corrupt patch at line 270
Hi Ferruh,

I've got same error on patch downloaded from patchwork. It seems that 
the difference between the downloaded patch and the patch generated from 
git is that the long lines in svg file are split into multiple lines in 
the patch downloaded from patchwork. I suppose this could be the 
problem. Any idea how to send a patch containing svg file correctly?

Thanks,
Matej

  reply	other threads:[~2018-04-11  9:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 14:12 [dpdk-dev] [PATCH 0/3] net/szedata2: patch set for new card support Matej Vido
2018-04-06 14:12 ` [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces Matej Vido
2018-04-10 15:28   ` Ferruh Yigit
2018-04-11  9:36     ` Matej Vido [this message]
2018-04-11 10:51       ` Ferruh Yigit
2018-04-12  7:38         ` Matej Vido
2018-04-13  4:25           ` Yasufumi Ogawa
2018-04-13 10:39             ` Matej Vido
2018-04-06 14:12 ` [dpdk-dev] [PATCH 2/3] net/szedata2: add support for new NIC Matej Vido
2018-04-06 14:12 ` [dpdk-dev] [PATCH 3/3] net/szedata2: add kernel module dependency Matej Vido
2018-04-12  7:41 ` [dpdk-dev] [PATCH v2 0/3] net/szedata2: patch set for new card support Matej Vido
2018-04-13 16:32   ` Ferruh Yigit
2018-04-27  8:57   ` [dpdk-dev] [PATCH 1/1] doc: update doc and release notes for szedata2 driver Matej Vido
2018-04-27 13:11     ` Ferruh Yigit
2018-04-12  7:41 ` [dpdk-dev] [PATCH v2 1/3] net/szedata2: do not affect Ethernet interfaces Matej Vido
2018-04-12  7:41 ` [dpdk-dev] [PATCH v2 2/3] net/szedata2: add support for new NIC Matej Vido
2018-04-12 16:11   ` Ferruh Yigit
2018-04-13  8:17     ` Jan Remeš
2018-04-13 14:26       ` Ferruh Yigit
2018-04-13 15:03         ` Jan Remeš
2018-04-13 16:29           ` Ferruh Yigit
2018-04-18  7:21             ` Matej Vido
2018-04-12  7:41 ` [dpdk-dev] [PATCH v2 3/3] net/szedata2: add kernel module dependency Matej Vido

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ea9c0b5-4d69-e473-95ef-eb43b5bebe59@cesnet.cz \
    --to=vido@cesnet.cz \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=remes@netcope.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).