From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91877A0564; Tue, 24 Mar 2020 10:55:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D6BA1C0C2; Tue, 24 Mar 2020 10:55:00 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 976411C07E for ; Tue, 24 Mar 2020 10:54:58 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.137]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1BFB12005A; Tue, 24 Mar 2020 09:54:58 +0000 (UTC) Received: from us4-mdac16-13.at1.mdlocal (unknown [10.110.49.195]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 1A5A06009B; Tue, 24 Mar 2020 09:54:58 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us5.ppe-hosted.com (unknown [10.110.50.12]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9B15422004D; Tue, 24 Mar 2020 09:54:57 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 48E3440059; Tue, 24 Mar 2020 09:54:57 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 24 Mar 2020 09:54:51 +0000 To: , CC: , References: <20200320112914.18620-1-chandu@amd.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <7eb245ed-5920-5e05-cc1c-63a5e92c8a04@solarflare.com> Date: Tue, 24 Mar 2020 12:54:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200320112914.18620-1-chandu@amd.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25310.003 X-TM-AS-Result: No-13.011000-8.000000-10 X-TMASE-MatchedRID: TmlY9+XBoTkeimh1YYHcKPZvT2zYoYOwC/ExpXrHizyRoQLwUmtov1Rk +8rJ+BI6M/VnVv2ZB0znIakAFP3RaOYlblXJFLrufid4LSHtIANFadcfrR12T6C4sXiuXcggyJN a6DYLgM0003R2T+VvjnDlPghqPnfyYlldA0POS1IaPMGCcVm9DqdlL9piCOvOIqkaHT6bHiGoqd fL9A1mFXX/Z6Ov4FYmnR3g21efZf7GM6Lyf93P2+b3p4cnIXGNb1d/zpzApVo9phCcpYL3wbBXu d9Ra+w0CXPNi/1NPOtUoLbtLYHys3tQf2I7ph75x5sgyUhLCNvcbNJY9S/K7/SeWrzHd3swCsBx Yqyiv+oi5dUEY1dFHDtE4Gk3d2tD7sb61lXuhteHZXNSWjgdU8nlJe2gk8vIkY8eITaSJPhx1vc 8zhmExbpc9PLeQ6rICiZkTsETrD3d2snq1AJbnhIRh9wkXSlFsKi4EXb8AIpSMUnCl2ZytATqDL ODdlEuD6Q5DylvBNGRk6XtYogiau9c69BWUTGwVnRXm1iHN1bEQdG7H66TyH4gKq42LRYk7bv0y OEMCkZN+M8KD4iXain54pWCkiVH5phf7/L9rXl+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.011000-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25310.003 X-MDID: 1585043698-zefH1Ldac8Pp Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add RSS reta/hash query and update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/20/20 2:29 PM, chandu@amd.com wrote: > From: Chandu Babu N > > add support for RSS ethdev_ops reta_update, reta_query > rss_hash_update, rss_hash_conf_get The patch should update doc/guides/nics/features/axgbe.ini to advertise corresponding features. > > Signed-off-by: Chandu Babu N > --- > drivers/net/axgbe/axgbe_dev.c | 5 +- > drivers/net/axgbe/axgbe_ethdev.c | 146 +++++++++++++++++++++++++++++++ > drivers/net/axgbe/axgbe_ethdev.h | 3 + > 3 files changed, 152 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c > index 5f0f19592..af62eae3b 100644 > --- a/drivers/net/axgbe/axgbe_dev.c > +++ b/drivers/net/axgbe/axgbe_dev.c > @@ -614,7 +614,7 @@ static int axgbe_write_rss_reg(struct axgbe_port *pdata, unsigned int type, > return -EBUSY; > } > > -static int axgbe_write_rss_hash_key(struct axgbe_port *pdata) > +int axgbe_write_rss_hash_key(struct axgbe_port *pdata) > { > struct rte_eth_rss_conf *rss_conf; > unsigned int key_regs = sizeof(pdata->rss_key) / sizeof(u32); > @@ -638,7 +638,7 @@ static int axgbe_write_rss_hash_key(struct axgbe_port *pdata) > return 0; > } > > -static int axgbe_write_rss_lookup_table(struct axgbe_port *pdata) > +int axgbe_write_rss_lookup_table(struct axgbe_port *pdata) > { > unsigned int i; > int ret; > @@ -683,6 +683,7 @@ static void axgbe_rss_options(struct axgbe_port *pdata) > uint64_t rss_hf; > > rss_conf = &pdata->eth_dev->data->dev_conf.rx_adv_conf.rss_conf; > + pdata->rss_hf = rss_conf->rss_hf; > rss_hf = rss_conf->rss_hf; > > if (rss_hf & (ETH_RSS_IPV4 | ETH_RSS_IPV6)) > diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c > index 867058845..f42bb7a0d 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.c > +++ b/drivers/net/axgbe/axgbe_ethdev.c > @@ -60,6 +60,18 @@ axgbe_dev_xstats_get_names_by_id(struct rte_eth_dev *dev, > const uint64_t *ids, > unsigned int size); > static int axgbe_dev_xstats_reset(struct rte_eth_dev *dev); > +static int > +axgbe_dev_rss_reta_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_reta_entry64 *reta_conf, > + uint16_t reta_size); > +static int > +axgbe_dev_rss_reta_query(struct rte_eth_dev *dev, > + struct rte_eth_rss_reta_entry64 *reta_conf, > + uint16_t reta_size); It looks like style is inconsistent for above to declarations vs declarations around. > +static int axgbe_dev_rss_hash_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf); > +static int axgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf); > static int axgbe_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info); > static int axgbe_flow_ctrl_get(struct rte_eth_dev *dev, > @@ -201,6 +213,10 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = { > .xstats_get_names = axgbe_dev_xstats_get_names, > .xstats_get_names_by_id = axgbe_dev_xstats_get_names_by_id, > .xstats_get_by_id = axgbe_dev_xstats_get_by_id, > + .reta_update = axgbe_dev_rss_reta_update, > + .reta_query = axgbe_dev_rss_reta_query, > + .rss_hash_update = axgbe_dev_rss_hash_update, > + .rss_hash_conf_get = axgbe_dev_rss_hash_conf_get, > .dev_infos_get = axgbe_dev_info_get, > .rx_queue_setup = axgbe_dev_rx_queue_setup, > .rx_queue_release = axgbe_dev_rx_queue_release, > @@ -450,6 +466,136 @@ axgbe_dev_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr, > return 0; > } > > +static int > +axgbe_dev_rss_reta_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_reta_entry64 *reta_conf, > + uint16_t reta_size) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + unsigned int i, idx, shift; > + int ret; > + > + if (!pdata->rss_enable) { > + PMD_DRV_LOG(ERR, "RSS not enabled\n"); > + return -ENOTSUP; > + } > + > + if (!reta_size || reta_size > AXGBE_RSS_MAX_TABLE_SIZE) { DPDK style guide [1] says to use comparison to 0 instead of ! [1] https://doc.dpdk.org/guides/contributing/coding_style.html#c-statement-style-and-conventions > + PMD_DRV_LOG(ERR, "reta_size %d is not supported\n", reta_size); > + return -EINVAL; > + } > + > + for (i = 0; i < reta_size; i++) { > + idx = i / RTE_RETA_GROUP_SIZE; > + shift = i % RTE_RETA_GROUP_SIZE; > + if ((reta_conf[idx].mask & (1ULL << shift)) == 0) > + continue; > + pdata->rss_table[i] = reta_conf[idx].reta[shift]; > + } > + > + /* Program the lookup table */ > + ret = axgbe_write_rss_lookup_table(pdata); > + return ret; > +} > + > +static int > +axgbe_dev_rss_reta_query(struct rte_eth_dev *dev, > + struct rte_eth_rss_reta_entry64 *reta_conf, > + uint16_t reta_size) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + unsigned int i, idx, shift; > + > + if (!pdata->rss_enable) { > + PMD_DRV_LOG(ERR, "RSS not enabled\n"); > + return -ENOTSUP; > + } > + > + if (!reta_size || reta_size > AXGBE_RSS_MAX_TABLE_SIZE) { Here too > + PMD_DRV_LOG(ERR, "reta_size %d is not supported\n", reta_size); > + return -EINVAL; > + } > + > + for (i = 0; i < reta_size; i++) { > + idx = i / RTE_RETA_GROUP_SIZE; > + shift = i % RTE_RETA_GROUP_SIZE; > + if ((reta_conf[idx].mask & (1ULL << shift)) == 0) > + continue; > + reta_conf[idx].reta[shift] = pdata->rss_table[i]; > + } > + return 0; > +} > + > +static int > +axgbe_dev_rss_hash_update(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + int ret; > + > + if (!pdata->rss_enable) { > + PMD_DRV_LOG(ERR, "RSS not enabled\n"); > + return -ENOTSUP; > + } > + > + if (!rss_conf) { Here too. It should comparison vs NULL. > + PMD_DRV_LOG(ERR, "rss_conf value isn't valid\n"); > + return -EINVAL; > + } > + > + if (rss_conf->rss_key && and here > + rss_conf->rss_key_len == AXGBE_RSS_HASH_KEY_SIZE) { > + rte_memcpy(pdata->rss_key, rss_conf->rss_key, > + AXGBE_RSS_HASH_KEY_SIZE); > + /* Program the hash key */ > + ret = axgbe_write_rss_hash_key(pdata); > + if (ret) and here > + return ret; > + } > + > + pdata->rss_hf = rss_conf->rss_hf & AXGBE_RSS_OFFLOAD; > + > + if (pdata->rss_hf & (ETH_RSS_IPV4 | ETH_RSS_IPV6)) > + AXGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, IP2TE, 1); > + if (pdata->rss_hf & > + (ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP)) > + AXGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, TCP4TE, 1); > + if (pdata->rss_hf & > + (ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP)) > + AXGMAC_SET_BITS(pdata->rss_options, MAC_RSSCR, UDP4TE, 1); > + > + /* Set the RSS options */ > + AXGMAC_IOWRITE(pdata, MAC_RSSCR, pdata->rss_options); > + > + return 0; > +} > + > +static int > +axgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev, > + struct rte_eth_rss_conf *rss_conf) > +{ > + struct axgbe_port *pdata = dev->data->dev_private; > + > + if (!pdata->rss_enable) { > + PMD_DRV_LOG(ERR, "RSS not enabled\n"); > + return -ENOTSUP; > + } > + > + if (!rss_conf) { and here > + PMD_DRV_LOG(ERR, "rss_conf value isn't valid\n"); > + return -EINVAL; > + } > + > + if (rss_conf->rss_key && and here > + rss_conf->rss_key_len <= AXGBE_RSS_HASH_KEY_SIZE) { > + rte_memcpy(rss_conf->rss_key, pdata->rss_key, > + AXGBE_RSS_HASH_KEY_SIZE); > + } > + rss_conf->rss_key_len = AXGBE_RSS_HASH_KEY_SIZE; > + rss_conf->rss_hf = pdata->rss_hf; > + return 0; > +} > + > static void > axgbe_dev_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) > { > diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h > index f10ec4a40..cedce5af6 100644 > --- a/drivers/net/axgbe/axgbe_ethdev.h > +++ b/drivers/net/axgbe/axgbe_ethdev.h > @@ -594,6 +594,7 @@ struct axgbe_port { > uint32_t rss_table[AXGBE_RSS_MAX_TABLE_SIZE]; > uint32_t rss_options; > int rss_enable; > + uint64_t rss_hf; > > /* Hardware features of the device */ > struct axgbe_hw_features hw_feat; > @@ -653,5 +654,7 @@ void axgbe_init_function_ptrs_i2c(struct axgbe_i2c_if *i2c_if); > void axgbe_set_mac_addn_addr(struct axgbe_port *pdata, u8 *addr, > uint32_t index); > void axgbe_set_mac_hash_table(struct axgbe_port *pdata, u8 *addr, bool add); > +int axgbe_write_rss_lookup_table(struct axgbe_port *pdata); > +int axgbe_write_rss_hash_key(struct axgbe_port *pdata); > > #endif /* RTE_ETH_AXGBE_H_ */ >