From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D37A142A99; Mon, 8 May 2023 18:00:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEB59410ED; Mon, 8 May 2023 18:00:51 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2058.outbound.protection.outlook.com [40.107.96.58]) by mails.dpdk.org (Postfix) with ESMTP id 1EDB940685 for ; Mon, 8 May 2023 18:00:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OF6g97OK4193KuaTBTDnAY/AaJfrN33b2MM0BArAWKaqkqEb90VIwLmxndGr2QShrHjWuqYjjl4etQxUb5LwDBtKHodistlIUdUqZcS6NpahSmq2jC0f+AhHPMmhijP06SWIKip8r511eur15laAXdmdVPAzjPfwDREDfY5JGV/q+qjcK3NVNVmuvMrciooXzaM/n8CWqjXQ0MAg8uLfScVIvNnsUwTdUuj8/BVMbEoDviAy588Z0VH/1CRo2Gea5Q5Q9Wez8XXyIRQdFPe3N9hM0WSO2WNVyNbZPeDOuGnDbga034iUrT7nL2P4PSDIz7mkLTUFb7b6W0IPyKZg0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2l6NvL7BrtwiUXvknCv0+0zlys37pHHD9lg7LwtSVCs=; b=JhZCZ7dkE9U7ZGRH/reDKPI47SJrcnRkCqvo99Kk2ZRJJhDEKogfO2hm3frXaRqDMCo3IPdTAcFWNC67hGz0H8is0p3xZ/SJNl1pMxqhItj/gxDGBO+Jbm7t8bESrn1SZhsgpEgOvV+LhI1FwyUpCJwZizz67dFmxFGuT5AmQw/TaohBu/+tvEV3jUqYavqITGYmK4XHX9Q7UPHAeJnyy35Nif0YIIyyiC4xFdVxWqpjiVnSuRjFDQqKsSFoEF7o2oULghrSoOHeuJtvHssuo6PEd4Oydn3/yGhZYvvfQjdeWHtjBiyCaAewOF1lYo21OYK3QTF2Ov9D0QsFOkd2WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2l6NvL7BrtwiUXvknCv0+0zlys37pHHD9lg7LwtSVCs=; b=cM9jR6zn/34EyXudJBIRQ3J4FswxdS2+YepXVXXOeX/7ICHOOsCoNK2KYGn42duUZnEpOj0Xu5ugPrmJvmhdmkUKlHc9bHPNLDnyU/zKEzUFWn5jOnlI42oIM+dKSpSMYQhDGjjZc1CtREeiWxDn3w6U8aaYTzwiG/v81vWWSyI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB8574.namprd12.prod.outlook.com (2603:10b6:8:166::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 16:00:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6363.032; Mon, 8 May 2023 16:00:48 +0000 Message-ID: <7eb32bfb-7c0e-3073-2e81-eb39f16c26fc@amd.com> Date: Mon, 8 May 2023 17:00:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Rushil Gupta Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst References: <20230414051454.1245936-1-rushilg@google.com> <20230426213700.2668699-1-rushilg@google.com> From: Ferruh Yigit Subject: Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented. In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0216.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB8574:EE_ X-MS-Office365-Filtering-Correlation-Id: b9a81604-2808-43c9-0a90-08db4fdd635c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wtENJs9v+IGf4CjknFKRdJ5bOrk2ls6Kp6rwdipJhxz/A3v5auhIGoPoBqJ03OPrl5zrvy/UTUaX9g39x1WOnix5XBXuBNb1dvzmwP/L9fpTnv5l4T+5APQsNDol4Qub6COClRVpswzGTgj0CemTl9JYwbZf/6vepnWFrpITyNQob6opPGrqajhTRxUjduPMUWV/LBa3j4PaeAwTYyEJaiAh8UkcEjov6/YlV046AC2SXKQ/Dv+CBQkD0hvxWuGopcfm8SODpmg3/CeYGzkvUvv4Nwj++/kGRmePtOJVDaUVWWM8RkER7mavtqVzOj8tMyXJjs97dFZrsfdHM5O+1nSN2IkxA/j+Y6JdGrh6Dh9lMq7b8o0unsjtzdeorcNRYfhtkp9CBlySLbgaIpUSQyTZ6PMjDgAVhvLcwlwwHgKYv4wSzDQUGGjF+EqS4F5TgaqWtKFq3QgpZkTnhO74+0YfWkcYKZMdb+mz9zHSwNAacyLwxW4XWQ52EQvlxajZnCI7v0Q9SfK0p8HB62lERwwEEQSjNsLDIKWn0vZBhCvhOnivq2GaCGGIVHpGbNXx9MnA0qFh7n9USXbDb28USZuXSaj0oMqT7GwG4Di4IgRcX12dh6mhATMKnChPxW1klnwD3qkoEuAvXsU86hSqFA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(396003)(346002)(39860400002)(136003)(451199021)(31686004)(66556008)(6916009)(4326008)(66946007)(316002)(478600001)(6486002)(66476007)(36756003)(53546011)(31696002)(86362001)(83380400001)(6512007)(2616005)(26005)(6506007)(6666004)(44832011)(5660300002)(8936002)(41300700001)(8676002)(2906002)(38100700002)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFU0UXpGeWlOaklWUitGcy9odGtkY2RKRHFpYjdpUUNMKzJhMHlIREltK3Rj?= =?utf-8?B?Und2NnR4SURrVkNTRDNiRTRwWTlrbWt6UnZtNWJNS1g2VEk5T2NhYVRlckor?= =?utf-8?B?Q0xuTzF2US9ZRHlPaXMyd2pveVdNeHFsWlJpbTczZ00yNGNVbmczSGJPMUYy?= =?utf-8?B?QkR2MnlVL0x1R3BHdi9CNWdVTTBFclhrNWQ1Ni8weklLdDliK0U1UWU5QnVC?= =?utf-8?B?QUxRZFgxS2dFNlQxYUIrcVVvVk43RWdOYlRHSGRWOXRQZzlkNE9rS0ZnV29Z?= =?utf-8?B?azFwa2ViLzZuYW93VGdHMjZzWmdYQk9pY0hic01SRXJYUFhZQWl2TTNpUnVm?= =?utf-8?B?UUpMWkNkTytUSlFvcjVVa3lib3hjSm1nZWFqcWV2VTZ1aHZkd0ZleUN6RDRp?= =?utf-8?B?QzJhMzd0RndjeDc2MiswNnRCeG1jV3h5M2FWR20zTE9Vek5WM0JBVHVZWUI2?= =?utf-8?B?eGlyWVdSOEVXVW5hdGNCMHFPSlA1OE94dHkrY05TK0xvaXFoUFppTENZbS9R?= =?utf-8?B?aVlteS9VUW1WL2EwL1J0M1pxeGpHQW5SUVd4c2p5aFUrWjNFa29QKysxS3hW?= =?utf-8?B?MlFKT09URHZQYm01bzZWRWcxUmk5bXU1NEtZQXd6Mk50cUlvUWdDWWlFNzFH?= =?utf-8?B?NGVnOVNaTEtpQkUraytDWVV6SmVXOEUvSkZUeFptMUNraDF5VU9TcXVGY2lH?= =?utf-8?B?Sit6Mk5ZWVhNTmp3TkNBcTFBTXJFOW1PL25xa1FDdlpDaFFYTVZ4ejdLd29E?= =?utf-8?B?d1BEckEzNkgzZ1dLVWFhQTU2YWpNeS8vSXF2UlhSVVdQdFlTVTkxSStWVk4v?= =?utf-8?B?N0FCTkVyTW9uSVMwZ3Jra0dWWjRPK2gvSk82VUI2WVVZNWsxL1U4S08yWnpE?= =?utf-8?B?UzByS3hOMDdQTDh4L050RUdhNHcwc3FQSVI0NGFWclhRZ2o4czNJdWxSblQ0?= =?utf-8?B?OGdydHJzV21RcU9kVE1VeVZPa3p3MUJxeEhubE92UmxsaFBIVks5bmU2REpw?= =?utf-8?B?bmgwUFZMMEh1OE9xR1Jad0hNalNJREl2NTNHa0lrNEhUY09vUHk3TGx0WFk1?= =?utf-8?B?V3BFNytpMTA4dG5PdmUxM3ZuRU5FL1ZlcmhJSHlsRDlKR1I0UDg0d1pPOVRl?= =?utf-8?B?U2Vua29RMGR5Kzc1RmZyVnZ0REtYdWdRL3Rna1V6QkJhV1BsSHo2Y3hicU9B?= =?utf-8?B?aGZyU08yV1V5UysvTXNRUFBOYjQ5Z1BaLzViWVU4d2k2d1diNFRCU3MzZGN2?= =?utf-8?B?SEUyWE5GWDhtY0Y4WTVZT0xiS0p1Sk1YRFE1ZEFXeEFBVnhLUGJyMjA0QUlK?= =?utf-8?B?MzBVa3RoWDdzZkRqMWYzK2JoUWp0cU5pd1Znci9WakI3UEE2dW42TURYTk9O?= =?utf-8?B?OVpIQ3BVWXEram9qaExqVURFem90Wk1ETFQxVS9DSjJraEJCeUhnU2VVSk50?= =?utf-8?B?WnBWNzBiV1FlYkJTK1BqRjJjVVdJSTFGSDMxdXR2Wkw0a05vU3hyK0YzMHNN?= =?utf-8?B?c3Fvc0JuNjR2U2l3bnhvOUkyYXEyQWNTbDJXQWtxRDBRTnJWamJNbDUvdkRu?= =?utf-8?B?Wk5lalc0RzY3Z1FPWjluUllKTkNHbGxDTzIwNmtLWHJqY21IakNUbTFqNlc2?= =?utf-8?B?Zm5KOHB5QzVCc2VKR2lXUkEvNHAwdStNNUkzTHF6UDV6ck1SbFJWZVZCZVBz?= =?utf-8?B?VDZYb0ozT3BFODcvQ05MOUoxVDgyWHVnL0VWYTR0alorMHZmRno3L0tDT05t?= =?utf-8?B?aXI3RWlhQmpYTU44VWtWNnE5V1UzYUk4eXdMaG1kd2R1LzFYczFNSHNMUmxw?= =?utf-8?B?OGcvdVRWUXNqZ3REQ09Bbi9od01KOFN5eG5vUGh1dlIwK3ZmeXREMlFVRmlR?= =?utf-8?B?ME1HdmFMbE1COXdHY3dlME5iZlRKRm1acEU0Nm95N1JKWXZkZVZSdmRxUWla?= =?utf-8?B?WTJTUnROWjF6bTluMXh1ekl5eTlTQzdPR0Y0K0RiL0g1YkdFOWFKdDRCU0g5?= =?utf-8?B?Z2hvYzFQdFBKeFJCcEU3S0tJekhoYy9LK3BBb09OdmR2dE5vT1ZKci9jTVI4?= =?utf-8?B?WEM4b1F5dDFGRElyWTRIWjk5aXRQNzVmeVNIbUNISnJWdXhkenZBMklKY05S?= =?utf-8?Q?Bpan6HC+ePxzmxlkMsNAa35tI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9a81604-2808-43c9-0a90-08db4fdd635c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 16:00:48.2106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XtwjJx0Y+z4L8kPspgMfMASEyF7fcs/0ftegzEmZu6+4Sk/7XJKwE92eMqN+jS8U X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8574 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 7:23 AM, Rushil Gupta wrote: >>> +#ifndef _GVE_VERSION_H_ >>> +#define _GVE_VERSION_H_ >>> + >>> +#include >>> + >>> +#define GVE_VERSION_PREFIX "DPDK-" >>> +#define GVE_VERSION_MAJOR 1 >>> +#define GVE_VERSION_MINOR 0 >>> +#define GVE_VERSION_SUB 0 >>> + >> Is this GVE base version, or DPDK gve version? >> Previous version information was "GVE-1.3.0", now it is becoming >> "DPDK-1.0.0", >> is this breaking the version link with GVE base version and creating a >> new versioning scheme for DPDK GVE driver? >> >> Btw, documentation still has "v1.3.0. GVE base code", should it be >> updated as well? >> > DPDK-1.0.0 is the DPDK driver version. GVE driver versioning only > applies for linux kernel Gvnic driver. > Similarly Windows Gvnic driver has different versioning system. So creating a new versioning scheme for DPDK driver, I guess that is OK. Since there is a new version, is it clear how to manage the versioning, like when to update major version and when to update minor etc? If so can you please document this? And base code is still coming from the Linux kernel driver, I wonder if a mapping between versions of these two is required. As mentioned "v1.3.0" is still in the documentation, what happens if base code updated and some relevant update is required in the dpdk driver code? How to record/manage this? Some drivers records the base code version in a readme file in the base folder, maybe same can be done.