From: wangyunjian <wangyunjian@huawei.com> To: <dev@dpdk.org> Cc: <david.marchand@redhat.com>, <jia.guo@intel.com>, <jerinj@marvell.com>, <jerry.lilijun@huawei.com>, <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>, <stable@dpdk.org> Subject: [dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists Date: Wed, 21 Oct 2020 19:19:49 +0800 Message-ID: <7ec6b12bf0f9fcdb2306dec72390a853abdf2f56.1603207676.git.wangyunjian@huawei.com> (raw) In-Reply-To: <cover.1603207676.git.wangyunjian@huawei.com> From: Yunjian Wang <wangyunjian@huawei.com> We should return an error value, when the callback is already exist. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Suggested-by: David Marchand <david.marchand@6wind.com> --- lib/librte_eal/common/eal_common_dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index d990bfd20d..8a3bd3100a 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -480,7 +480,9 @@ rte_dev_event_callback_register(const char *device_name, RTE_LOG(ERR, EAL, "The callback is already exist, no need " "to register again.\n"); + event_cb = NULL; ret = -EEXIST; + goto error; } rte_spinlock_unlock(&dev_event_lock); -- 2.23.0
next prev parent reply other threads:[~2020-10-21 11:20 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-03 9:44 [dpdk-dev] [PATCH v4 0/3] fixes for device event wangyunjian 2020-07-03 9:46 ` [dpdk-dev] [PATCH v4 1/3] eal: fix memory leak when removing event_cb wangyunjian 2020-07-29 11:47 ` wangyunjian 2020-07-30 2:57 ` Jeff Guo 2020-07-03 9:46 ` [dpdk-dev] [PATCH v4 2/3] eal: return error code when failure wangyunjian 2020-07-03 9:46 ` [dpdk-dev] [PATCH v4 3/3] eal: fix a wrong returned value when callback exists wangyunjian 2020-10-20 13:18 ` [dpdk-dev] [dpdk-stable] " David Marchand 2020-10-20 14:31 ` wangyunjian 2020-09-03 3:33 ` [dpdk-dev] [PATCH v4 0/3] fixes for device event wangyunjian 2020-10-21 11:18 ` [dpdk-dev] [PATCH v5 " wangyunjian 2020-10-21 11:19 ` [dpdk-dev] [PATCH v5 1/3] eal: fix memory leak when removing event_cb wangyunjian 2020-10-21 11:19 ` [dpdk-dev] [PATCH v5 2/3] eal: return error code when failure wangyunjian 2020-10-22 12:51 ` David Marchand 2020-10-23 9:05 ` wangyunjian 2020-10-21 11:19 ` wangyunjian [this message] 2020-10-22 12:55 ` [dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists David Marchand 2020-10-23 9:05 ` wangyunjian 2020-10-23 11:37 ` [dpdk-dev] [PATCH v5 0/3] fixes for device event David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ec6b12bf0f9fcdb2306dec72390a853abdf2f56.1603207676.git.wangyunjian@huawei.com \ --to=wangyunjian@huawei.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=jerry.lilijun@huawei.com \ --cc=jia.guo@intel.com \ --cc=stable@dpdk.org \ --cc=xudingke@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git