From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB329A0560; Mon, 17 Oct 2022 16:08:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A72F9410DC; Mon, 17 Oct 2022 16:08:09 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8EDAE410EC; Mon, 17 Oct 2022 16:08:07 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 130BE84; Mon, 17 Oct 2022 17:08:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 130BE84 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666015687; bh=quQGkFA7Jh+JeW9uf6j3vBTwvh+KK9uRbXQ2qbsGdj0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HCWSisl6eY7PTW35DygGnTeZo9ANAZf/ZH2/CQTq3xbQ125tQZ6KlhTZACb3qAeHk L6hSqzAJtYpagSi2BZoc+Yll/nTFvPvMoDPEsbtZY0RD4c7ZgbW+F2F52Rh+m9nOEY v4guIFZqQXkyWOfRLQDiXZUkrNAzaBfUMQuOU9eo= Message-ID: <7ee1b944-9ca1-727b-43a5-8ce90019e4ec@oktetlabs.ru> Date: Mon, 17 Oct 2022 17:08:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] net/bonding: fix descriptor limit reporting Content-Language: en-US To: Chas Williams <3chas3@gmail.com>, Chas Williams , "Min Hu (Connor)" Cc: stable@dpdk.org, Hari Kumar Vemula , Ivan Malov , dev@dpdk.org References: <20220911121901.3989343-1-ivan.malov@oktetlabs.ru> <8c5c2c63-20de-c1a5-ff06-142bfbc49c47@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/17/22 15:40, Chas Williams wrote: > On 10/17/22 04:40, Andrew Rybchenko wrote: >> Chas, Cornor, could you review the patch, please. >> >> Thanks, >> Andrew. >> >> On 9/11/22 15:19, Ivan Malov wrote: >>> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") >>> breaks reporting of "nb_min" and "nb_align" values obtained from >>> back-end devices' descriptor limits. This means that work done >>> by eth_bond_slave_inherit_desc_lim_first() as well as >>> eth_bond_slave_inherit_desc_lim_next() gets dismissed. >>> >>> Revert the offending commit and use proper workaround >>> for the test case mentioned in the said commit. >>> >>> Meanwhile, the test case itself might be poorly constructed. >>> It tries to run a bond with no back-end devices attached, >>> but, according to [1] ("Requirements / Limitations"), >>> at least one back-end device must be attached. >>> >>> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst >>> >>> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ivan Malov >>> Reviewed-by: Andrew Rybchenko > > Acked-by: Chas Williams <3chas3@gmail.com> Applied to dpdk-next-net/main, thanks.