From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F979A052B; Fri, 31 Jul 2020 16:33:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF849276C; Fri, 31 Jul 2020 16:33:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BF3902629 for ; Fri, 31 Jul 2020 16:33:50 +0200 (CEST) IronPort-SDR: Jkw6p2CY7hqIpj20lrl+KgYytjDCd1FzAWxy8W2Hjor3i8AjiLS2uFE19VMq5n2DcmbYTk6myv lvtbNY5OkDMw== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="131852434" X-IronPort-AV: E=Sophos;i="5.75,418,1589266800"; d="scan'208";a="131852434" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2020 07:33:49 -0700 IronPort-SDR: cxkLm28l4rCHC/ycuQyXUOtm8eLwYeQLtr5ojmghZB6ct1oCrUspmNbKt7GSnX2ypOOymT4QDS xt9NaIFpPXvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,418,1589266800"; d="scan'208";a="304953358" Received: from dwdohert-mobl.ger.corp.intel.com (HELO [10.213.231.78]) ([10.213.231.78]) by orsmga002.jf.intel.com with ESMTP; 31 Jul 2020 07:33:47 -0700 To: Arek Kusztal , dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, anoobj@marvell.com, shallyv@marvell.com, roy.fan.zhang@intel.com, konstantin.ananyev@intel.com References: <20200729142219.13376-1-arkadiuszx.kusztal@intel.com> From: "Doherty, Declan" Message-ID: <7ef3a611-8a58-db38-d476-d5965bb90837@intel.com> Date: Fri, 31 Jul 2020 15:33:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200729142219.13376-1-arkadiuszx.kusztal@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/07/2020 3:22 PM, Arek Kusztal wrote: > This is proposal to move AES-GMAC algorithm to AEAD set > of algorithms. It is however not 100% conformant GMAC as instead of aad pointer > data to be authenticated is passed normally and aead.data.length field > is used to specify length of data to be authenticated. > Reason behind this move is that GMAC is variant of GCM so it may > simplify implementations that are using these algorithms (mainly IPsec). > AES-GMAC therefore needs to be removed from auth algorithms. > > Signed-off-by: Arek Kusztal > --- .. > I think this makes sense in light of how AES-GMAC support is specified in the IPsec GMAC rfc (https://tools.ietf.org/html/rfc4543) Acked-by: Declan Doherty