From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 510C2A0C41; Fri, 5 Nov 2021 22:33:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E8C040689; Fri, 5 Nov 2021 22:33:38 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C40A240151 for ; Fri, 5 Nov 2021 22:33:35 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10159"; a="219182866" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="219182866" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 14:33:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="730049288" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 05 Nov 2021 14:33:34 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 14:33:34 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 5 Nov 2021 14:33:34 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 5 Nov 2021 14:33:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSFrrLEjrH3hETnvxy4j0mGt5VmveF1jezkaHDTAzMwrRnPIL+S3AHS3DoRoJPGNbZwivmq12j6eyBagiOXDg+42Dv+NnOxVRWVKw2hSqD9lWRbVI028fG8sCzWoZHqz5vveMlKdfPSprlDwIEbRQF3ckrX/csx2mQFvqtNCcMyMbhFYLQ4ciKOBTNq+xBulYTH3KdoClxYhol0d5eHbLeEwMwM8EPHEYwG2BcrLt8tZmSCs06WVfsThvpuWCbSjhpC74XVYQJZXXyHFsrz2at6N2wSqQhnUdmTDNXZnlYylatVJGp9HUQlPg4lVmSiov0VtuyOVZIWIdT2OAFzs2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZpGu9EyMOhq1w+0U1n20k3vwmqnBUZ9xT59HCcM+8mo=; b=gYdebqlzpstFfkv0pkScmtNAyAPJFOhaw58ObAV+vhADkPbB9fWWH6FTULfrXTaqWZ/WOpxcP3/mU5ZL+zmv0hN5Q5x11yFy3TInExZuTaTf6Sz6oUcbXdYpHLOkAOVpkDOvrA9m+hRBOO0YHrfo+0PlLArx0HGzfi2BNJE677AAynIndgMSEKnIb3kXx2h+80cCgMeyCpmDD5AGRiacISe/po+2klSS6Dxxd9lehE6e981KGweCUzFNXWOFrOBeX7xCFYvZjBl+6qOwcezX64RxSC4BbU4g4hmSwNfV2Cvz1Yph16/II+RUTXaLIuX2cd3Mq+OH6360exw3caio3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZpGu9EyMOhq1w+0U1n20k3vwmqnBUZ9xT59HCcM+8mo=; b=bvTs+ywOaD2iBgkhGjN5QXe7boi9lZ08JL65BnvyLipyoQhteBn/W4W305n7KCTIO7YzB9XZ3YBt4t0AGRFs3FUO5jTVKzf4+C1SuiZC84XeZuQIY8zp/ytoKTgbrNExH5PrtPPZkUTnE4FXk1cbdQKmH+GJdVn8CTiUkkP1WuM= Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Fri, 5 Nov 2021 21:33:32 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021 21:33:32 +0000 Message-ID: <7f14a405-a861-dd9d-8fea-015ba25187f1@intel.com> Date: Fri, 5 Nov 2021 21:33:26 +0000 Content-Language: en-US To: Stephen Hemminger , Thomas Monjalon CC: Andrew Rybchenko , , "David Marchand" , Olivier Matz References: <20211102234434.2639807-1-ferruh.yigit@intel.com> <2611380.4jmpmGm5TL@thomas> <0db26ffd-1c1c-e920-0390-ee863862b071@oktetlabs.ru> <2425969.3b2ZdX0MHy@thomas> <20211105092649.32fadae4@hermes.local> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211105092649.32fadae4@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0334.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0334.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Fri, 5 Nov 2021 21:33:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7b88257-c302-4e92-c525-08d9a0a3ea80 X-MS-TrafficTypeDiagnostic: PH0PR11MB5013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f0FqYyOSE4im/zHMGJVLzeXht2aE3SRkCyhBxF8XN9ZhvXFMP3/e2d0AdMVjRgujfaBsSlKguTDUWnycmdr6HtsFNTw6CRVJgjYZ1dhxk+ddVMnbA7yRalCit7mRBr7CSW/hCBioD7s064tvjwy6TyRDbXLul9WlP2FfbwauFZWxRDrpDjad0lT67d9Wjs2pNS/Unh2DNNEfX1JmHmdI+yp0AUszX31UC0L391eVf/HGellcSFZzyFI+6TwozofOON1Tk98j+AnHMzqkPDeV1Cv1NOnqEgMQhPYhsQmI804opU5jyptTLA+p9oJ+7n09tEkFYs1uhK/SI+GVQRinHWJQk4o8o4WRopg+UU6oqPK43eYx+bQts8vb3CFvjJJplytXdBDlyiHFiC3LJatrYQqIZ6vIibe5Ji6mMZzn2l39uvwdkuyOJWmFAHbKthKK2E5GlgREN5rUN9UAPCxNUaZZpB8YTE/h2tU/SBhFwBfW5k4HSulCl/m2vp5nzywa0aBPrD4goH4zXODY6bdMb/NNr2S7mbOdT9ns7ShEDgjUnfI/bteN2DjNhaGFN7hyWobKkmxAyV2VU76rjDThAK8S8JCRWnWTSEzeT8BrZAJlefpZz507zrvwgtqKjMhwN7tNSwxindmBWAbPx9ee3FnT9yTiAFSfMFID7vBX2UlrvPTeS6ES+dBRT6YTXR1+iBJkYH1i70gol0gJGjTipg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(82960400001)(54906003)(316002)(4326008)(508600001)(956004)(110136005)(31686004)(44832011)(6666004)(2616005)(31696002)(26005)(83380400001)(16576012)(53546011)(66946007)(2906002)(86362001)(186003)(5660300002)(66556008)(8936002)(8676002)(6486002)(66476007)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFlXbW5YTEhkQi8zandINjMrWGdLNWlucS9EYjI5YTVVTzRpbE1IVWN4b3hv?= =?utf-8?B?dVZ6ME1QdkpUeHhta20ybnlLb1BGSHZIWUNNSjFLUFZLR2t6S0QwN2hlbUpN?= =?utf-8?B?UEErQ2FFTDJqOVpHaEJIdDNiWGdQMXNtMjlkQ1ZPUS9KNnhML2h1VXdUL0t0?= =?utf-8?B?U3lldjhqS203blVLOWJTYW5JZy81NG5jRTQ4SS9mTU1DNEg3WHg5RkFzSVBX?= =?utf-8?B?YmEwWW44c2tOT3pMV0hzMkRkMlZXVzJEcEZweXArVHp2cEh0cm1qQ05TSkpj?= =?utf-8?B?UWFZSG8rK0JBalBTMThseWlhYjhPRElDam5qaXNjbW9uWXl6UUNPUjFzcEFI?= =?utf-8?B?K2JlQVgySGhCdldQaElQdGNqSndVUmNaWEw3WW84NVhSbkUxODBFQlJORjFH?= =?utf-8?B?UlBTTkRrYTVmRzg0ZkdzOFJ5TC9KZVFCZXIvL1dMTjhQdG5OWXJGN1BBcXlH?= =?utf-8?B?Q3NNTS9ETzNxSC9mdFlFc0p6YmgzQkJyRzFOa2RTcndBRWdqQW5ocU1taWNx?= =?utf-8?B?WXkwM2M1ZStxMk5GamhUNXBjaE0vRHJlTk85RW04M1d4WlNiYzR0ZlpnSm5B?= =?utf-8?B?ckpxbUhaaWZKdXhTdDhDM0FzSkV2RjJWZG85OTFvMzRLQ2xEVS9jS2s0ejFV?= =?utf-8?B?RjNSQnhWQzFLSDRYcUp0aGFDQ0I3dmtINjFOcHJ2WC81aDhUM0hqMTlWLzV6?= =?utf-8?B?QjlBSlZZL3F5RHliS20xTm1FMDVYbms0V3dvMnJzQlljNEJ0NUsrSkNRczNM?= =?utf-8?B?a042VHJlVjFoOGtXbHdmR0wxWldPdUtadTFaTHdmSlk0R2FwdzR4bHovby8z?= =?utf-8?B?WGVkNlFtd0FHRThxYTVnL053ZDd6Z2pKUjBjTkZqRmdHYmcrUFRPLzZvUmYx?= =?utf-8?B?TzZBL01RMkEzNWwrZGNoQmZSOXJVVlN1NHpGL1RlS01EcFZtL1A4Ym5PU2I0?= =?utf-8?B?aWlCdnRPcGVFbDl1T1FKL1lINldoS2k5NWJBL0dCdE82V21HeXRNaG5ja2NV?= =?utf-8?B?UmIwdnFPVUtJVmFYWVVSbEtQTmJPTGJLUUh1NnRDNFQrbzBPWkpTOWpuQ2hx?= =?utf-8?B?bFVpZFpTSlBoRWJZcFF5TDRCRVRZMSttaG4rb0dDaFNsRHlFajlWcFdUUDR4?= =?utf-8?B?QmdQMVJndG0vTlZDVlhucGdsSVdJcHNOSXJVZDhFY0dxS0ZnZm1YY3hjb0tE?= =?utf-8?B?dkE4ZUhNQWdRTzVqOG94UGdselhZejQ1SFYyc2ZnMnlBL0prVXhpVmR3b0tM?= =?utf-8?B?SE90am5VQ2hrOEVrcWFRLzhlTFd6bWxiZlZBbDBTS3d4QWUrdE1SVDl6RnB5?= =?utf-8?B?NHlqemp4VXJieSs5WXBmblh5VmUwTWJ2bW5wUko5MDhRNEdDRkFoT0w5eW80?= =?utf-8?B?UmVqL3AzY29IUTgwS005KzlsUFRJOEJYbWY5NWs2bUp5YUdad3hwZjY1Mjhn?= =?utf-8?B?QVgrWjRnaDRLaisrZFo1TVBSZHJueFNNWGZaZnFFZ0w2dkRGemdkb2tKbVY3?= =?utf-8?B?R0pCai9kQlMvY3luazdURzdISzF3MGdSNFgvZUNocm9HaTV5UHdCOUhBYk5X?= =?utf-8?B?UUJjb0VBcHB4VWRMUzQvM1Jtdk4yVWZ4UTdMSnBsYUtPby81SVd0TnM3ZnMw?= =?utf-8?B?UUVIeHB6SGM5TUJjQmZKQlh6cERaUE9aUFhyQnJuUkJMUjFTN0duRnlXOW1V?= =?utf-8?B?cW13WW50WVNFdnlPZlZNSWZFMHM2c0hpM2szdjdCM0diUTBNYXhXak03V1JW?= =?utf-8?B?RjBvdWhRVXFBd2lrVU1GTGU0WlNud3JrVVpKbXZPVzkrazI5QkU1N29zV0p5?= =?utf-8?B?ZjhZV1VCOUFJRS9FaXUyTjNMOXRZR2lPWTJuWVhNdHYwbzRVd2FubTZNWjRj?= =?utf-8?B?NzBFMzVkMGUvKyswOSt2Vm1EQzEzYkF2THljQ1pHMlJIM213VmwvU3QrZERN?= =?utf-8?B?S1UrUUpPY3MxMXhKakU4cm1GN25vajkxazhyTjdKVmQ1NHIwVjRyQTlGbitE?= =?utf-8?B?UE9ldE41Wm1sR3RSaGxBdGk4c24zM0xBZTRSVjVsN0x1bVUwK3NmMmlJaXVG?= =?utf-8?B?UTZlSnNyK1VIQ3owRzl2RWVkUnNFMUFuMjRhWWlxdFU4Q0R3RkZpUU5qS3Bv?= =?utf-8?B?S2NVeGxGZFBvczhwcTNqT29DaVJpcE0rSXRHenlMRU83V2tiTlhRNmVrUVNH?= =?utf-8?Q?Rk3/6At1gceIqPqHdGAi0Q8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e7b88257-c302-4e92-c525-08d9a0a3ea80 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 21:33:32.6725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B0Puu0v214q+uxVK8rKTK5S9SLLu9qAzObZEMsGTasi+O4eLGeZ11ZWdJAUQA3Gn4vPmbcPGWt0hCDcQg1MBqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/2021 4:26 PM, Stephen Hemminger wrote: > On Fri, 05 Nov 2021 16:05:14 +0100 > Thomas Monjalon wrote: > >>>>> >>>>> What do you think about marking old macros as deprecated? >>>>> >>>>> This will cause warning in application code that is using >>>>> old macros, but shouldn't fail their build (unless -Werror >>>>> is issued). >>>> >>>> It looks to be the right thing to do. >>>> I wonder whether we could wait 22.02 to apply it, >>>> so users of LTS are not annoyed by it. >>> >>> I have no strong opinion, but tend to agree with Thomas. >>> However, if an application jumps from LTS to LTS, these >>> defines will be available in 21.11 without any warnings >>> and simply disappear in 22.11. So, may be it is more >>> friendly to deprecate in 21.11. >> >> That's true for a lot of deprecations done in the year. >> Jumping from LTS to LTS is for production. >> Intermediate releases should help in the upgrade preparation process. > > Agree, the deprecation cycle is long enough and it is just a > trivial warning easy to fix, or for those that ignore warnings > they just won't care. > I think Thomas is suggesting to postpone the patch to v22.02, is it what you agree? If so, plan is: - Have v21.11 without this patch. So backward compatibility macros won't be deprecated in v21.11, and end users won't be affected from the rename at all. - v22.02 will have this patch that deprecates the old macros. End user will get build warnings after this point. - Remove deprecated macros on v22.11. If this time is agreed on, I will send a deprecation notice patch for it.