From: Jie Hai <haijie1@huawei.com>
To: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 0/3] bugfix about KEEP CRC offload
Date: Wed, 13 Nov 2024 11:14:33 +0800 [thread overview]
Message-ID: <7f207a0f-9ce5-c5d1-1731-24e1c2028e1d@huawei.com> (raw)
In-Reply-To: <20240719090415.1513301-1-haijie1@huawei.com>
Hi, stephen, ferruh, thomas,
This group of patches does not modify the API and
is a problem for hns3 driver.
Can the patches be applied in the current window?
Best regards,
Jie Hai
On 2024/7/19 17:04, Jie Hai wrote:
> For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is
> still be stripped in rare scenarios. Some users of hns3 are
> already using this feature. So driver has to recaculate packet CRC.
> In addition, in the mbuf, the data that exceeds the length specified
> by pkt_len is invalid. Therefore, if the packet contains CRC data,
> pkt_len should contain the CRC data length. However, almost of drivers
> supported KEEP CRC feature didn't add the CRC data length to pkt_len.
>
> This patch adds description for KEEP CRC offload.
>
> Dengdui Huang (3):
> ethdev: add description for KEEP CRC offload
> net/hns3: fix packet length do not contain CRC data length
> net/hns3: fix Rx packet without CRC data
>
> drivers/net/hns3/hns3_ethdev.c | 5 +
> drivers/net/hns3/hns3_ethdev.h | 23 +++++
> drivers/net/hns3/hns3_rxtx.c | 134 ++++++++++++++++----------
> drivers/net/hns3/hns3_rxtx.h | 3 +
> drivers/net/hns3/hns3_rxtx_vec.c | 3 +-
> drivers/net/hns3/hns3_rxtx_vec_neon.h | 19 ----
> drivers/net/hns3/hns3_rxtx_vec_sve.c | 3 +-
> lib/ethdev/rte_ethdev.h | 6 ++
> 8 files changed, 124 insertions(+), 72 deletions(-)
>
next prev parent reply other threads:[~2024-11-13 3:14 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 1:10 [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled Jie Hai
2024-02-07 14:15 ` Ferruh Yigit
2024-02-20 3:58 ` Jie Hai
2024-02-23 13:53 ` Ferruh Yigit
2024-02-26 3:16 ` Jie Hai
2024-02-26 16:43 ` Ferruh Yigit
2024-02-28 2:27 ` huangdengdui
2024-02-28 13:07 ` Ferruh Yigit
2024-02-29 3:58 ` huangdengdui
2024-02-29 9:25 ` Ferruh Yigit
2024-03-01 6:55 ` huangdengdui
2024-03-01 11:10 ` Ferruh Yigit
2024-03-08 11:36 ` Jie Hai
2024-03-22 6:28 ` Jie Hai
2024-06-03 1:38 ` Jie Hai
2024-06-03 2:33 ` Stephen Hemminger
2024-06-03 5:24 ` Morten Brørup
2024-06-03 7:07 ` Andrew Rybchenko
2024-07-18 11:48 ` [PATCH v2 0/3] bugfix about KEEP CRC offload Jie Hai
2024-07-18 11:48 ` [PATCH v2 1/3] ethdev: add description for " Jie Hai
2024-07-18 11:57 ` Morten Brørup
2024-07-18 11:48 ` [PATCH v2 2/3] net/hns3: fix packet length do not contain CRC data length Jie Hai
2024-07-18 11:48 ` [PATCH v2 3/3] net/hns3: fix Rx packet without CRC data Jie Hai
2024-11-26 23:17 ` [RFC] net/hns3: clarify handling of crc reinsert Stephen Hemminger
2024-07-18 12:35 ` [PATCH v2 0/3] bugfix about KEEP CRC offload lihuisong (C)
2024-11-26 23:12 ` Stephen Hemminger
2024-07-19 9:04 ` [PATCH v3 " Jie Hai
2024-07-19 9:04 ` [PATCH v3 1/3] ethdev: add description for " Jie Hai
2024-09-05 6:33 ` Andrew Rybchenko
2024-11-22 17:10 ` Stephen Hemminger
2024-11-26 7:47 ` Jie Hai
2024-11-26 23:51 ` Stephen Hemminger
2024-11-22 17:35 ` Stephen Hemminger
2024-07-19 9:04 ` [PATCH v3 2/3] net/hns3: fix packet length do not contain CRC data length Jie Hai
2024-07-19 9:04 ` [PATCH v3 3/3] net/hns3: fix Rx packet without CRC data Jie Hai
2024-11-24 19:42 ` Stephen Hemminger
2024-11-25 17:45 ` Stephen Hemminger
2024-11-26 2:40 ` huangdengdui
2024-11-26 3:16 ` Stephen Hemminger
2024-11-27 0:16 ` Stephen Hemminger
2024-11-27 2:32 ` Jie Hai
2024-11-27 3:21 ` Stephen Hemminger
2024-07-19 9:49 ` [PATCH v3 0/3] bugfix about KEEP CRC offload fengchengwen
2024-08-09 9:21 ` Jie Hai
2024-09-05 2:53 ` Jie Hai
2024-10-18 1:39 ` Jie Hai
2024-11-06 2:19 ` Jie Hai
2024-11-13 3:14 ` Jie Hai [this message]
2024-11-27 10:08 ` [PATCH v4] net/hns3: fix Rx packet without CRC data Jie Hai
2024-11-29 1:36 ` Jie Hai
2024-11-29 17:12 ` Stephen Hemminger
2024-11-30 2:26 ` huangdengdui
2024-12-02 19:35 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f207a0f-9ce5-c5d1-1731-24e1c2028e1d@huawei.com \
--to=haijie1@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).