From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28F5FA0352; Tue, 8 Feb 2022 18:39:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1451341140; Tue, 8 Feb 2022 18:39:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2BC344111B for ; Tue, 8 Feb 2022 18:39:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644341981; x=1675877981; h=message-id:date:to:references:from:cc:subject: in-reply-to:content-transfer-encoding:mime-version; bh=NLSn3ICNDKCxTD+VwrEvQXhjOhtGXx9cogqSWVW419A=; b=hLCJbOZ/SeXWRJOHazc1jHS6xcyfdcJBfg/HN0Gcn0aSAkPkxYTSaNEr uuOtvYtOoT+Yip2RSqG9ASDtAQFNIum4UDKmBzo3Z9eLwwc0r/hvP4zlp 9dAXVbMK8+ONHLju13PSvzLKxqtHXtKd3QXKjXuLBXH5uyanxHccVNRRt Tb7Nmfuma1snH1JComEoLcYNm/QsuZ2WbsI0VBPv53wiTIYOLD9eXhOhR t39LEN2tybl84HsFDZpjbm4/1BtochWmCnjuDqSGfyd9F++BKAEp6vQHw qVqbRqecGuvF6RlVS6cE01yTdNJrQwajt2URTk7VxG1kK2jan/CD96Dwo w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="248769109" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="248769109" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 09:39:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="700924992" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 08 Feb 2022 09:39:40 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 09:39:39 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 09:39:39 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 09:39:39 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 09:39:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrBs/sjL6gOLyrjtKiz7T2hkAWQTIWkvjX6LmqH9yXp+Y3+7Hu8GtKqBSi4fKIH6iu4Z6Z4HFxYibjKX1+nsuChsCm74JblI0Qk+0NSpu4m/duiOTMPQVC3Hy2FAirvY3KC1LMweQnj/RbX+w2+cvVU+SO9JqN83j/gkh/qCWGbQ4ZYGT1BMbAvRYz93L1XyLd51s5L/eoEwvzRDUjdcgv11+ydeHQkYsa40EyDVEmLr5LZaJO7a5BE+bC9V8aGGLYV/nxqYJD4Tkb7N6/H6GkfGUFOPm10Wthv0EXzjAPyBp6Pp39rQW33lbpFz51r8nvYYqiJb9oSk1ZpmZUR56w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZraK7F2DiYuCtsvxs5mti4NwsOM6xTQgP4hHSr4PZls=; b=MQxYoVfH5XhGbn7voqYDAgAXM7ZTUQgxCMRe32+/2XHHhSSFV5R9dG8xKJ20UuFw4XTp0MpmNVKz1NPcPsnSWU/h/ULFAwdz+B2qAKWN2i9RbSUSurNMeDWK8pGyZ9Np+im0lVQUmwbH7WErMesAruSxZGsbREHo7EbKOVfKxkrdiFPdtuLQwrDRfRONXvbZPjUQ5X7bXHgrE1pyzQiMQTRo+hQefnsFNMGd8bAIHncaPchHnpHHbzZhyeuJu1paqpP4GogLxSgFcJp0fMZ+e+jp6LtJzRGEpDQ+/YE3dv4BXWsZrfel12mV0YIfori25xI15I8Hb7x45zH09STfwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB2704.namprd11.prod.outlook.com (2603:10b6:805:53::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 17:39:38 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 17:39:37 +0000 Message-ID: <7f30844a-db92-cb12-8264-486876c9ed27@intel.com> Date: Tue, 8 Feb 2022 17:39:31 +0000 Content-Language: en-US To: Jiawen Wu , References: <20220208101129.69173-1-jiawenwu@trustnetic.com> <20220208101129.69173-6-jiawenwu@trustnetic.com> From: Ferruh Yigit CC: Luca Boccassi , Kevin Traynor Subject: Re: [PATCH 5/9] net/ngbe: optimize the PHY initialization process X-User: ferruhy In-Reply-To: <20220208101129.69173-6-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0503.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1be34fc8-a130-4a3d-ffc3-08d9eb29fa52 X-MS-TrafficTypeDiagnostic: SN6PR11MB2704:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 14aeNMIA+Vs58BhDenEihAVyGjCzFj1qh3AYkxQhXkr2vlwraEgVL3F4lcx4PMP9+U368uE2bq2fEOvmY03wnft+JnrGvzneDqRxYleoH39jnMkad3rpZTbU3ybjEBYazrKKoTdyU13qLqV859dibYi8j00sSF1lWJ83FW9Ip6BR6Xo4gd+xrqP7o5CdPhjb7laFGJm4DDwRgibC9LFSZQtX1/K1CEcVA/X3164/W+otQcLieqY5Cm4DRdTDAVPzH/uFmDSpHxqkMS2orfgUvn7vrnRrf6AWTl47PTI8Lx8uvP/tHlOYNYL/vKrHrYsDuGQhg81TI8Xc4pXrZIkNbTOBW0HZZquMxQU8t7bhYINeMDpGTAZnWOIUIDAnx8iVBcVpzxLKT/LrzOgKlOaFcmafubC35aHlDq09eE9BA2HcNBuFT7FRC2it3jXk8+e3PN0KnLPxHT7BnnnnahWxhVZhJzE8+8czur86235565tVHpa9Kvvm0BxXDoCnjh1ScAbzOZuKCa31xdLnEj1gsL/M6GvaCEtwmOMBSrieXVMML98zi5PJcAEEaN6rjKdnPf2gqaXBUv9ApK5eKoQuMxLBzf55CKphu86ekxTjU806jI9AR4GeLTnNdkas/ZZMC76nR+5BMDyuYhU1ptDb4oUmTukvJamJDfDgPTnFbWF8AJ8aI/pmuGrP8QBcShrD0bpDcyvpX4RvbJcmPh7hWQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(38100700002)(6486002)(66946007)(2906002)(4744005)(44832011)(31686004)(82960400001)(2616005)(26005)(86362001)(186003)(31696002)(36756003)(8676002)(8936002)(5660300002)(66476007)(66556008)(508600001)(54906003)(4326008)(316002)(6506007)(6512007)(6666004)(53546011)(55236004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW5KNmhOTmZXUkd6MG9PL3FnU2RrZ1Z3Z1VIYnBRSXRTdVZBMHkra1RKMVJv?= =?utf-8?B?OTl1ZSt6L29MR1pIbzNJaW5BUnZzTHgvZy90TncwOGFNcTM5WnVtU04zNWoz?= =?utf-8?B?bSt6Y09aWWh2eWJwZGdPamJYMDhTQ1BKcTBIaXVPTDBGQ2R1Y0NQNVFrRVZK?= =?utf-8?B?c3pNWDZmNk5mZjNwc1NDSXJydHg1SmdXNlZKZ2VsY0FYYkx0S3dKK0FDYnd0?= =?utf-8?B?b0VuUGY3RjREYWNXSFlNUE9BVzB0bkp0NUJGRjN6ODhmWjFuUmkwbksxUXNI?= =?utf-8?B?SGw3QTFZdzBJdEh3eVNhWXdhUkgySDYxY2luQW8vWUZyU1pQeW9WZmxvRWZa?= =?utf-8?B?OVJzY1NFS3dOZlQvcUlZb1VtMzBSbHY1WHR5TDl0WmlhV1llUUtYOFdaYXlr?= =?utf-8?B?WHdjbGdhMXNUcVZ5K1lHTi9FYjQ5dW1WMXQ4MXFWVUZ1NW1VaTYwMnpEN2Y1?= =?utf-8?B?Uk1iVXUxUWs4Q2hqUzlYVzk1NDBGbFlPOUJqdGJwV0VuMDJ1SklpM0FkKytl?= =?utf-8?B?NlhHZVhwZGprNHZtRWhHTGRKNUVKWm5PTzRQM3ZDNjE5TG44enFkdWJCcDB4?= =?utf-8?B?SnozYTlaVU4wVW00QVhWL21tVis2YVphOEw1MThrUC9Qb0dteFZVRnZxVTlV?= =?utf-8?B?bE90T0o4bjZMWkorK3BZenBUYUc4QnNoVSt6MWovTHR3WHpObmt6QjJrM0xJ?= =?utf-8?B?WjJiYUphMEcvMnlUc2QwSG8wUWJSV3pNU2dSNnRmTlk2RWkrb3BleUVLcnhW?= =?utf-8?B?SE5aNHMyVEZpUGtFMFFrMkdQMWc0L1Q2UjVQWUhoN3VuSGU3ajRGQW9RSm1r?= =?utf-8?B?N05RcnJjS2xyaTdoNXZSSGZ4TU9CNWxIK3EvRW9LdTJDRHlBbUwrNHNCMjQ1?= =?utf-8?B?UXZyS1NvWEFvWDR2QzBGR0VNc2RpRzVRTEpyRE1SYWpMMXEzcUNhNWZBTGNM?= =?utf-8?B?czhHYmFZdlJrdGovYWp6cEdGL2hFUTYzTDVXa3FRUmk4VVNQQy9VMFNnSlgr?= =?utf-8?B?KytCMU1UTThVNVY1a3k4WXFyUHVVZ3VsRythdXQ5YzQyZ0lCS0tPVjVSMVBt?= =?utf-8?B?dFFjYURYcXNVR1NWTG01ZnNTTCtaVDlINkxXTkpBeGlVUkFnRmg1Wi9NRG1N?= =?utf-8?B?WHd2UjdIYnJHUHBJNHNOQ2svbWpkT1BBT2xYNEp5WjI0Y2JkYi9hOUdhUzZu?= =?utf-8?B?Vk1IWUx4M1FYV2UvdytNUldyTEhSWGFmUzFYT09kRmYrVURGWmpWeGREWXVN?= =?utf-8?B?UWJROHBWSlhFUG1LOUg3UGRkMjNpR1Axdkxoa080YUR4SGNvcXdSLzNGUitY?= =?utf-8?B?eTRLWUhrT3pjV2lGVDlVMHlCTWg3UEhZbmtlWjJ5V0VHa2RZMGZHV0ZtVk5O?= =?utf-8?B?di9YRVhHcVRkZndQTExMdWU4QlFIay9EejI5QTdNS0IrWWhod3FPUFZJU2xv?= =?utf-8?B?U2xlREFWLzc3Zk1VK3BUVnU2NEE2L1Rzc05uSjg0OFJPMyt1a0ZrdGRqOXhl?= =?utf-8?B?QmZueXE2TFNxSkVVWTljU1R3SW5KYXFDRDJiQzBIQ3l5US9aQnhDekgwa05L?= =?utf-8?B?bGFYOS94Y2JGQ0hNSzJVODhqSnBqVUVnc0tZaGJwblFMaWtFT0wrc2d5UFRt?= =?utf-8?B?N0lzQWpHVklyclMxZ0V2eWJ5OVpTT2dnckhGYnIvQ1h1cUVSOFAwUFZmM2pC?= =?utf-8?B?WmUwMXlEdEZycU44S1BRTjZTRVhJcW5jcit2d3NhQVJOVnhuNWN1VXpWdzRU?= =?utf-8?B?QkIyWHBmdDF0RUJJUWJ3WHh5aUNQYnM4cmZHS2R6VW1wTXczR1JOTFNzYjNp?= =?utf-8?B?RjVNYS8vQnNjNWdEVVZOWkZXQ1R5RWdGNVQ5N1lNMUxiOUJEZ2RQMUI5VkJw?= =?utf-8?B?SXZsVlRzenFYQWxia0lxYU53c1JoRkJDUFJoaDNnRDkxOGRoZlZqTWx2NUk0?= =?utf-8?B?Nmlsd2tZZHF6dFFWeDVUclNUM29ZY2lhL2praWdRVFZhdFpwMjVPUVJvNk5h?= =?utf-8?B?a3VjTzRuWjJvWldSckpERmNCYmRjaVJIL0t3Q0I1c2hPMkcvT1FPcTN0dXBX?= =?utf-8?B?dnl6UEdTL0xTU3JHU0ZZeFoyajVPNG9iaXJTZHJoUDBZZ0tqUWRXbHJML1ZS?= =?utf-8?B?Y2p0TW9yakVXWlVPZ0RMQUJ2VEh1K1Zuam1zUzVPamRkK0FGdE10bUVFc0V5?= =?utf-8?Q?8ap/iGi3cFb18HqFqugR7VI=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1be34fc8-a130-4a3d-ffc3-08d9eb29fa52 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 17:39:37.8690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ClNZrZUzTio+nzn00yJNzTFr0RC/yyP98k59tXx8qn381VTI0OIttLPoyP3tPeImKkYCZECN+NgCOviI17NxNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2704 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:11 AM, Jiawen Wu wrote: > Reduce the probability of PHY init failure, And add its error return. > Patch is missing stable tag, is it intentional? Or do you want patch not to be backported? > Signed-off-by: Jiawen Wu <...> > @@ -234,17 +242,7 @@ s32 ngbe_reset_phy_rtl(struct ngbe_hw *hw) > value |= RTL_BMCR_RESET; > status = hw->phy.write_reg(hw, RTL_BMCR, RTL_DEV_ZERO, value); > > - for (i = 0; i < RTL_PHY_RST_WAIT_PERIOD; i++) { > - status = hw->phy.read_reg(hw, RTL_BMCR, RTL_DEV_ZERO, &value); > - if (!(value & RTL_BMCR_RESET)) > - break; > - msleep(1); > - } > - > - if (i == RTL_PHY_RST_WAIT_PERIOD) { > - DEBUGOUT("PHY reset polling failed to complete.\n"); > - return NGBE_ERR_RESET_FAILED; > - } > + msec_delay(5); > There are hardcoded delays added in this patch and other ones in this set, I just want to remind that this can lead unexpected (and very hard to debug) errors.