From: "John Daley (johndale)" <johndale@cisco.com>
To: "Kerlin, MarcinX" <marcinx.kerlin@intel.com>,
"Nelson Escobar (neescoba)" <neescoba@cisco.com>
Cc: "'dev@dpdk.org'" <dev@dpdk.org>
Subject: Re: [dpdk-dev] unchecked return value in enic driver
Date: Mon, 20 Jun 2016 18:44:33 +0000 [thread overview]
Message-ID: <7f50de6575a0483682fcd83b5691eb82@XCH-RCD-007.cisco.com> (raw)
In-Reply-To: <68D830D942438745AD09BAFA99E33E8125F85F@IRSMSX102.ger.corp.intel.com>
> -----Original Message-----
> From: Kerlin, MarcinX [mailto:marcinx.kerlin@intel.com]
> Sent: Monday, June 20, 2016 4:12 AM
> To: John Daley (johndale) <johndale@cisco.com>; Nelson Escobar
> (neescoba) <neescoba@cisco.com>
> Cc: 'dev@dpdk.org' <dev@dpdk.org>
> Subject: RE: unchecked return value in enic driver
>
> Hi John and Nelson,
>
> > -----Original Message-----
> > From: Kerlin, MarcinX
> > Sent: Monday, June 13, 2016 1:18 PM
> > To: johndale@cisco.com; neescoba@cisco.com
> > Cc: dev@dpdk.org
> > Subject: unchecked return value in enic driver
> >
> > Hi John and Nelson,
> >
> > I have a question regarding Coverity defects:
> >
> > File: /drivers/net/enic/enic_ethdev.c
> > Line: 379
> >
> > CID 13197: Unchecked return value
> > (CHECKED_RETURN)1. check_return: Calling rte_atomic64_cmpset without
> > checking return value (as is done elsewhere 15 out of 17 times)
> >
> > Can I mark this error as "False Positive" in Coverity Classification ? reason:
> > 1. Function returns a void type so change the return type to int
> > requires changes all drivers 2. rte_atomic64_cmpset is at the end of
> > function so nonsense added a return
> >
> > What is your opinion?
I agree with marking it false positive for the reason you mention.
Thanks!
John
>
> I marked this Coverity as false-positive with an explanation. If in your opinion
> it is not ok, you can reopen/change/fix it.
>
> >
> > Regards,
> > Marcin
prev parent reply other threads:[~2016-06-20 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 11:17 Kerlin, MarcinX
2016-06-20 11:11 ` Kerlin, MarcinX
2016-06-20 18:44 ` John Daley (johndale) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f50de6575a0483682fcd83b5691eb82@XCH-RCD-007.cisco.com \
--to=johndale@cisco.com \
--cc=dev@dpdk.org \
--cc=marcinx.kerlin@intel.com \
--cc=neescoba@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).