From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0084.outbound.protection.outlook.com [104.47.42.84]) by dpdk.org (Postfix) with ESMTP id B81C21B6DD for ; Fri, 13 Oct 2017 16:22:56 +0200 (CEST) Received: from CY1PR03CA0038.namprd03.prod.outlook.com (10.174.128.48) by CY1PR03MB2363.namprd03.prod.outlook.com (10.166.207.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 14:22:55 +0000 Received: from BY2FFO11OLC001.protection.gbl (2a01:111:f400:7c0c::116) by CY1PR03CA0038.outlook.office365.com (2603:10b6:600::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Fri, 13 Oct 2017 14:22:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC001.mail.protection.outlook.com (10.1.15.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 14:22:54 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9DEMpOw009248; Fri, 13 Oct 2017 07:22:52 -0700 To: , CC: , References: <20171012130726.4332-1-alok.makhariya@nxp.com> <20171012130726.4332-3-alok.makhariya@nxp.com> From: Akhil Goyal Message-ID: <7f6e7410-6acc-3504-be71-166616e7355b@nxp.com> Date: Fri, 13 Oct 2017 19:52:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171012130726.4332-3-alok.makhariya@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523781749265551; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(39380400002)(376002)(346002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(377454003)(199003)(24454002)(2906002)(64126003)(23676002)(5660300001)(8676002)(498600001)(36756003)(105606002)(83506001)(65826007)(31686004)(33646002)(85426001)(106466001)(81156014)(81166006)(8936002)(68736007)(58126008)(54906003)(110136005)(316002)(53936002)(47776003)(77096006)(6246003)(69596002)(97736004)(104016004)(65956001)(65806001)(54356999)(76176999)(8656003)(230700001)(356003)(31696002)(50986999)(305945005)(86362001)(50466002)(53546010)(229853002)(2950100002)(4326008)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2363; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC001; 1:eyfpPQLAueJ6JKaYBDJYKUOmD/EjeT8dIhQuLV86wYiOCpRDQA1cG2orze/2SDxpX8rbRqLZOgArIv+gtypTmPlt1W6Qlrqo1dZsNc+cR965f8d/SZ4cuxJ/m9NvkqZh X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bbd38c98-a244-434b-f330-08d51245e522 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2363; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 3:6DTvPbftMWb3JanGgGLtO4xJdntWz63/C/tuNe2ELPrWYCqOrzPSd66oWiyqrQ6DKg7XVAbsGaHlJauMdJSWQObO5V8rL3jsTvjOXk4OQQ14/gdNuFToK4+8QrDTZZ4ZRKSFIRVZ5nZc9MCZb9iBMa8EIHvF9T3+Qwn6Wmf3xBKgBTgZqpxN/yhCy4Ym6fkA2DM9im+rfGaEIgCHW06/jgpZLt4XpE8w0XaGVeGbDnYn6TQ4F8Ib4+LxCFEhFHfZa2/RXUM6DjwPr6rPJkntWYyrwepfsRPDi3URzIi4m2hIJZhJqRxoQypoR2ZsjwEbdAAxHqgzAXV0nC6xFXOF4g==; 25:JG+yaDa8O3hIbg0XFAduqzDHeCasRKxJJK2asd+4WyCj0JXXkPSXFO7hdkA0UuiC+WmPsum994wViQroKYvsgfpXC65KE+WNJwdC+puulWbYibqicM+sqxzzffMNIyV3Fg1PeC4WlasW59iWtJ7XIds8nG47SPCcKRm3gvtby9cx7oYbpnZg+EEz1gYNHmxrlvgAZrn20iBS2jKUo1llNM4HVeyYp58orwcYS/E3TvGoYTe7bhKqwSJWczcQ7mk+D8+0pgvg+WSNgEt4LPpO+CfP3FCzmayNq/XHR9r6xHvqDiHTtbWuf/E5GOqkaunNt6webW6mUh36ib813dMPpA==; 31:egdCbQ9FJ+kmXNivelPijXJQ05+Z41UhsaMpDqfs/DTdE8hIm4qra9iJGklpBsDpesh5LJHawpecPdBr+G2LhHF/Q/8iu1avIqAYdHz7ZRuWZvNzdSRYOQ5ivyOFycNkLHUPoObp1QB3fATn/QfLb4QEgpq2AlMOQbeIEpQPMj0BnHmYXj9KSxrff0fipk9tsQiRZ2R+CHQY1K3GZvQaPSld/SSIdQyC4h3RYHd6j6o= X-MS-TrafficTypeDiagnostic: CY1PR03MB2363: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123556025)(20161123561025)(20161123559100)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2363; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2363; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 4:1/ozD/YKCZG+rVDAlN+jk98flsNoiu6hswk7b4vNBcFiX/CERoXfqooT9d/slGKMYIv13ahaVeGwRfkhtrf+Nm/i/WZ4N24rliF4XCf/uPkeWmIP1wMa6uWv4ihFkEvpsczSRFrHhfNEk7pfY/bV2reryExxV7vDGouIJM2eQal49i4nbZi4QCattq4eUeScjUmyA3fs4OKJfTC92RYY7c/xZXd3i9UtsHXtznPkeViVTDpxAIwUHkSlDQ6k3tt2mE+XhW6QVe0xDNl0AOyPSNhmZfk/QglTeCggcD1egB0= X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYzOzIzOkxmbDA1K2VrWkNra2xBUmtYeUJNaGZUM2xu?= =?utf-8?B?V2lid1JQZTA4emswK3RDYkhEZDdyWkQyNitoY2J3RHBGNWFXVFdaMlgyODNG?= =?utf-8?B?RU96c2EzUXpINzBjUFYzOUdBNkxWNXVDbHE3b3Rxc2oweXFQYnVQQXFiMnFB?= =?utf-8?B?bURJbHZicC9hbDVQNWNvREJtL1A1dzdTR0wzWDdUNU9CQXhwUTFQTG1MT1RI?= =?utf-8?B?Q01QU0lReERYTHJiNUNEVkdVOHQzWWM3YXlubnk0SmxMbHpaOTFqMHoyVzk2?= =?utf-8?B?NHEybE5TaXdPU3FHcHB0RFkzWENZVVlpazFFRVdvd3EvWmlUbm51TC9aQS96?= =?utf-8?B?RUpOUFltN1RYaURwdjRibkpYRExVakt2U0RaMmt1QnhkeSt3U09ZMkt5WThP?= =?utf-8?B?R0k1cHV3L0FEVjgxaFh6eEN3OWJTd3EreGt3NW92TldOeGxUUUp4NEtkRG11?= =?utf-8?B?TTVmbURyZXluMG5TbDlIbERacnBXV04yQ1prQXo1NjlLemFBQUJpcE5SdjdL?= =?utf-8?B?alVKU2dZL3ZGaTdkaTd0NzVYQ21pSlNpM051Vll5ZngvTXp6c3Z6R3M4dlBB?= =?utf-8?B?WGVhZk1kaVprN1hTcFA1RWdFcXRxZlFmYnd3Mkp6QzhjeVh1dkI0NGRxS1pO?= =?utf-8?B?aWZZVjN6VnNiUXErNXliaFhkelBnMW1LZW1NcURCREhNMVZvMmNjMnpQejdt?= =?utf-8?B?bExyVStGUkhCRStYK1o0S044WlZpSHdKRy9QMU01ZE9mdzhaMld1ekxDLzUx?= =?utf-8?B?NDg4bjgzcHpUakoveEdmOExMQjRVOTJoNUJzcGFOWmxKOEtmeWdaWGcxc0w5?= =?utf-8?B?SDM2L3dTMk8reGR1WUZhNVU5U0xMWjJ0RFZWeGdiTllNQ2NDbXErOG1vTDJT?= =?utf-8?B?d0dKUEE5UG9YZEpoYS8ydFpjK0RjODFpckd4TnFWcWNoTFNmaHk5amNmS2NT?= =?utf-8?B?RU1wTnRHcGdKc3lyQ0lXQkRRV3pDZmZ1OW5Fd0g0a1NlRFA1NDFZMTg4aHQy?= =?utf-8?B?bVZ3bXJycm9vdnJka0F6bTgzVTQzZzlrV0txaGJRdGhBUktsYytWdmo5OEdM?= =?utf-8?B?R0F5T0xiQzZpZGFSb3FnYWxvVTRKbnZla1ZFYndIRHdPcXVqWWFRcHAwY0tO?= =?utf-8?B?VldUK0s2QUtyL1pTKzdTR205b3NZSVg5YVZ0eWd0U1lRMGJjUWMyaUlhQ3Iv?= =?utf-8?B?dGJTWWE1SjViRzVVS1hDVVpid3FGaWpTQnM4MkhQcUt0L0dMVU5GR0VRY1RO?= =?utf-8?B?aVVkdWpZV3lvM2RSMjZqcmlMY2JuTzhpeHVrWllIV2VyRFZIL3NWbUprZzQz?= =?utf-8?B?U3VXbTFIMWFUamxMRU44cStiNGpOd2xBelRPUS9NRTI3VUNHeWM4amU3UERS?= =?utf-8?B?a1BydUFZZ010UjZKdEgwOHlsSGVkdkdOYXpiQ1EvYXZvWWcwWGh4NldGSVdH?= =?utf-8?B?UHYvNUJYYzFSK3ZoYm90UkdjZkZyOVRqTTlRbjdlREZGTUdQeldaN1MwNG44?= =?utf-8?B?RHpaWGJNeEdKU1hRZDdETXZ1UFhhamNtcTgxamk2cm12V21hVXlQTWQwUm9L?= =?utf-8?B?bkZaNHQyTWJLMXlnMEJvTHN6ekx3M1JYU01BbEM3OEFuRTBkWlY5TnZZblM4?= =?utf-8?B?SncwSXdScTI0L2M2YmdBS1RPODNjQUVZZll1WUpiTGhDOTdJODVPSjNxQ0dK?= =?utf-8?B?Y3I4SVA4K1M0NCs5SGI0M3VkVnFybExnc1ZGeFg4ZmxSU0xCU21sVWtpV2lQ?= =?utf-8?B?bkc0T0M1RmhsSzAvR3UrQVpFRFlINmRsR3I3VDFnZlIwcjEzVGVIVmlkTW9H?= =?utf-8?B?Y3NWTENjaG1WYlZLMHVaQWdrYStJSUkxdE9nRUtuU2s5T3FuWEhVaHl3YTd0?= =?utf-8?B?MUNheHZoelFrVU1jQkVyTzlkdE1WZFZJNTVXZjJXQTZldHpCd2JWMXJ4Y0Ru?= =?utf-8?B?KzFQMkg2U1dnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 6:hyVOeenXiB3HgbmkgVxQnd+DSr0s87yDThCApsViQHKbVZS3UflodCRyzRUvnoQGVyOzu1FbWlWpeV9IDJO9aQQbH+YoSYSAVRCODpnrCDmPMZTtpQH/UnFA7qMHhcXjzc7ivuYcDIeIZHE4m6D2q3Adkigf1rffE3lJ7C60kVe4396Sd1wEII/BZ2pzEtWrlaxEPCOG2GD6kM9jiWSVuhtAFdPUnhPG18SgYa7OUeSxrx6uTQA7S8lkl9M0ktV3/wkb1/yC66uOpfsu4OT4NRdpo5W0DU1TqAKY952OXt+pVWl71YeRAQRBTjW5o3a8tw4WZfpdCiV3GAI1tPqtRw==; 5:K2Mur2oBR8CMBePn9oscbNFmZV37Oqoc0sADygYkKZ6btPbm7rG57tKTYRwOr4mcMwvUUXpZZHimeEiLBHK4qMvwKv49MZUkJDFGn/S3P3hPCFEdBsRfheivcwLz8+mnCM31labaNE7rccCrCK2X7bJfngj3UBye8krm4BtTtks=; 24:+2ypR0yzWoplzt7nxK27pluX/tcZXt8xUPVEpVaqtZaB5K9j94wcwTGPOBf0uESkljvTyWWNZi0Qun7Eu8rZonXR4XaHcE9Hnu2Wi2yoZnY=; 7:2vk77YKcSc4GARcXMSzZZCl2khdoBuf4zyVx8Pyy4Z0WO6SMEhcmmYLxem2EX14TfRORegL79N5cct4JtJFMNVlN15FUesrtf/u4MUwh/05Hw8WIpt90RFdxQO6NVWfHqHAT61XyL4rNuEXHPClHpWAEVsQk18AXbeuIkHx6w5xAxCBDPIKIeayUyNVb8Lgc75NJ7Vuik/JMjdGEo1Hc97G9aXxQqn+03KM6kGAI6wg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 14:22:54.8017 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2363 Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: remove memset of icv on decryption side X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 14:22:57 -0000 On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya > > Since the packet lengths are modified. It is not required to > explicitly reset the icv. > Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") > > Signed-off-by: Alok Makhariya > --- > drivers/crypto/dpaa_sec/dpaa_sec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c > index 8a57b96..b618b59 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -598,7 +598,6 @@ build_auth_only(struct rte_crypto_op *op, dpaa_sec_session *ses) > /* hash result or digest, save digest first */ > rte_memcpy(old_digest, sym->auth.digest.data, > ses->digest_length); > - memset(sym->auth.digest.data, 0, ses->digest_length); > qm_sg_entry_set64(sg, start_addr + sym->auth.data.offset); > sg->length = sym->auth.data.length; > cpu_to_hw_sg(sg); > @@ -738,7 +737,6 @@ build_cipher_auth_gcm(struct rte_crypto_op *op, dpaa_sec_session *ses) > > memcpy(ctx->digest, sym->aead.digest.data, > ses->digest_length); > - memset(sym->aead.digest.data, 0, ses->digest_length); > sg++; > > qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest)); > @@ -832,7 +830,6 @@ build_cipher_auth(struct rte_crypto_op *op, dpaa_sec_session *ses) > > memcpy(ctx->digest, sym->auth.digest.data, > ses->digest_length); > - memset(sym->auth.digest.data, 0, ses->digest_length); > sg++; > > qm_sg_entry_set64(sg, dpaa_mem_vtop(ctx->digest)); > Acked-by Akhil Goyal