DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kinsella, Ray" <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Kevin Traynor <ktraynor@redhat.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export
Date: Fri, 16 Oct 2020 12:16:07 +0100	[thread overview]
Message-ID: <7f7c1ac8-947f-40d1-bf21-4e13c196ec72@ashroe.eu> (raw)
In-Reply-To: <20201016102711.11926-1-david.marchand@redhat.com>


The windows exports and the map files, feels like duplication of effort. 
Could we massage one into the other during the build?

On 16/10/2020 11:27, David Marchand wrote:
> The incriminated commit forgot to clean the Windows export file.
> 
> Fixes: 3cd73a1a1c4d ("eal: simplify exit functions")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/librte_eal/rte_eal_exports.def | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 16f8e33874..975acb8ffe 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -32,7 +32,6 @@ EXPORTS
>  	rte_devargs_remove
>  	rte_devargs_type_count
>  	rte_dump_physmem_layout
> -	rte_dump_registers
>  	rte_dump_stack
>  	rte_dump_tailq
>  	rte_eal_alarm_cancel
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>

  parent reply	other threads:[~2020-10-16 11:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  9:38 [dpdk-dev] [PATCH " David Marchand
2020-10-16  9:38 ` [dpdk-dev] [PATCH 2/2] devtools: check Windows export files David Marchand
2020-10-16 10:04   ` David Marchand
2020-10-16 10:17 ` [dpdk-dev] [PATCH 1/2] eal/windows: fix symbol export Thomas Monjalon
2020-10-16 10:27 ` [dpdk-dev] [PATCH v2 " David Marchand
2020-10-16 10:27   ` [dpdk-dev] [PATCH v2 2/2] devtools: check Windows export files David Marchand
2020-10-16 11:56     ` Thomas Monjalon
2020-10-16 12:00       ` David Marchand
2020-10-16 11:16   ` Kinsella, Ray [this message]
2020-10-16 11:22     ` [dpdk-dev] [PATCH v2 1/2] eal/windows: fix symbol export David Marchand
2020-10-16 11:23       ` Kinsella, Ray
2020-10-16 15:48       ` Kinsella, Ray
2020-10-16 15:52         ` Bruce Richardson
2020-10-16 16:02         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f7c1ac8-947f-40d1-bf21-4e13c196ec72@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).