From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE09E4388F; Thu, 11 Jan 2024 09:26:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFE164028C; Thu, 11 Jan 2024 09:26:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 346634025E for ; Thu, 11 Jan 2024 09:26:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704961615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wZQLN+5qqXVVOCKWyxfzaafgmdYAMs+OKhAwnab9T1s=; b=U3lc/pv+ATp1jFj0y4toylXqZH+xftzPZRCJZL1OWOjhUJ3F7B8WCE5dTpokVWdSNVyAo+ vuV+scbLVsW+4ukw8uQiSwucxPCuz+A91AG9ECNssJIhX+aV8iFcqNV3KHdrl5zBbyErCg GfcVHNS1mw0XCPX/ISmCO0BP67EIymo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-lSODCHEfPJ--JAu_5hxvTA-1; Thu, 11 Jan 2024 03:26:52 -0500 X-MC-Unique: lSODCHEfPJ--JAu_5hxvTA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A6FA03C000BC; Thu, 11 Jan 2024 08:26:51 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78EC9492BC7; Thu, 11 Jan 2024 08:26:47 +0000 (UTC) Message-ID: <7fa4d849-2a7a-4611-a706-37d489d06676@redhat.com> Date: Thu, 11 Jan 2024 09:26:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 22.11.4 patches review and test To: "Xueming(Steven) Li" , "Xu, HailinX" Cc: "dev@dpdk.org" , Abhishek Marathe , Ali Alnubani , "benjamin.walker@intel.com" , "stable@dpdk.org" , David Christensen , Hemant Agrawal , "Stokes, Ian" , Jerin Jacob , "Mcnamara, John" , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , "qian.q.xu@intel.com" , Raslan Darawsheh , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Yanghang Liu , "yuan.peng@intel.com" , "zhaoyan.chen@intel.com" References: <20231220071903.25230-1-xuemingl@nvidia.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 1/11/24 07:32, Xueming(Steven) Li wrote: > Hi Hainlin, > > Thanks very much for test test and report! > Let me know once any progress with the known issue. > > Thanks, > Xueming. > >> -----Original Message----- >> From: Xu, HailinX >> Sent: 1/11/2024 9:42 >> To: Xueming(Steven) Li ; stable@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; Ali >> Alnubani ; benjamin.walker@intel.com; David Christensen >> ; Hemant Agrawal ; >> Stokes, Ian ; Jerin Jacob ; >> Mcnamara, John ; Ju-Hyoung Lee >> ; Kevin Traynor ; Luca Boccassi >> ; Pei Zhang ; qian.q.xu@intel.com; >> Raslan Darawsheh ; NBU-Contact-Thomas Monjalon >> (EXTERNAL) ; Yanghang Liu ; >> yuan.peng@intel.com; zhaoyan.chen@intel.com >> Subject: RE: 22.11.4 patches review and test >> >>> -----Original Message----- >>> From: Xueming Li >>> Sent: Wednesday, December 20, 2023 3:19 PM >>> To: stable@dpdk.org >>> Cc: xuemingl@nvidia.com; dev@dpdk.org; Abhishek Marathe >>> ; Ali Alnubani ; >>> benjamin.walker@intel.com; David Christensen ; >>> Hemant Agrawal ; Stokes, Ian >>> ; Jerin Jacob ; Mcnamara, >>> John ; Ju-Hyoung Lee ; >>> Kevin Traynor ; Luca Boccassi ; >>> Pei Zhang ; qian.q.xu@intel.com; Raslan Darawsheh >>> ; Thomas Monjalon ; Yanghang >>> Liu ; yuan.peng@intel.com; zhaoyan.chen@intel.com >>> Subject: 22.11.4 patches review and test >>> >>> Hi all, >>> >>> Here is a list of patches targeted for stable release 22.11.4. >>> >>> The planned date for the final release is 5th January. >>> >>> Please help with testing and validation of your use cases and report >>> any issues/results with reply-all to this mail. For the final release >>> the fixes and reported validations will be added to the release notes. >>> >>> A release candidate tarball can be found at: >>> >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.4-rc3 >>> >>> These patches are located at branch 22.11 of dpdk-stable repo: >>> https://dpdk.org/browse/dpdk-stable/ >>> >>> Thanks. >>> >>> Xueming Li >> >> Update the test status for Intel part. dpdk22.11.4-rc3 all validation test done. >> Found 1 virtio bug. >> >> new issue: >> https://bugs.dpdk.org/show_bug.cgi?id=1338: virtio-user can't receive packet: >> this test only on SPR -Intel(R) Xeon(R) Platinum 8490H --Intel development is >> investigating > > Maxime, seems the issue related to patch "vhost: fix checking virtqueue access in stats API", > Could you please take a look? I will reply in the Bz, but there seems to be 2 backporting issues: 1. We miss the unlock on return 0: diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 4edb76d0dd..6e1bba4391 100644 --- a/lib/vhost/vhost.c +++ b/lib/vhost/vhost.c @@ -2070,6 +2070,12 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id, if (vq == NULL) return -1; + if (!rte_spinlock_trylock(&vq->access_lock)) + return -1; + + if (unlikely(!vq->access_ok)) + goto out_unlock; + if (vq_is_packed(dev)) { struct vring_packed_desc *desc; desc = vq->desc_packed; @@ -2090,6 +2096,11 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id, } return 0; <== We miss an unlock here + +out_unlock: + rte_spinlock_unlock(&vq->access_lock); + + return -1; } The original patch does it like this: } - return 0; +out_unlock: + rte_rwlock_read_unlock(&vq->access_lock); + + return ret; } 2. Some unrelated change is introduced: @@ -2157,6 +2168,7 @@ int rte_vhost_vring_stats_reset(int vid, uint16_t queue_id) { struct virtio_net *dev = get_device(vid); struct vhost_virtqueue *vq; + int ret = 0; if (dev == NULL) return -1; Above change fixes a build issue introduce in an earlier patch. How do you want to proceed? Do you want a patch on top of 22.11.4? Regards, Maxime >> >> # Basic Intel(R) NIC testing >> * Build & CFLAG compile: cover the build test combination with latest GCC/Clang >> version and the popular OS revision such as >> Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.2, SUSE15, >> CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc. >> - All test done. No new dpdk issue is found. >> * PF(i40e, ixgbe): test scenarios including >> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. >> - All test done. No new dpdk issue is found. >> * VF(i40e, ixgbe): test scenarios including VF- >> RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. >> >> - All test done. No new dpdk issue is found. >> * PF/VF(ice): test scenarios including Switch features/Package Management/Flow >> Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc. >> - All test done. No new dpdk issue is found. >> * Intel NIC single core/NIC performance: test scenarios including PF/VF single >> core performance test, etc. >> - All test done. No new dpdk issue is found. >> * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - >> QAT&SW/FIB library, etc. >> - All test done. No new dpdk issue is found. >> >> # Basic cryptodev and virtio testing >> * Virtio: both function and performance test are covered. Such as >> PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf >> testing/VMAWARE ESXI 8.0, etc. >> - All test done. found 1 new issue. >> * Cryptodev: >> *Function test: test scenarios including Cryptodev API testing/CompressDev ISA- >> L/QAT/ZLIB PMD Testing/FIPS, etc. >> - All test done. No new dpdk issue is found. >> *Performance test: test scenarios including Thoughput Performance/Cryptodev >> Latency, etc. >> - All test done. No new dpdk issue is found. >> >> >> Regards, >> Xu, Hailin >> >