From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47F6EA0A04; Fri, 15 Jan 2021 15:07:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6FA5141101; Fri, 15 Jan 2021 15:07:52 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 080781410F9 for ; Fri, 15 Jan 2021 15:07:50 +0100 (CET) IronPort-SDR: UGVjTrBfJSsjCkVO2mM7zm5Km5OwuJ+OzavoYFzDIbzoF6cf/b/NKhNd7QLnbpD4S3AMy2uSMI ff38cUCjFNwA== X-IronPort-AV: E=McAfee;i="6000,8403,9864"; a="166221421" X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="166221421" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 06:07:49 -0800 IronPort-SDR: 20RRHzR0fAO/Ri33heovg6dJY4DY3ZuOfyuWvOOgaoScapKmeuEocdV4ZRhAH+RWQECzLUHrbx txC710DWB1Qw== X-IronPort-AV: E=Sophos;i="5.79,349,1602572400"; d="scan'208";a="382675586" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.206]) ([10.213.221.206]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2021 06:07:47 -0800 To: "Min Hu (Connor)" , dev@dpdk.org Cc: konstantin.ananyev@intel.com, thomas@monjalon.net, arybchenko@solarflare.com, linuxarm@huawei.com References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1602151376-23766-1-git-send-email-humin29@huawei.com> <1602151376-23766-2-git-send-email-humin29@huawei.com> From: Ferruh Yigit Message-ID: <7fba6bd4-4471-d505-387f-12867f568583@intel.com> Date: Fri, 15 Jan 2021 14:07:43 +0000 MIME-Version: 1.0 In-Reply-To: <1602151376-23766-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V16 1/3] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/2020 11:02 AM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > Acked-by: Andrew Rybchenko > Reviewed-by: Ajit Khaparde <...> > --- > doc/guides/rel_notes/release_20_11.rst | 5 ++ > lib/librte_ethdev/rte_ethdev.c | 44 +++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 105 +++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_driver.h | 88 ++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_version.map | 3 + > 5 files changed, 245 insertions(+) Hi Connor, What do you think adding 'FEC' feature to the NIC feature list documentation. 'doc/guides/nics/features/default.ini', and explain new feature in the feature documentation: 'doc/guides/nics/features.rst'? This is both good for documentation feature and NICs having a way to advertise this support.