From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0224AA0C43; Thu, 23 Sep 2021 12:13:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84D5141268; Thu, 23 Sep 2021 12:13:42 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 6B4B041250 for ; Thu, 23 Sep 2021 12:13:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="220612271" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="220612271" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 03:13:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="513850379" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 23 Sep 2021 03:13:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 03:13:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 03:13:35 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 03:13:35 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 03:13:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mY6mhrWCNtNdVUdE6OsBLsOScqx83y57IZrlpCmDs1roFqex8Zb7J/MmUh8xqB3z87P5cbQ4KiR5qtuD6QMhbUsXZAP6Ewt7gpfelCLPQTrWKBoXP7/3+QKPnEv3rvrHPCDq/typARwF8MmLQKgOGENzRHbx7btyI0ZFcx9z8LHv5qWb3wRqfqzJ4PfhbzNkMVwRvy0tbzX9bDMt5CzPnjhFafOLnkQhgRcRndTITiKayKLS38gKZhxdoOQ/FMwiVownjZ6QyZACNM1gRr5tgD55Pl1nrmwgcTJ+TEXz9IDLzxhHUrbpPyBspJUhcE58+mLMgFhOGdrv5A88gHStVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5q/dBeZPchWbGGMRv0+IOXvrASH04YGN7/bj04G05Nk=; b=mTYJRGSa1lkIfe7lkhzt9N+eQrxClPGKg1in9hPnLp+g0XyuoYfERH4xaHHCyE8J5kMk+nBVh9CYTMuDaUUijTc1f5UuERgrc1rHjNqb6Ie5gNNTt9FtF21VJouEoy8NMKe29dF0GNNrCrAw+zSWY20mMw9BUjcxd5np62AKo/A+FStgnguhztGgVUVNlFyxKZ3mKOoKQDakcvVvJ7n1bl6biEQ48dPQtA7PPJy6awO9MmjcByBO3GPDXHHG26pmpPAHYp7UlQFQLUOSZ4AgT43xlyJTcESJvdZzbsfaAo++6th3lKR7d24pT9hNVg6hOrYmKV52uqvJ46e7ZaFbUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5q/dBeZPchWbGGMRv0+IOXvrASH04YGN7/bj04G05Nk=; b=be7fev+yLwFDCRs1m58VcI4P0k/HLyRzMNhXmc8oDDwIVmnjsSZHbD+x30GWU16uc1hFfvo3z2NiGvryQ1IlaIxlhCFQsFeQA71gaH2dRFMaEEfcJLcgauuourmybwzB1cIPaQdaGNNdH8xBEqGv/k1zbzAhqZ+5cy+oLrB9z5A= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5061.namprd11.prod.outlook.com (2603:10b6:510:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 23 Sep 2021 10:13:34 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 10:13:34 +0000 To: Apeksha Gupta , , , CC: , , References: <20210909204314.1826-1-apeksha.gupta@nxp.com> <20210909204314.1826-3-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <7fbc1cdf-8974-0012-dd21-c73022559576@intel.com> Date: Thu, 23 Sep 2021 11:13:27 +0100 In-Reply-To: <20210909204314.1826-3-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0360.eurprd04.prod.outlook.com (2603:10a6:10:2b4::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0360.eurprd04.prod.outlook.com (2603:10a6:10:2b4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Thu, 23 Sep 2021 10:13:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b963976-5684-4311-1cd9-08d97e7acce2 X-MS-TrafficTypeDiagnostic: PH0PR11MB5061: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E0p1NTgdCatLcivoPlQfKiDm/uk/uslwcu/3bjYSfvBoTdPRvcEXouurJmjIz745BkYJNWCrb+oRgD00ugFH/05MlAtfbLj1bCayc0+n8RPtRDaAK+08wKqofvdkptJQxdGdDTs8iYqJr2st/lXsSfNbnRvXXSyuj+9bE8pl37OhC8fGzVB5mdONfBpVx1GmLlWfb74gM9k23MH8QGeAH53kIrpaMnXeBVAEtcIHCMwWIXdr5+Owzeu4N4Du/k5utNAMhtSHYrqCmLD6O/ErK9Hm5mll7c34+7M8RAxIIW1d5/xtFUmJxg8YHJ2fKVkrhk335L8qwyhaxinz54SZRq2aR7Nk2fRje5qQ6KLPOIdr35Mpc0V6S576FQJZjs+BCHlz8ls1SNL7eMWVQ0TnEiQ656hi5Yjh0GRDAkgzrZX3IeHs30+6CS0q0ZsLOAIXx3F1jZBa7D8wSEJNKCizW9R0T9wLWmV8VG2ksLec7FdLI2VW4TlJBinvnmQaWpG4G9iuftovfy7oaoGY98AoAdYmLoowAKyGfVwlPh+DUPG1FyxTyZy73oM1JfznqOTDvoTKxkvgiINfSD+IILKMNaAj2dSKqonzrxE/6TbC9WKLRsGrkg0GND+znAdJY82dY/toz6uA3WyMi3L1r3SkmcuoxT5/GoF/0BvfvGqH3eHmEUbVID13wqbfvbvel4sW/omlHIGwSAgvhxxtp+6dlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(66476007)(66556008)(6486002)(8676002)(8936002)(2906002)(508600001)(31686004)(36756003)(5660300002)(86362001)(26005)(53546011)(31696002)(186003)(316002)(16576012)(4326008)(44832011)(38100700002)(956004)(83380400001)(6666004)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S05aRU01RzhGRkc3MWlrNWJNSy9tY2pFaFlwaHJVL215R0FkUE9oakFJbFBt?= =?utf-8?B?MG1pUE9BWnI0WEhxb2l3WVc2OE4vWUltdEtFSE5MNVdQLzg2RFlSRU1OaEd3?= =?utf-8?B?NE9HWUt3eTJVY3NNQlowNmxSUTU4Q2VSMGdsRU1JWkRFbjF5SWk2UFRLWXJ4?= =?utf-8?B?OTNTbUVvNDlCOWZQcW01Wks0VCt3bVVRemhYQzJWZmdxV24vaGNkTlZWK3JM?= =?utf-8?B?Um5xZE5zdTlyY3ZaemNUc1dlRElnUHdIdEVUV1E3bmYwY2UwN2E2YlRYTVVL?= =?utf-8?B?M003RUFvMFh2VEZwbUhEeDA4RzVyVWxOeDZIWi9KKzV3WUovOW14NCtSTGU2?= =?utf-8?B?M2JkaWxVcVNLMnRMS04xamwybTFGMGRDUDltSW11VFRoVXFVMEtlR3NXWEc2?= =?utf-8?B?ak5SUGdtcDRlUGE4SDVaT0RkVnZUU0dzaHVqTFpmMXY4VjlNR2o4VDFWak14?= =?utf-8?B?cU81UFhRYWZVbTNwMFpxNmpRUEtHZitaTUhmWlFEeUxrdGkweFR1QVpJRzdj?= =?utf-8?B?ckU0VnZNcktUamhxdndZOWsrTGFVRGJDU3ZiY09BTG5PQ0NMZVdzU1RvNkZD?= =?utf-8?B?T3pTclBoY1pHVHhuTXBHMnQ0citVdWVZb3VvenVLTjZiaHowcEQyU1FhdVIv?= =?utf-8?B?V09rSnpNeUpIYU9LRHZXMHpPS3NVQ1ZaK2MzN1AzeU9iMXZQYjBjb1ZNRkVs?= =?utf-8?B?MUt4Yy9qc0FLcXZLblhpd2RVTlY2YlVZUWxSbW5wSVFUKytxNlgvWTJwam1I?= =?utf-8?B?STlNOS9Yc2xhS3JLSmdIUHphN3pTaFJMUHdnaURVODhSeHUvR0NRQSt6Q2pl?= =?utf-8?B?bVFCUVNpM2xqdW9GZjY4RG1oVjNwWENUVmJYdG5icE1ra1NRb2pqaEdwbHNx?= =?utf-8?B?VVdyeTBRc0VENnZSRGVOanE2Yml3eEN2YkxhQmFKYnZwQkNJUGl1eVNWM1FK?= =?utf-8?B?UnZ3UTBnd3hiREFIL3FUNVZZRUJsdGZ3dDlDVWpaRzlvbDUyZWIrWG5wTndT?= =?utf-8?B?cDE0OWVhelRQYUdpS3J0TWUyZGFMT2JrR2FZaU9yUUdLcXRHMVlQTU5HUnhT?= =?utf-8?B?Y3IxZm1rUnNldmhuOTJEQmdWQmpjZ3ErRlFTN1R5K1U4TzBQdFZlUGJjY25C?= =?utf-8?B?Vmw1djZzYnhCM0JHRlhHejZESEsyV3FTUXgvVmk5NU03NkcyQzB4ZEVscGVZ?= =?utf-8?B?YzlXYkdBbEx1TVBZNG9WMUVlZGZvaE5YVnV1dlA2ZG9LT0Q0TDdvNzZPczBJ?= =?utf-8?B?TGlFYlZzbW9zcUxvRGdETFdyK2ZPc25NM0Y4djY5bzdRMGNRVGw2MlpvWWpO?= =?utf-8?B?NXBaSVNzYVVKbXZkb1FCaXVJNHBVMW5aNnlrYnpLZHhWbFUvWXhYbmtZb2I5?= =?utf-8?B?clhWcjFHdnZySVc3UTVXdUVKZm1CM2ZLQnhWNVpJMjExWm43Ui91dHpRZThS?= =?utf-8?B?OC9xQTN6NTU2Z2Z1Ynd6OWJjcFJwYy8weFpBcExjUnFmbDlhSC9aaDJTbGtK?= =?utf-8?B?cVFjenhZaFdLZVlydW5lZEYwaUlPVnFjV01RaGs0am5VN1ZyM0R3ZzYxYzZQ?= =?utf-8?B?Wm9JQkpJZkhCdDJpbnpKU1VwUE9Tdy9mMm1IOUpLbk9nZUZpem9vZytIT1Zs?= =?utf-8?B?b0ozM2NBNXZLc2o2VWloTkw5MkFzc0ZjckhleWJ1d2p1cFFiaFZpZ3JvU3RN?= =?utf-8?B?NjFIYU1JcllaeVlTUXVZSUNlNXBQcHVBRjVaTHFoZjBSckJNUVBWdlpWNmww?= =?utf-8?Q?tt+l4Os5mqugla83T8meUUD7WBDBUwrZRvE4dc+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5b963976-5684-4311-1cd9-08d97e7acce2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 10:13:33.9450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dI0VRQUaAmADAQ066Ar4gJkniDaERHoS8GFeVUJyUuUB8FthjEbGTsS+JNgVHw2+yRMHP2GoBmMQv20n+7fxBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5061 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/5] net/enetfec: add UIO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/2021 9:43 PM, Apeksha Gupta wrote: > Implemented the fec-uio driver in kernel. enetfec PMD uses > UIO interface to interact with "fec-uio" driver implemented in > kernel for PHY initialisation and for mapping the allocated memory > of register & BD from kernel to DPDK which gives access to > non-cacheable memory for BD. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta <...> > +static struct uio_job enetfec_uio_job; > +int count; > + This is a global non-static variable with a very generic name, when DPDK application compiled all other dpdk libraries/drivers and applicaiton will have access to this variable. Please make the variable 'static' if possible and add a driver prefix. <...> > +config_enetfec_uio(struct enetfec_private *fep) > +{ > + char uio_device_file_name[32]; > + struct uio_job *uio_job = NULL; > + > + /* Mapping is done only one time */ > + if (count > 0) { > + printf("Mapped!\n"); > + return 0; 'printf' ? Should use logging macros. > + } > + > + uio_job = &enetfec_uio_job; > + > + /* Find UIO device created by ENETFEC-UIO kernel driver */ > + memset(uio_device_file_name, 0, sizeof(uio_device_file_name)); > + snprintf(uio_device_file_name, sizeof(uio_device_file_name), "%s%d", > + FEC_UIO_DEVICE_FILE_NAME, uio_job->uio_minor_number); I guess this assumes 'uio_minor_number' is '0', but how can you know? What if user bind another device first? Implemention your own uio handling is error prone. > + > + /* Open device file */ > + uio_job->uio_fd = open(uio_device_file_name, O_RDWR); > + if (uio_job->uio_fd < 0) { > + printf("US_UIO: Open Failed\n"); > + exit(1); 'exit' ? Exit from all dpdk application because one of the drivers underneath failed? Please return an error.