From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A494EA054F; Tue, 16 Mar 2021 12:47:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 884174069F; Tue, 16 Mar 2021 12:47:56 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E54CA4003D for ; Tue, 16 Mar 2021 12:47:55 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 92FAE7F4FD; Tue, 16 Mar 2021 14:47:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 92FAE7F4FD DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1615895275; bh=m/4XkFZ/VfZcYcLi+GngVCh23Lnzhcqm6oVs5smzSS8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=iiqWpX3dy5wTpUJ7aasxg7CEYefvK95W4JDXxkgWRn2qCve9WrC+QakYtYci8D8P6 AbraB0or2ERWcfsZ4W91xfbD27sSTvS5uxUylZKVBbnxFeG6TKoogHP+m+5+Hdf5oc cb7qEkCaNrz4UnyEBEcdNEb7gspqQj7clyyn711o= To: Ferruh Yigit Cc: dev@dpdk.org, Vijay Srivastava References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru> <20210316085832.942481-1-andrew.rybchenko@oktetlabs.ru> <20210316085832.942481-2-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7fc1d368-ed21-1c4d-e006-a679cba5b0a4@oktetlabs.ru> Date: Tue, 16 Mar 2021 14:47:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 1/8] common/sfc_efx/base: add base virtio support for vDPA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/21 2:30 PM, Ferruh Yigit wrote: > On 3/16/2021 8:58 AM, Andrew Rybchenko wrote: >> From: Vijay Srivastava >> >> In the vDPA mode, only data path is offloaded in the hardware and >> control path still goes through the hypervisor and it configures >> virtqueues via vDPA driver so new virtqueue APIs are required. >> >> Implement virtio init/fini and virtqueue create/destroy APIs. >> >> Signed-off-by: Vijay Srivastava >> Signed-off-by: Andrew Rybchenko > > <...> > >> diff --git a/drivers/common/sfc_efx/efsys.h >> b/drivers/common/sfc_efx/efsys.h >> index 663601412e..d133d61b3d 100644 >> --- a/drivers/common/sfc_efx/efsys.h >> +++ b/drivers/common/sfc_efx/efsys.h >> @@ -187,6 +187,8 @@ prefetch_read_once(const volatile void *addr) >>     #define EFSYS_OPT_MAE 1 >>   +#define EFSYS_OPT_VIRTIO 0 >> + > > Hi Andrew, > > How this 'efsys.h' works, is it compile time configuration file for the > driver? Yes, it is a compile time configuration of the base driver. > Is is expected that users change this file? Client drivers (e.g. net/sfc or vdpa/sfc) change the base driver configuration when it needs corresponding functionality from the base driver. Of course, it is not ideal to add code which is not actually compiled right now, but we always try to ensure that build finally works fine and no extra patches will be required to fix the build when corresponding option is enabled. In theory we can send longer patch series which includes the vdpa/sfc driver, but it will be longer patch series which is harder to chew.