From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 520C7A0C43; Fri, 22 Oct 2021 13:50:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B46D4114A; Fri, 22 Oct 2021 13:50:15 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 596D341149 for ; Fri, 22 Oct 2021 13:50:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229558193" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="229558193" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 04:50:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="445258929" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 22 Oct 2021 04:50:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 04:50:11 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 04:50:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 04:50:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 04:50:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwS0wCf2RsILXDq2JE4idrkeQxcheyBoKRaSXGuIVjpK39faE81YKp0n7AVHKc6B/LfRNKuyCIuZdyyrvOKnVYl0ISy8jSwKG/A6gWopUEL1T1o8QWxtslCRVIgSbk4+4Rj62tOds68UsH2mT9c4OprgBcCttwsBIryG112GfjftXMnjdkANnZHNf86nHJdJnGQzpM4KW0L05ECm/lQxvcceL2fV1ZoNFqlCsWneaEDQjATL9UTknDD8Mv7RSIr4kgIYM5SiRThjzGkKiFUtU9qLZkXlff+FW/XO4zuEwwP/hbNlUEWP5tF2PhAVtsOTmGEfeCsfCn92/i/zBotsYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zy0obxygXe/SAugT6sc1ytpWOI8NvSdha5rBWggmC5s=; b=VHebewigwh6gtiqZxMlZO2jVk0zTRFJgbsS1JhSsZyRd6NksbAnNZL3d0W3EfQECYoVnjYpz/5W2dSmuyRPZdk/mNqsO0Ocgb8UYadyaayWmzIh7LHUCh1n4FatVSqQAdjtWNanfIbHjNpBE8yu+9tUlUdpQ5wXinpGXqJrWF6MwbtU1SuD9sNjontQ9930OQjxhtgnOgJMU/FrbZI3YVQP90FyUaIh0xaMEbQDVu2hwQ2RuKICfJmt/BGY5xOy0Hr4fmLeRbQUrvR8P+3tGApd79KExjr5+jmj8ECoB1KiGq62zstz/H9MET2G8SfD2KFhLQkb9jT50cvSoZ/u4Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zy0obxygXe/SAugT6sc1ytpWOI8NvSdha5rBWggmC5s=; b=I+un+oUvZSLv4P0JqmbZZpq3Tesj++RwDTpsPQ6TlQSGelH7iFkVwYCJ1CQ8g6JbkARTZM8rDVfuNLwX/zRXDyytdHaFocmKBti8AwJEj5f/yGsE8+u8noV1wWgdwtsrMRfA8EQd7JRhfIrFcQsRM9jTUOvvXPcPk7XD6u8Aovc= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB4792.namprd11.prod.outlook.com (2603:10b6:510:32::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 11:50:10 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::f1a0:809a:3d2e:e13c%9]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 11:50:10 +0000 To: "Xia, Chenbo" , "Li, Miao" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-6-miao.li@intel.com> From: David Hunt Message-ID: <7fc7bbf8-b5fd-3f61-b25a-c573c7943c57@intel.com> Date: Fri, 22 Oct 2021 12:50:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB7PR05CA0010.eurprd05.prod.outlook.com (2603:10a6:10:36::23) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [10.4.11.161] (95.45.23.115) by DB7PR05CA0010.eurprd05.prod.outlook.com (2603:10a6:10:36::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Fri, 22 Oct 2021 11:50:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e1b0ef9-1b67-48f4-04e5-08d995521979 X-MS-TrafficTypeDiagnostic: PH0PR11MB4792: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5bCwfqxHUxseiq4NmjIE5WlBYHUV5Fh587ArUOWQUtJZbp20Jljuh5RyzpgN4ebCX3+Se340M1Ui45bn8ii9qQtm6mNHzpNxQufvwmmgYOMimgjFAVlQf8HEN+GT6C1DzTLT3tpMnLBDtidDT/uitAjSk8VW2klhM2GvS4h+KqZccrzdJtSI15k3i2wSEiDCDEj+/RA6IPd6QE6WYdDcaeqO+eRtxWjW+cR6hIRBHarQcxFKtW1KLqxIGcFJyrKXr8jwBJh7krYC+qSipclBSw4o5+MthAAcBdNbYGmjmcYcLtf6rvUiY/h3O4VG8AA15L261d8xaI2fS2LwYyhzxx81iQlJUo83VziklTiFtAkDhUWNUOFzoEtbMOykqe7sEEdYe6FEHLF7IeNVwBAKhsCxHJ5VFryjebLHebNOecmSE0UGg3j1gBs365dSDIhg51HGTZPxc5CYhPZo4VJcAHq+rtLgLfyCTg+tkdsO/2QxsOif/1513wBHHN9jZpRJntE9mVrm9K9iVatlkadi8LXJGLqWpirUgOvnPr501SrlmDaMouOM6gopwV5WMEJEr7yOZV3VNADQIeZV0zpNP79GrxB9U/v6lM327clt1KHetflZdlJcSzpxhyyUgYtDkfK5JkhY+wF1OSanVhVYB8P6VZHLZFI12Sg/SU1uE2B0Vzz6jTfWe0HXu+t8AZ1OHSyiN95CXnI4B6yntEmSfjzFNWJ67Dk0BZEZGZpgpzs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(38100700002)(2616005)(4326008)(44832011)(508600001)(110136005)(53546011)(16576012)(82960400001)(2906002)(6666004)(36756003)(26005)(186003)(31686004)(66946007)(5660300002)(66476007)(6486002)(86362001)(66556008)(8676002)(956004)(316002)(8936002)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzdSaFJpbmV4Qzh0ZGpoeURhdkxxNEdXckJTNUt3Rm1PamRzeVlLS3QvaU9J?= =?utf-8?B?N3U5M3JURCtFM3FTbndpUm9XQlNiMmtUYnR0dk1HVjJSL040a2x5Nm5oblJ1?= =?utf-8?B?cnFmVURHbFR0UU5vQ0dnYWZiNTJJSU1ZZ2g1QWJWUHlvTG5yQlVuVmF0SDlq?= =?utf-8?B?UXlEWmI0TkYreUxIbXlLVkhFbDkyQjVETkZMcXVNNW1JbzJURm4vczluR2xG?= =?utf-8?B?SGgzWklKdGdHZjh3OU0ycHhwQ0JML1pqMVNxVE5INU5tdFpueDQ4WFRBaXp0?= =?utf-8?B?enl0UTQ2RkhEWWxSQWlVRjFPeVJZZGo2VzNuMUdXUWlFN2sxY1NucVlqNytI?= =?utf-8?B?d0cxbHgrRkpZQ3Y3UENWMXVtRi83RFlVNWxLc3FrdzkvNk9QNGluZnJJa2Q1?= =?utf-8?B?ZlhtTnB2NHE3ejhkQVJvVmN1K0lBOEZWOHpPVGh5S0JZbkdVVDlUV1BiR2Rt?= =?utf-8?B?N1FvS1RmL2hSUFpiNzhFbjhUTGltSmtWdVBZY1dRTzJXbTRiSU1JU3BkbGQw?= =?utf-8?B?dEdlYlp4UllDRnIwUGEyZkwvY1lhZkdQUkpKV1pGUUJQd3Q4UG9jcS9tcE15?= =?utf-8?B?eEh6MDZrMVZ0MVcvNWFnODNxbWVneHB2QlhNbmhmU2J5WW9HUE4zQ0VWeFdl?= =?utf-8?B?UjIwRlFhMkhIVVFub3RGTVFKSVU1U2c3b00zWU9sdHNESUFWaTJQZi9NR2hV?= =?utf-8?B?REZHSk5oNm8vK3dGTnVMWUFYeUc0cDVlNk81UThOK2VDSWpIL3pyMjZicks5?= =?utf-8?B?cFRwbFF6NVp1T0lOWFV2OXBwaWsxdVRxaUNFMW0zZmcrd2VyS040Yk1wbEJt?= =?utf-8?B?OGVpYTIwU0wyWkRTWWhuQTd0V2dXN0k0akhVK0lpcVJnQ0tva1JiVm84enY1?= =?utf-8?B?MWtzd2FidXZnN1krYVJIbVRSb0ZEVm55U0hSTTRJWjhJVFNGSjZWaXc4WGV2?= =?utf-8?B?K1pPekx6andZUWhYcTFlWDVrbkpMbGRhSFFOUWNSU240T0paVWtiVmdsSnFK?= =?utf-8?B?aTVMZFJ3TzltUEtFU1F2c29EVmpRaG5vT1FYNDFRZ1RKb2IwS1V3eXAvVUhH?= =?utf-8?B?dFJxWTRIeHJybTdWVXhIOCt4WkJkVHVzWEwvcVdwajZYMzJxSHNtRE9vSlFo?= =?utf-8?B?NDUvRlpRNm5JUHRsTlZoSmhoNWlZRnZnMmdWRWRJK3pSV3dRNkMwcDc3Um1J?= =?utf-8?B?STYwd1I3WTJ5TTZPaHc0RmF2dUhKN3lPQXJvdlFRUytmVHVlV3R2Q1NrbXRL?= =?utf-8?B?YXcwVUdsYncvT3RMcldxMUxBRk5obkxQMFFCdUlvQkRzWHE5ZnNXUmppREZ3?= =?utf-8?B?bVF2TG5ydmFZQ29xU0NWdFdCSC9xYWpkODBJQ0Q1Yk5zT0dlOENEUFAycU50?= =?utf-8?B?aFlLS2UxTWZHSlZtOTZudy9SWnVlSVBXQWxwM2hXRXB1UFRlM1ZYY0hQUDVl?= =?utf-8?B?UGc3TFZvOGRjL0E5SkFrc1JaQXUvT2JWd0RLMHhZVUNlZUwva2FNQ29MSjd2?= =?utf-8?B?Um9yQ1M3TFNFZjBjVVNtK0d3YzJjQVlEV2dudGZseGlYdk9NM3VkR1pQd05z?= =?utf-8?B?eTNhaUZDR3ZTYm45UDZ2R1pxMTdSMXJkWW1BSU1jUFF3QyszUmdDRDFNREFy?= =?utf-8?B?bzh4Y2tHMWF6VUkrZkFDVVpyV3VqeUdsWnpxY2p2Yit4aG5ub1dMK0psZCtr?= =?utf-8?B?WmRJaVlabVpSVk1iUERvMk1hOHVqNERENVhlL05SajlZY3BtaGlLdE94cWMv?= =?utf-8?B?WTNRaDFhbGVxdHpMb1RZUWFLbVBPUzRGOXpPTldvdjhRY2NYZ09FUmV2RnlE?= =?utf-8?B?dDFoTDRVeHQwdlIyczU2MVZySnNlV3lGKzZlZjc0bkVibkY4OHNwWHVGK3ZD?= =?utf-8?B?ci9QbmJOL00rS0lGYVZWMGpYR1BUMTFSelhuRXVIVlFmaDRvVU5rNlhxNzcv?= =?utf-8?Q?aJZvtNk2vJE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6e1b0ef9-1b67-48f4-04e5-08d995521979 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 11:50:10.1842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: david.hunt@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4792 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/10/2021 5:39 AM, Xia, Chenbo wrote: >> -----Original Message----- >> From: Li, Miao >> Sent: Monday, October 18, 2021 10:17 PM >> To: dev@dpdk.org >> Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; Li, Miao >> >> Subject: [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost >> >> In l3fwd-power, there is default port configuration which requires >> RSS and IPV4/UDP/TCP checksum. Once device does not support these, >> the l3fwd-power will exit and report an error. >> This patch updates the port configuration based on device capabilities >> after getting the device information to support devices like virtio >> and vhost. >> >> Signed-off-by: Miao Li >> --- >> examples/l3fwd-power/main.c | 15 ++++++++++++++- >> 1 file changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c >> index 73a3ab5bc0..5811908283 100644 >> --- a/examples/l3fwd-power/main.c >> +++ b/examples/l3fwd-power/main.c >> @@ -505,7 +505,15 @@ is_valid_ipv4_pkt(struct rte_ipv4_hdr *pkt, uint32_t >> link_len) >> return -1; >> >> /* 2. The IP checksum must be correct. */ >> - /* this is checked in H/W */ >> + /* if this is not checked in H/W, check it. */ >> + if ((port_conf.rxmode.offloads & DEV_RX_OFFLOAD_IPV4_CKSUM) == 0) { >> + uint16_t actual_cksum, expected_cksum; >> + actual_cksum = pkt->hdr_checksum; >> + pkt->hdr_checksum = 0; >> + expected_cksum = rte_ipv4_cksum(pkt); >> + if (actual_cksum != expected_cksum) >> + return -2; >> + } >> >> /* >> * 3. The IP version number must be 4. If the version number is not 4 >> @@ -2637,6 +2645,11 @@ main(int argc, char **argv) >> local_port_conf.rx_adv_conf.rss_conf.rss_hf); >> } >> >> + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf == 0) >> + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; >> + local_port_conf.rxmode.offloads &= dev_info.rx_offload_capa; >> + port_conf.rxmode.offloads = local_port_conf.rxmode.offloads; >> + >> ret = rte_eth_dev_configure(portid, nb_rx_queue, >> (uint16_t)n_tx_queue, &local_port_conf); >> if (ret < 0) >> -- >> 2.25.1 > Reviewed-by: Chenbo Xia LGTM. Acked-by: David Hunt