From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 64E0E5F65 for ; Thu, 20 Sep 2018 17:58:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 08:58:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,399,1531810800"; d="scan'208";a="264317229" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.55]) ([10.237.220.55]) by fmsmga005.fm.intel.com with ESMTP; 20 Sep 2018 08:56:16 -0700 To: Nikolay Nikolaev , maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org References: <153698873346.23049.10966616323159180622.stgit@T460> <153698882681.23049.10483393218056672951.stgit@T460> From: "Burakov, Anatoly" Message-ID: <7fe10407-c03a-1899-d4cc-d4f27833d317@intel.com> Date: Thu, 20 Sep 2018 16:56:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <153698882681.23049.10483393218056672951.stgit@T460> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/5] vhost: unify VhostUserMsg usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 15:58:34 -0000 On 15-Sep-18 6:20 AM, Nikolay Nikolaev wrote: > Use the typedef version of struct VhostUserMsg. Also unify the related > parameter name. > > Signed-off-by: Nikolay Nikolaev > --- I'm probably missing some background on this, but according to DPDK coding style guide, typedef structs are to be avoided [1]. [1] https://doc.dpdk.org/guides-18.08/contributing/coding_style.html#typedefs -- Thanks, Anatoly