From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Shachar Beiser" <shacharbe@mellanox.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix drop action seg fault
Date: Thu, 22 Jun 2017 10:51:06 +0100 [thread overview]
Message-ID: <7ff32938-f09b-5428-ef03-f51fe0c980bf@intel.com> (raw)
In-Reply-To: <20170621130200.GI3093@autoinstall.dev.6wind.com>
Hi Nelio,
On 6/21/2017 2:02 PM, Nélio Laranjeiro wrote:
> On Wed, Jun 21, 2017 at 11:55:58AM +0000, Shachar Beiser wrote:
>> Missing room in flow allocation to store the drop specification.
>> Changing flow without storing the change in rte_flow.
>> Fixes: 88c77dedfbb0 ("net/mlx5: implement drop action in hardware classifier")
>>
>> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
<...>
>> --
>> 1.8.3.1
>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> Ferruh, this patch is fixing an issue of a patch only present in your
> master-net branch, the fixline sha1 will be wrong.
I can squash this into relevant patch (88c77dedfbb0).
But there is another patch [1] that cause conflict and seems fixing same
commit (88c77dedfbb0) again.
What do you think squashing all three into one?
I can share latest patch if you want.
[1] net/mlx5: fix creation of drop flows
http://dpdk.org/browse/next/dpdk-next-net/commit/?id=e0e37c1f80a00a2acbb581649b3125a5d465f2c6
>
> Thanks,
>
next prev parent reply other threads:[~2017-06-22 9:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 11:55 Shachar Beiser
2017-06-21 13:02 ` Nélio Laranjeiro
2017-06-22 9:51 ` Ferruh Yigit [this message]
2017-06-22 11:11 ` Ferruh Yigit
2017-06-25 7:42 ` [dpdk-dev] [PATCH v2] fix drop action seg fault missing compilation flag Shachar Beiser
2017-06-25 7:42 ` [dpdk-dev] [PATCH v2] net/mlx5: fix drop action seg fault Shachar Beiser
2017-06-25 7:46 ` Shachar Beiser
2017-06-25 7:46 ` [dpdk-dev] [PATCH v2] fix drop action seg fault missing compilation flag Shachar Beiser
2017-06-25 7:53 ` [dpdk-dev] [PATCH v2] Adding compilation flag for fix drop action seg fault Shachar Beiser
2017-06-25 7:55 ` Shachar Beiser
2017-06-25 7:53 ` [dpdk-dev] [PATCH v2] net/mlx5: " Shachar Beiser
2017-06-25 7:55 ` Shachar Beiser
2017-06-26 12:28 ` Nélio Laranjeiro
2017-06-26 12:55 ` Ferruh Yigit
2017-06-26 13:41 ` Nélio Laranjeiro
2017-06-26 13:51 ` Ferruh Yigit
2017-06-26 14:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff32938-f09b-5428-ef03-f51fe0c980bf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shacharbe@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).