From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0C6427D0D for ; Mon, 4 Sep 2017 18:55:41 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 09:55:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,475,1498546800"; d="scan'208";a="125456066" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 04 Sep 2017 09:55:38 -0700 To: Markus Theil , dev@dpdk.org Cc: stephen@networkplumber.org References: <1504174949-25656-3-git-send-email-markus.theil@tu-ilmenau.de> <1504216020-16067-1-git-send-email-markus.theil@tu-ilmenau.de> <1504216020-16067-4-git-send-email-markus.theil@tu-ilmenau.de> <7f2b5fab-4e5d-aa21-48f8-54675949dc94@intel.com> <5713124c-cc52-016a-9e74-1c22220b856b@tu-ilmenau.de> From: Ferruh Yigit Message-ID: <7ff5b4ae-2354-73c1-a724-668935de0232@intel.com> Date: Mon, 4 Sep 2017 17:55:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5713124c-cc52-016a-9e74-1c22220b856b@tu-ilmenau.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 4/5] igb_uio: use msi mask functions from kernel, little corrections X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 16:55:42 -0000 On 9/4/2017 4:16 PM, Markus Theil wrote: > On 04.09.2017 14:43, Ferruh Yigit wrote: >> On 8/31/2017 10:46 PM, Markus Theil wrote: >>> This patch substitutes the custom MSI/MSI-X mask code and uses >>> already existing kernel APIs. Feedback/small corrections to the previous >>> patch of this series are also incorporated. >>> >>> Signed-off-by: Markus Theil >> <...> >> >>> + if (udev->mode == RTE_INTR_MODE_MSIX || udev->mode == RTE_INTR_MODE_MSI) { >>> +#ifdef HAVE_PCI_MSI_MASK_IRQ >>> + if (irq_state == 1) >>> + pci_msi_unmask_irq(irq); >>> + else >>> + pci_msi_mask_irq(irq); >> It is an option to keep using mask_msi_irq() without #ifdef, it seems in >> newer version of the kernel mask_msi_irq() is already wrapper to the >> pci_msi_mask_irq(). >> >> Although this may make the code simpler, it can break it if >> mask_msi_irq() wrapper removed. >> >> I would go with using mask_msi_irq() directly, but no strong opinion... >> >> <...> > I don't know what the comment "Conversion helpers. Should be removed > after merging" in msi.h really means. If the functions following the > comment are deleted in one of the next versions, I would not change > these lines. Otherwise I second your comment. That comment seems there since version 3.19 :) But it shows the intention to delete the wrappers, so lets stick with your version. Thanks, ferruh