From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2F5CA04EF; Tue, 2 Jun 2020 20:10:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D8021BFEB; Tue, 2 Jun 2020 20:10:34 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4313D1BFE6; Tue, 2 Jun 2020 20:10:29 +0200 (CEST) IronPort-SDR: MBAKqWlkwfmAeU2JCVstYIOmqBX2yVqQNn351qXTwMmID0UnWSiC5pEUyQTiZsHWQ76+WAjc5D yEVh6crMnQ1w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 11:10:28 -0700 IronPort-SDR: rU0FEHUEeZYV3Xfr35gZK0OvNcq9BQWIeQjqGOyF8E65QQnMlr4J6hzf1Pkjj27uWGDN/rCl2l jZurBNNR79dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,465,1583222400"; d="scan'208";a="312359237" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.199.22]) ([10.213.199.22]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jun 2020 11:10:26 -0700 To: Stephen Hemminger , =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: Andrew Rybchenko , dev@dpdk.org, Ian Dolzhansky , Stephen Hemminger , stable@dpdk.org References: <1590590073-8964-1-git-send-email-arybchenko@solarflare.com> <20200527150711.4geagdtf2f5ipjk5@u256.net> <20200527213525.euhc2dlilnypmzg5@u256.net> <20200527150232.687b197f@hermes.lan> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <8004bd23-d3dd-933d-214b-0ed8656a954d@intel.com> Date: Tue, 2 Jun 2020 19:10:25 +0100 MIME-Version: 1.0 In-Reply-To: <20200527150232.687b197f@hermes.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: report valid RSS RETA size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/27/2020 11:02 PM, Stephen Hemminger wrote: > On Wed, 27 May 2020 23:35:25 +0200 > Gaëtan Rivet wrote: > >> On 27/05/20 18:30 +0300, Andrew Rybchenko wrote: >>> On 5/27/20 6:07 PM, Gaëtan Rivet wrote: >>>> On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: >>>>> From: Ian Dolzhansky >>>>> >>>>> Failsafe driver has been indicating zero for RSS redirection table size >>>>> after device info reporting had been reworked. Report proper value. >>>>> >>>>> Fixes: 4586be3743d4 ("net/failsafe: fix reported device info") >>>>> Cc: Stephen Hemminger >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Ian Dolzhansky >>>>> Signed-off-by: Andrew Rybchenko >>>>> --- >>>>> drivers/net/failsafe/failsafe_ops.c | 8 ++++++++ >>>>> 1 file changed, 8 insertions(+) >>>>> >>>>> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c >>>>> index e046cfe6aa..45da9378c3 100644 >>>>> --- a/drivers/net/failsafe/failsafe_ops.c >>>>> +++ b/drivers/net/failsafe/failsafe_ops.c >>>>> @@ -1068,6 +1068,13 @@ fs_dev_merge_info(struct rte_eth_dev_info *info, >>>>> info->rx_queue_offload_capa &= sinfo->rx_queue_offload_capa; >>>>> info->tx_queue_offload_capa &= sinfo->tx_queue_offload_capa; >>>>> info->flow_type_rss_offloads &= sinfo->flow_type_rss_offloads; >>>>> + >>>>> + /* >>>>> + * RETA size is a GCD of RETA sizes indicated by sub-devices. >>>>> + * Each of these sizes is a power of 2, so use the lower one. >>>>> + */ >>>>> + info->reta_size = RTE_MIN(info->reta_size, sinfo->reta_size); >>>>> + >>>>> info->hash_key_size = RTE_MIN(info->hash_key_size, >>>>> sinfo->hash_key_size); >>>>> >>>>> @@ -1128,6 +1135,7 @@ fs_dev_infos_get(struct rte_eth_dev *dev, >>>>> infos->max_hash_mac_addrs = UINT32_MAX; >>>>> infos->max_vfs = UINT16_MAX; >>>>> infos->max_vmdq_pools = UINT16_MAX; >>>>> + infos->reta_size = UINT16_MAX; >>>>> infos->hash_key_size = UINT8_MAX; >>>>> >>>>> /* >>>>> -- >>>>> 2.17.1 >>>>> >>>> >>>> Hello Andrew, Ian, >>>> >>>> The reta_size info is linked to being able to update the RSS RETA. >>>> >>>> I don't think it is a bug for the moment to report 0, as long as >>>> failsafe does not support RETA update. Now, the reta_update ops could be >>>> quickly implemented in failsafe, but that should be a new feature. >>>> >>>> Did you hit an issue with it? >>> >>> Hello Gaetan, >>> >>> in our case reta_size is required for RSS testing even if there >>> is no reta update and query API to estimate where a packet >>> should be delivered. It assumes that default reta spreads over >>> all Rx queue evenly. I.e. we need reta size and number of Rx >>> queues to built default reta. >>> >>> May be it is really very testing specific, but IMO logical >>> anyway. >>> >>> Andrew. >> >> Alright, given the size of the change there is no reason not to add it >> if it can improve consistency. >> >> I think the patch is fine otherwise, I'm just not sure it should be >> marked as a bug fix, but backporting won't be hard. >> >> Thanks, >> >> Acked-by: Gaetan Rivet >> > > Agreed, looks good to me, but probably doesn't matter much. Almost all hardware > only supports one reta_size anyway. > > Acked-by: Stephen Hemminger > Applied to dpdk-next-net/master, thanks.