From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172]) by dpdk.org (Postfix) with ESMTP id F18FF6CD0 for ; Thu, 13 Oct 2016 21:21:21 +0200 (CEST) Received: by mail-qt0-f172.google.com with SMTP id s49so55987093qta.0 for ; Thu, 13 Oct 2016 12:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=apmz/V4XjOOi57v4PZDZCpmb++JSOBPK1kyRNcj1+ag=; b=yx9o865cYGSGpXUZKiZQcQjL6irvROxyotjaAWPoaHKM7XJgwdRzgeOMxu7vCF1S1z CFETU2DLwlVktl6YirMRsplCtKekmlTYQmD1aD0e5RwMm87/TB9DBGrGLgr/arHEPPKZ n3H9AxNMuozjhcq7RDuTEVp3RhnCnMoiOzoQEBHjPpLScwX4SNT/enfMBslIffCAz7BI euFfolJdvtvHRjTbIHhOPneitYK/nxcs/u1+wgoMqJYnktYoMIQ/x7aQ3vQzDE05MHQC 7eCDweBOY+tJOP9I+aFwtU+vmr5FG1z80j+jdljhTjkMLxKn0rXXGFOPG2NSGrB27vPg XKMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=apmz/V4XjOOi57v4PZDZCpmb++JSOBPK1kyRNcj1+ag=; b=YzOd2lz5Xe76tVP4dhnsdQPCLJGcfKFzTFzvh3LsvinS36cFtRQBvP/EtXI+rqxREA fKCzNAfCpG4Uo9eMTwf2KT65/b/PxGFgZhiXh5CFv2INOczQOdkxUAF3DP7CGhUceTFj wfn2GGU2ja7Z3bZKWrYQpDVbNvdfygxuVwAFZoZ3DCxTAopN09izjShEhkGPIiq6D3vM P1unDfPuaNVltOKRwyAQdLj+IzOmqB/0K3Sml6eaTs0JnLVJziF5G7ZuckL6W/q7qQIy Vqx1mDMk1tYvHGpynPgw6mXeE1/uHtejSzI9JIIITa/brbjJbvmCBZuG/EUNN20OnqjD rG2g== X-Gm-Message-State: AA6/9Rmg5Vs9+1wlDp/YxKazAzNlD2u9ugFZdrITQjD6t6hJMHMmEwXEIYHSBS89lsDAuSnx X-Received: by 10.28.46.15 with SMTP id u15mr3166528wmu.61.1476386480354; Thu, 13 Oct 2016 12:21:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a1sm24917335wju.41.2016.10.13.12.21.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Oct 2016 12:21:19 -0700 (PDT) From: Thomas Monjalon To: Tomasz Kulasek Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Thu, 13 Oct 2016 21:21:17 +0200 Message-ID: <8024593.WaNfoiub2G@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1476380222-9900-2-git-send-email-tomaszx.kulasek@intel.com> References: <20160930090039.10164-1-tomaszx.kulasek@intel.com> <1476380222-9900-1-git-send-email-tomaszx.kulasek@intel.com> <1476380222-9900-2-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 19:21:22 -0000 Hi, 2016-10-13 19:36, Tomasz Kulasek: > Added API for `rte_eth_tx_prep` > > uint16_t rte_eth_tx_prep(uint8_t port_id, uint16_t queue_id, > struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > > Added fields to the `struct rte_eth_desc_lim`: > > uint16_t nb_seg_max; > /**< Max number of segments per whole packet. */ > > uint16_t nb_mtu_seg_max; > /**< Max number of segments per one MTU */ > > Created `rte_pkt.h` header with common used functions: Same comment as in previous revision: this description lacks the usability and performance considerations. > +static inline uint16_t > +rte_eth_tx_prep(uint8_t port_id __rte_unused, uint16_t queue_id __rte_unused, > + struct rte_mbuf **tx_pkts __rte_unused, uint16_t nb_pkts) Doxygen still do not parse it well (same issue as previous revision). > +/** > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets before > + * hardware tx checksum. > + * For non-TSO tcp/udp packets full pseudo-header checksum is counted and set. > + * For TSO the IP payload length is not included. > + */ > +static inline int > +rte_phdr_cksum_fix(struct rte_mbuf *m) You probably don't need this function since the recent improvements from Olivier.