From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 9CE075A4F for ; Fri, 30 Oct 2015 12:17:51 +0100 (CET) Received: by wmff134 with SMTP id f134so9310597wmf.0 for ; Fri, 30 Oct 2015 04:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=woR+m6TyE4P5Tmf9vXhCMx0xvoi8rcz57rzfAlDIpaw=; b=vvwYYoHN3z7lYqd/NPgjQtXDic2+6wko7UkRL+l6kW4JrSx4xis5tgJC+5f3DVxj9g KllGrbzjXIAbT7QkyhHAqH62I554JKCS+yJEbYh2FArKg7dX+5gOhdpBy2bW3Wp282Ux DHzNkDBeZsIOOWuX5wNDOC1DCh/LyMVasxGMEk/cB8yXwxR9asfTmtfoIzS3zWrp+7c8 gkva543m0XMaD8fICFhz9gSPV+3aaGV+Cx+CqS0aYoqYx9/Q+ZXqwJV1u1qxlWFf9Ax0 1oIWh1igeOp9qEkl0FXnd2mt9/omtKoQ5RbZOWWcgswEomMkThK/bb4elU/IflIqIKSX KDGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=woR+m6TyE4P5Tmf9vXhCMx0xvoi8rcz57rzfAlDIpaw=; b=eFddm1HGsL+g404/dh6s2E4GblTLaQEJlF9bRHqfpvPFt9RflGwRyMPTcQDD97NX4R D0Tvq0WzfqkNGivcDih/w6NdmXV4Vc1xyxKEy3Ah5ArCIdub3eRjrSvqYvHFfcXfBm9p 6j+EDoLLpZj45b7FQlaIH+0wcrfxaZsx82dnsPm9Fux3JmNzitTpR7dWhlHnsD4bszai PAxIgbR/82H6oAnxj0NTtQ7G9CJo4MCHh76+u9UQg3XccC1EEyqZfRfhp/OJkmt70yNo 5a0DFRr1rYpdIjNQf/+FubPJ4WoDqFX5jHzeYUrV7prkni1rQN4SBTzFPDM9PHYksAuO o9Mg== X-Gm-Message-State: ALoCoQm2snwu8iz3R2W/J/xa/G4ezkmX1G4/Uk9CpLIcZN9diu4I9aZ48P9P9HiipkiJT2w8VxhH X-Received: by 10.28.6.142 with SMTP id 136mr2886913wmg.9.1446203871430; Fri, 30 Oct 2015 04:17:51 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ee5sm6569536wjd.17.2015.10.30.04.17.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Oct 2015 04:17:50 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Date: Fri, 30 Oct 2015 12:16:40 +0100 Message-ID: <80355980.tZqCmrPgr9@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446108827-7907-6-git-send-email-jingjing.wu@intel.com> References: <1443074591-19803-1-git-send-email-jingjing.wu@intel.com> <1446108827-7907-1-git-send-email-jingjing.wu@intel.com> <1446108827-7907-6-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 05/10] ethdev: new API to get dcb related information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 11:17:51 -0000 2015-10-29 16:53, Jingjing Wu: > This patch adds one new API to get dcb related info. > rte_eth_dev_get_dcb_info > > Signed-off-by: Jingjing Wu > --- > lib/librte_ether/rte_ethdev.c | 18 +++++++++++++++ > lib/librte_ether/rte_ethdev.h | 54 +++++++++++++++++++++++++++++++++++++++++++ You forgot to update the .map file. So there are some build errors later: undefined reference to `rte_eth_dev_get_dcb_info' Jijiang, Helin, and other reviewers generally, please try to catch this kind of errors (.map, doc) as they are quite common and make the integration process slower when I catch it only at the end. Better are the patches, more will be integrated. Thanks