From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74589A0524; Fri, 27 Nov 2020 14:56:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7A8FC950; Fri, 27 Nov 2020 14:56:22 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 64202C94E; Fri, 27 Nov 2020 14:56:20 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 9953B580F8A; Fri, 27 Nov 2020 08:56:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 27 Nov 2020 08:56:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= c6/ZlDSJI7etlIN38MowG47Un2dwib6f5Ptm4z+iLzc=; b=oNURnUBy5q8Ws9/b RHhlOpfhU8jgInKa/rVknlTVnDo78TkW/f9SB70QtV3EIYuBflOHVmefVItKQWfR D98wVeD0oHOWjXTLADEdDGubIXMx34OUSdfe61yQslQpribHXN0JZfwtM/q8bHUI UIrJpGrEwgPg7PWN6wSvM4iGduDBwinGL0o9x/80a0lIGd3kTy/eFyNe7BhIHwh5 lbD7GGEIWr7sMKnnNmGM8OLZgB8g6uBISHxvCYFxkVhsQq1AcP/g+mVZcOTlgUY1 ShbcBz3ADcUy0Ic1qRvQQcO9OcVjRL+w7w77kZaVXcY7D+TjLE1cpXAaukrjeE+Z hz6ezg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=c6/ZlDSJI7etlIN38MowG47Un2dwib6f5Ptm4z+iL zc=; b=IqggkWNFDgwzHT97UEcPuP5lMrK2g8+Trd1bxCx+WqiCWrN4FsA0B6ERl Dw588sy1CZkAm4mwsEifWny2cMqbkR5ntlN4CibUosQwZv5LWR3MhhkPIuAldKoy GiOLl0JRoHodQzHSlGKmB56peWbW06puLSY46m7PnDGqHpiRuOZmXT+nzYIodZ1p seQO0l9AqAx7+RJrvYr5qbDL5Wwox8BODOyHzj0oGcqV+Ay75eVbJ9D5A5T0SEtA bxRjUDk3hJxS97QH77kOtIraOAV7i6aFMTkzUEeb+OSCZaNFlu3y+4TC9mZrCNO0 IA2/XSJ+M7VrqzFI5TxXf5ole/SLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehgedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EA4B03280064; Fri, 27 Nov 2020 08:56:15 -0500 (EST) From: Thomas Monjalon To: techboard@dpdk.org, Ferruh Yigit Cc: David Marchand , Bruce Richardson , Anatoly Burakov , David Hunt , Pablo de Lara , Stephen Hemminger , dev@dpdk.org, Conor Walsh , John McNamara , andrew.rybchenko@oktetlabs.ru Date: Fri, 27 Nov 2020 14:56:14 +0100 Message-ID: <8047461.tS4YFHTYsG@thomas> In-Reply-To: <407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com> References: <20201126141832.2277628-1-ferruh.yigit@intel.com> <407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/11/2020 10:55, Ferruh Yigit: > On 11/26/2020 6:31 PM, David Marchand wrote: > > On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: > >> > >> script is checking the existing of the kernel module file, but in some > >> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. > > > > Since this script expects modprobe to be installed (coming with kmod > > tools), it means modinfo is available. > > Checking for module availability should be "modinfo vfio-pci". > > > > +1, that is definitely better. > > I can send a new version with it if we decide to keep the script. It is too late to improve this old script. We should let it die and rest in peace. > Mainly we are tying to decide to remove the script or keep with the changes in > this set. I appreciate your effort Ferruh. It shows that almost nothing is worth to keep in this script. > There aren't still much comment on it, only comment by you in favor of removal, > I haven't seen any comment to keep the script. > > Added more folks for comment, also techboard comments are welcome. My opinion is that we should follow the deprecation notice and remove the script in 20.11. If someone wants to keep the same VFIO manipulations, it is possible to copy/paste from old versions.