From: Luca Boccassi <bluca@debian.org>
To: Thomas Monjalon <thomas@monjalon.net>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
John Alexander <John.Alexander@datapath.co.uk>
Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings
Date: Wed, 11 Nov 2020 15:03:52 +0000 [thread overview]
Message-ID: <805419dbc589b31f01e8864004a5c2a59dfd6e78.camel@debian.org> (raw)
In-Reply-To: <3042169.36grohAEOo@thomas>
On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote:
> 29/10/2020 23:55, Dmitry Kozlyuk:
> > MSBuild XML files have to use CRLF line-endings, otherwise any change
> > results in the whole file being rewritten with CRLF line-endings by
> > Visual Studio. However, it's inconvenient to have such files checked-out
> > with CLRF in Unix environments.
> >
> > Add suggested git configuration to top-level README, so that Unix
> > developers don't miss it. Remove .gitattributes, because core.autocrlf
> > overrides eol= attribute. Convert line-endings of the existing files in
> > the repository.
>
> It is converted to what?
> You mean all files should have LF endings in the repo?
>
> [...]
> > windows/virt2phys/virt2phys.sln | 54 ++--
> > windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++--------------
> > 4 files changed, 259 insertions(+), 258 deletions(-)
>
> The file windows/virt2phys/virt2phys.vcxproj.filters is not converted.
> And I see other stuff to fix, see below.
>
> > +Some Windows files use have to use CRLF line-endings.
>
> "use have to use" -> "have to use" ?
>
> Isn't it automatic to have CRLF on Windows git working tree?
>
> > +Unix developers can configure git to get only LF on checkout:
> > +
> > + git config core.autocrlf input
>
> Isn't it the default?
> If all files have LF, there is nothing to do on Unix.
>
>
> I think more fixes are required as below:
<..>
Yes, I second that - those changes are needed too.
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2020-11-11 15:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 22:55 Dmitry Kozlyuk
2020-11-03 4:05 ` Narcisa Ana Maria Vasile
2020-11-03 7:42 ` Dmitry Kozlyuk
2020-11-03 10:05 ` Luca Boccassi
2020-11-11 15:02 ` Luca Boccassi
2020-11-11 15:11 ` Dmitry Kozlyuk
2020-11-03 20:49 ` Narcisa Ana Maria Vasile
2020-11-11 15:02 ` Thomas Monjalon
2020-11-11 15:03 ` Luca Boccassi [this message]
2020-11-11 15:09 ` Luca Boccassi
2020-11-12 20:16 ` Luca Boccassi
2020-11-12 20:15 ` [dpdk-dev] [kmods PATCH v2] " luca.boccassi
2020-11-12 23:17 ` Thomas Monjalon
2020-11-13 7:06 ` Dmitry Kozlyuk
2020-11-13 9:43 ` Thomas Monjalon
2020-11-13 9:52 ` Luca Boccassi
2020-11-13 9:50 ` [dpdk-dev] [kmods PATCH v3 1/2] windows: remove .gitattributes luca.boccassi
2020-11-13 9:50 ` [dpdk-dev] [kmods PATCH v3 2/2] windows: normalize line-endings luca.boccassi
2020-11-13 15:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=805419dbc589b31f01e8864004a5c2a59dfd6e78.camel@debian.org \
--to=bluca@debian.org \
--cc=John.Alexander@datapath.co.uk \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=navasile@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).