From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CDCB4247D; Tue, 24 Jan 2023 16:48:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1710140150; Tue, 24 Jan 2023 16:48:03 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id A2321400EF for ; Tue, 24 Jan 2023 16:48:01 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EDA7A5C05AA; Tue, 24 Jan 2023 10:48:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 24 Jan 2023 10:48:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674575280; x= 1674661680; bh=RxBjlXawN36fQzbjZhkQZDXYKVbPxLq6nCPCbPtHQP8=; b=H H3K59Li4mVbUCapy5yjWWzCiJhr7KkVKb7CwfINRD6HCPOsSKsNgKj9Snn6wjJ+y EnhMkSY8aNrbNeK0MmW+UcrC0dMIaoSUqyvMKffZzyRFW9h4eQC2nLmxXq0a1aCw TuTO2bMxyeUNyAHR9l6LVHcr63wpNYakLBjXgCwDgRGMADxT8ynXlPdkGbtnM1mi RtWS4fItEGO16cQfGUIYj6F/qTu6kY+lGvosu3jt1zMD7eojBDX0Q0CtVyGk3TWL Tynt66A3NgbsJAKZsAGTWNbTcEiI+953aEzrJArjFNHIxLMilO2E32IjCMtNTGFP zblHx44aEdzyDFuMUWGSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674575280; x= 1674661680; bh=RxBjlXawN36fQzbjZhkQZDXYKVbPxLq6nCPCbPtHQP8=; b=S 2d9c8nt8IkWOapH01OVY0FTHtteB/U/39ghpiPU9W2ivQhw5axoza3PDi6jgwPDA pAQsXaXfwGKUIF/T61a147sya6++ddlyHVnrOdEAGx7S2dafcnjFd/1XwBfXNfbP 8xDMdR3nYiUaiMNq9K2ogd8sXwEsinme9VhtiyEJHRKAy8/UEU9KgpFLulM07usP VvOqgDML0qrQjo3aH5CyAoZXEogeEpwx4PRihhrt8AKyAugMXgwz+uVwqrVZfUUa 5TsdYFiYlYjRh0kLFHqxpeEDqtT75AQ9NEC+ayjzZDNEtp6hsTpvChmo0/FNn5Lc LIs135Q9WpRr3rTEA8bIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvtddgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtqh ertddttddunecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepfefhjeeluedvvedtud dtuedtvefhieejtefhffeujefhteduudevtdektdeikeffnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jan 2023 10:48:00 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads Date: Tue, 24 Jan 2023 16:47:58 +0100 Message-ID: <8079898.qOBuL9xsDt@thomas> In-Reply-To: <20230124153304.GA23027@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <3854099.WbyNdk4fJJ@thomas> <20230124153304.GA23027@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/01/2023 16:33, Tyler Retzlaff: > On Tue, Jan 24, 2023 at 04:25:34PM +0100, Thomas Monjalon wrote: > > 23/01/2023 20:39, Tyler Retzlaff: > > > Bring Windows EAL worker thread initialization in line with linux & > > > freebsd by setting the worker thread name using the new > > > platform agnostic rte_thread_set_name API. > > >=20 > > > Signed-off-by: Tyler Retzlaff > > >=20 > > > Acked-by: Morten Br=F8rup > > >=20 > > > --- > > > lib/eal/windows/eal.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > >=20 > > > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > > > index b9f95ed..e561f87 100644 > > > --- a/lib/eal/windows/eal.c > > > +++ b/lib/eal/windows/eal.c > > > @@ -282,6 +282,7 @@ enum rte_proc_type_t > > > enum rte_iova_mode iova_mode; > > > int ret; > > > char cpuset[RTE_CPU_AFFINITY_STR_LEN]; > > > + char thread_name[RTE_MAX_THREAD_NAME_LEN]; > > > =20 > > > eal_log_init(NULL, 0); > > > =20 > > > @@ -437,6 +438,12 @@ enum rte_proc_type_t > > > if (rte_thread_create(&lcore_config[i].thread_id, NULL, > > > eal_thread_loop, (void *)(uintptr_t)i) !=3D 0) > > > rte_panic("Cannot create thread\n"); > > > + > > > + /* Set thread_name for aid in debugging. */ > >=20 > > No need of underscore in "thread name". >=20 > The variable name was copied from linux/eal.c and matches freebsd/eal.c > do you still want me to remove the underscore? It will require another > revision of the series. I mean in the comment, you want to use natural language, not the variable name. Before making a new revision, let me check all patches.