From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E713A09FF; Wed, 6 Jan 2021 23:12:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09BBF140E48; Wed, 6 Jan 2021 23:12:21 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 1188B40FA7 for ; Wed, 6 Jan 2021 23:12:19 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id B3A105D2; Wed, 6 Jan 2021 17:12:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 06 Jan 2021 17:12:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= VXBgpkxNThxaDF2u1oCGXy+2SXcvCYq3b6yXCgyawjw=; b=hZGToL3f0v/k1kbX ZVwVbWq8+hC/rt7zwcq9xr+SveSdG3EbwCMsrRuwjL/iD9iFYgLq1pezoP/IOg+I bLeIsXnSscfDJvLdyY5aDKnCRnCqrBt8PQH/pFBgJSWX9UP+eitqIxLuIzEMAM5a hL259muswEWs3ieQiwGJ6onDRABqcuhw8MT36BcbviE78n45Vr1Mm/6oNj8Td44+ mK+X7jO/N32P17Gpnmnv6QrZ2JPGB6yYuDshfcUevJqKn/tgbYaLI8f+3cKx5sKb BypsJ9FJWMDh14uRcxOm1rPebPHjoXTGF07qSzh4PLssifOXKb5Jn9fDxwDaVdAH tVpwgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=VXBgpkxNThxaDF2u1oCGXy+2SXcvCYq3b6yXCgyaw jw=; b=idxoJnklXd4QT9udKodIrcOcsw1q1Usg5pg7ez3STmsui47ZyhKY4Ytkn yohqJh5zGVBRA7bAzIc9s1IBFxaNQVTcvzVad0t/gG97884Kj8qQQh4X65H2tk8S UI29EPe4Uy0E2t3C0C5DwhesKEq5Q1p9b6NaSLAZvdIOhAqyau2Fb0i66KlETJ+X XZmCl5+0JWXIIj5hPToPaqaQr6KyMGsYnObmI4k+F0//UcttxUisKJG6+roCwbVV 6onIIeDCnpg0lnwTPYqzulIJjO44zlEDpi9U4PEMNZ0UqZYHeE1SB94bDdU8HIhM hnLJ82qSwG2G65rjo9ONYc9Ov3Z2Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdegtddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 951B124005A; Wed, 6 Jan 2021 17:12:15 -0500 (EST) From: Thomas Monjalon To: Jeff Guo Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Date: Wed, 06 Jan 2021 23:12:14 +0100 Message-ID: <8091331.oFBQTsvStG@thomas> In-Reply-To: <20201224065940.76857-2-jia.guo@intel.com> References: <20201216085854.7842-1-jia.guo@intel.com> <20201224065940.76857-1-jia.guo@intel.com> <20201224065940.76857-2-jia.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/12/2020 07:59, Jeff Guo: > Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. > > Signed-off-by: Jeff Guo > Reviewed-by: Qi Zhang [...] > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type { > RTE_TUNNEL_TYPE_IP_IN_GRE, > RTE_L2_TUNNEL_TYPE_E_TAG, > RTE_TUNNEL_TYPE_VXLAN_GPE, > + RTE_TUNNEL_TYPE_ECPRI, > RTE_TUNNEL_TYPE_MAX, > }; We tried to remove all these legacy API in DPDK 20.11. Andrew decided to not remove this one because it is not yet completely replaced by rte_flow in all drivers. However, I am against continuing to update this API. The opposite work should be done: migrate to rte_flow. Sorry, it is a nack. BTW, it is probably breaking the ABI because of RTE_TUNNEL_TYPE_MAX. PS: please Cc ethdev maintainers for such patch, thanks. tip: use --cc-cmd devtools/get-maintainer.sh