From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id CF4695F17 for ; Mon, 3 Sep 2018 16:00:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id A40CB800074; Mon, 3 Sep 2018 14:00:46 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 3 Sep 2018 15:00:17 +0100 To: Ferruh Yigit , Jerin Jacob , Wenzhuo Lu , "Jingjing Wu" , Bernard Iremonger , John McNamara , Marko Kovacevic , Qi Zhang , Xiao Wang , Neil Horman , Remy Horton , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "John W. Linville" , Allain Legacy , "Matt Peters" , Ravi Kumar , "Ajit Khaparde" , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , John Daley , Hyong Youb Kim , Gaetan Rivet , Beilei Xing , Konstantin Ananyev , Matan Azrad , "Shahaf Shuler" , Yongseok Koh , "Tomasz Duszynski" , Dmitri Epshtein , "Natalie Samsonov" , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Jan Remes , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Amr Mokhtar , Declan Doherty , Chas Williams , David Hunt , Anatoly Burakov , "Harry van Haaren" , Xiaoyun Li , Thomas Monjalon CC: References: <20180903144501.31373-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Message-ID: <8094678a-63e0-1e8b-0063-86b77db4fdf7@solarflare.com> Date: Mon, 3 Sep 2018 16:59:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180903144501.31373-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24070.003 X-TM-AS-Result: No-2.863700-8.000000-10 X-TMASE-MatchedRID: 7ySqCuYCpfj4ECMHJTM/uSa1MaKuob8Pt3aeg7g/usBkDFfw8NSG/HHU HCqTYbHtwqu1JsRWr+tCzelCYnWU37wf4SeL/tXddXz3l78F3YkEa8g1x8eqFw6QlBHhBZuw5eg DOAGt4BZGcmX/NKw8zh0XwFnoQFewTX7PJ/OU3vKDGx/OQ1GV8khax4LkeV5t+gtHj7OwNO2Ohz Oa6g8KrTBBtORN9f9xTskhhVXJEZsvFPRqofBBwPQdbajueRsI+tmNozxT36PZawuNtK6UgGbXE KA1obZ0Pggn4b9sXOFPqGgY+4RHKOL59MzH0po2K2yzo9Rrj9wPoYC35RuihKPUI7hfQSp5vRIC FdEdOvdnIxZyJs78kg== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-2.863700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24070.003 X-MDID: 1535983250-91zE9YIXwvjB X-Mailman-Approved-At: Mon, 03 Sep 2018 17:07:17 +0200 Subject: Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 14:00:52 -0000 On 09/03/2018 05:45 PM, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() > > Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko