From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0048.outbound.protection.outlook.com [104.47.36.48]) by dpdk.org (Postfix) with ESMTP id D4D6B2BA7 for ; Fri, 20 Jan 2017 14:17:59 +0100 (CET) Received: from BLUPR0301CA0001.namprd03.prod.outlook.com (10.162.113.139) by MWHPR03MB2479.namprd03.prod.outlook.com (10.169.200.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.860.13; Fri, 20 Jan 2017 13:17:58 +0000 Received: from BY2FFO11OLC007.protection.gbl (2a01:111:f400:7c0c::146) by BLUPR0301CA0001.outlook.office365.com (2a01:111:e400:5259::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.860.13 via Frontend Transport; Fri, 20 Jan 2017 13:17:57 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11OLC007.mail.protection.outlook.com (10.1.14.254) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Fri, 20 Jan 2017 13:17:57 +0000 Received: from [127.0.0.1] ([10.232.134.49]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v0KDHo4c031969; Fri, 20 Jan 2017 06:17:54 -0700 To: Neil Horman References: <20161222201700.20020-1-akhil.goyal@nxp.com> <20170120140509.4495-1-akhil.goyal@nxp.com> <20170120140509.4495-4-akhil.goyal@nxp.com> <20170120123237.GA15111@hmswarspite.think-freely.org> CC: , , , , , Hemant Agrawal From: Akhil Goyal Message-ID: <80e5fc73-9a47-a3c5-db0a-1329810b1a39@nxp.com> Date: Fri, 20 Jan 2017 18:47:49 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170120123237.GA15111@hmswarspite.think-freely.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131293918773367317; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(336005)(39450400003)(39840400002)(39860400002)(39380400002)(39410400002)(39850400002)(39400400002)(2980300002)(1109001)(1110001)(339900001)(24454002)(189002)(377454003)(199003)(356003)(6666003)(7246003)(2950100002)(50986999)(54356999)(7126002)(76176999)(23746002)(6916009)(104016004)(50466002)(229853002)(31686004)(38730400001)(33646002)(65826007)(5660300001)(65956001)(69596002)(110136003)(106466001)(65806001)(93886004)(305945005)(77096006)(626004)(54906002)(8656002)(105606002)(120886001)(47776003)(83506001)(36756003)(86362001)(6306002)(2906002)(97736004)(4001350100001)(68736007)(92566002)(31696002)(85426001)(8676002)(81166006)(4326007)(15395725005)(53936002)(189998001)(8936002)(230700001)(81156014)(64126003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2479; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC007; 1:yjZChm1LAtEBCkoHo3rWuWF+xbRqK0Iwv7q5fakscgjqIVLEh/oY0wcPf0lF815N5ETHnQpVJTjiK7taTJi2S85zBkEHrRqmVZhtyDhQ7Z16du1FBuQlWGgbibedde2p8zzuD1qLtQeelkOgRD/Qt8XU4dtZAZlN+n3ukowAEgQV9USBUBlTp7SGizAqFetdnmjvdCiKDHfptcD4PnxaG9QUjulh432+1H8Oz+N3LxJQ+PC4qBDkSmkHKD0VLHg4CXxTldS6Jd8VdVlLleyc0sL3Fd4BzqEzjQkvPR/lPQRGXHkPGSh/KMOWGMxHi0J8oV3nBMYaB8VsXY1UZvhs12t2cwXMVPwLl2ZoTTc/ckOGq1DtZb7eS6eqdY4Jdca6iyElUNdFKjy+nBzM4UDrQeCUY4QAwRYMWboSEwsmie+cimjGdvFUtnkZCbI/7YXC6doiNBZsJPw+bl4ubHu5XJ4R35peVouI9RVDDdky1UKbAVHgXAJudqlrnJHFEy+2dOXjMzBMQX71NSC5O07D5IKfh2TsUcaEyTgZPumMsJYosyycvhQrBD8ZvpDNXjUrQ9bB1o6GJZqg3bV+wMaX6uUahRPFONk9Ww5ubapf4DY= X-MS-Office365-Filtering-Correlation-Id: 3f815c93-d42a-4177-65e2-08d44136c009 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR03MB2479; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 3:Eo5vdrlfWw7UsConJglzKJhXTSHz3MfqQiKf0ddHWfRferFn/hgZk+HIvhna5fbhNTZc80fqCKeA3sSCfwPdTKekFuiTJeNp353QNPVcVJVExg6kMmlb5V2t7xxnvW76o9JUtgtS80+SFECaBVmnZJsEtl/9ckQtoP8vIKttQFb6yATUoQwI0MxTrd4bSnPanpammHjydBBSn4WaXJWvN6qmLNiqE8BETtB695D65kk2pwnYROwb39wF21uQbO9l6Bc1hJEyxTMpMU3kC2D22oV29Sn84JSkwi//g2BARhNVd+NjpJ6WbSTZYSJbXvEgWL1ZNa1Bby9wbAqSR81bTHn8Zm2I7TPy5Rtbdm88QwbP4aL8P3hGNeFf+ZiyqejK X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 25:222UwEbxzwCFdo1UawYx7SnFOP409mLFOdeoZg9yzCF8m7zddRhtef3EJyP60zYbZKVDEFLcYHBcW6B0PW7jWG9vY4VrZDJqKZ7aN7/+lbbo3NYGcPXvn9b7V6+ZnWZVdo9qvVMj7fANW8d4IfDdHTi27Yg+nrnm+dCOs3TGPlNDRV1FhonFvdn6CmreVaxeQAW7WL5u+4j4QL8u4KZOUm6TUGgs+Jg61dOVVujMsst91DY78lpTNivh9aJtOFpBvHg5gR7FTJS2/IiZwn9viJltMmO/xgsHtU7eNYf0TNxIfAsa04XmFK7Qo0fbzmjx3RQEJuomKVmmJwch75l9IIgg3vaHTiWyDObULCW78gF5OumZ4qIayWO+Xgijpt8u4Mz/AmRFn98/0xnM/ykjYVhlg+FxDUK5I5lIHibp8auS030XF85aEB4plQj7yz9xuGw3z3UOppQGl3j+Y/AFKSVJn5H5ovU7uj3Nzh5OS6J4H/mR+kosLZkj0o00M6oJ0w+ILgTXXleky60N4SPfit3FhmK11MUOa4krIknkljUHz+9bjwmbO+BQd/pTVKp29zJx6xcva8guAuNyhDOaFCXQ542B4RLs9bOYbI4Z9puBs+JBuT3C7ofHLEBbD+XX7Ph1IsM9Jo4ou5au5CFVP9F25x4tYysyzcjxS6JBXfFxiGykQflPssJvDuNdMWwvEBIeGGCBSv8/57P2XlOHLfq3WTSlofyeByTUZwmwBwL0vPO8Y1FRD1HgYshEui/4iYNd68E5yxi1Y9nb3xa1j5f9LkWKmaFijpsWwCTtBFT06mdr+Y2WDp4CB2pLdzFarwMvwAc/fuB97E+J6Z2icx/sQlm5dFQQgHaXWv9f0iM= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 31:zmA0Zj0ns+QaTeeeAjr3Gf6FoUTQSxIl4DaBlyQBx5s19fDB+06PGbe9ChvEN44rASsYlVMj1f1AjgWP89unI/8IOvnc6tzSD8AbJizdYYIzUU1KWmWsxLp9FZscS6n6iRtT0+ls16LopoItUJ3keStkjmkk6U/hkIpnDIfhCA2XZ0aw8mT8azPRtPdIWP6BmcOvTUyQOKo3bFpRGl7SZIRL30d7vizdLn1Nok6XlTT61GqvrRfaCJpSvD+Lca3nW4U30EazwjR116er9P9gwA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13015025)(13024025)(13017025)(13023025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(20161123565025)(20161123559025); SRVR:MWHPR03MB2479; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2479; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 4:j/JlChjjcf5ARbPX/h4S/4XwgMRy2f36sde9vzLE4j0sIFFmaLRc9OY9BhxYOWFgC6YSU7llwUtyzvqJB477CHUgiSvsk39FEgV43EyjHKjfc8zBNbypv7fx3XsuBwlJR1lvSW/6vVjpRk2NDk64VreVnp0faHbqCY1dXkLIj+0xYOnaV1l0KH9xIt/uEttJxHfveWMPV/gVnWA1OCPlZvY2MPTdqLKmAy2vIzSKGvVKqNWNo8l6w+pM6srZkmaiB8qqaKw3yfkgX3OxSrcrV3xXG0cgOjdL9Th8jZcKFYMwPaPpicdCZLLtcFv++631nWwwACQq7vWSNZ0f3gA+yiOJ8GySnSOmriotyj7m6yWxJAkr4jNHDhz7uN4s+iIvRkNR0+1XsVu+mwWN9wmxh7InUIrSRPatm9vOMuqh1UefKlYO4UL+cW8GP2trMc0LjQYe8PNZ9LjXrK15ktHNOb/qRFchEbs25qEAYOPgUsJxcYu/a52OfAPaFJusGikREGD/7U8YMeM9iTQESVGRJoEDtOxcotIj8eWskGfMKDHg1hcqidg611ILIlItvk7PHIhb5nzerMF44AkyjUZY8FH1tZICAKvuxCp6ioL23fOmZDPTx31nGRbGBDQKkMo/OV77N/DlOStqWZOZ4U2Tfe52a/wPv5EMELgAyBdPr3utTv2rcgp/2Bl9+jG/furlEyx76CoLwSRAT47WJEZe6v26fsrKHsLKiWbwTsS9GUHa3UpkYowNfhOQD7WMsQ4v X-Forefront-PRVS: 01930B2BA8 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2479; 23:bdC3dK/udme2ZZmFmMUTXUd2jwUgxlv9tRv8x?= =?Windows-1252?Q?Hrcx8RKwb3A0aFL3ltoE9PorH9Ob/p+Rkjfvb/ILthhUoQvyS/pk7g16?= =?Windows-1252?Q?dJuu8rrdWsaZRLQY7hXwbQtYWmxgAjlBCyIFKsa1a9dgYzGus+l5VC8L?= =?Windows-1252?Q?wEFrvYMU+8VXwf/1hj5MNwUJsjn96e4nnDw2C4myEH9aTOgKQNFYftX7?= =?Windows-1252?Q?EoOoryJa/Y/ybSIED8dP4oWvwmF4AiG2ZwuQCra+vkWTAKxGH8/KwmzQ?= =?Windows-1252?Q?P62vNl3vWaFjjVH7APhu2VbVfQ3vPeYrU78zrdlpXHT6mscsNAxvK3Se?= =?Windows-1252?Q?kHD7p03GS+65lUl0uonvCXH9mneDyT5mv+PK6ohE5yHWOCA2Szh+9k4G?= =?Windows-1252?Q?tt0sPaP44xrJKPI0q9ICXBN+yRUP1EL6jfCFn5tkabIY5RyneZtzSP8y?= =?Windows-1252?Q?rrZW+I+Jc3sLDiMYgyhYpmcAqm8ulrnI60/hpNpLtMRHlSk2jLRa1+ln?= =?Windows-1252?Q?dvBgzSG1os3A2iqNBADHI0pQOvMm2e1UObK7jwOxmc2w2MHFrCab6Kvq?= =?Windows-1252?Q?7HW02OnhrW6MtuQVV7RSE3baGaGPrjiVyhm5irmg0xD4djtTFukC3Fru?= =?Windows-1252?Q?Y4U/Dnn8nXxTP6qflNY1C2zLSx3gV2iGaukj0IxoKuBMyDifEUlKnMq4?= =?Windows-1252?Q?L8xghuJym0su5mODN8ua+oNCzfKhqTeBdLBgJ24vqeSELN7ygD8aq1dG?= =?Windows-1252?Q?pgRimmLnEzBdIER2NF+GpmqnI309zxQaLPZegQIw/P0O5TUO0geE9VxQ?= =?Windows-1252?Q?DFokSsAZ0vc87VdVQQTj6tDuTnSrxICtqNNvPR3FtIze8mimvh9V6mf3?= =?Windows-1252?Q?LqMWip0F9b6dm30MyDcGA7HvVLkvmWY83lmGG0zO5uZKxA4j0bRPFRxp?= =?Windows-1252?Q?AEBf2BOmoP9P3I1RGnxEwAPRYSOYnvt2aCjr7jKEu0A8eodflJyChUw/?= =?Windows-1252?Q?PHCTNwmFchO4dSpigHgQZmNlUODY0eA4GFRQpSTwXh/Cbd5G0wQX2wfW?= =?Windows-1252?Q?hQn3G7BxXevfqk/RonnKcovbYmIBos7bt+dys0fcBKCDThUAcRLcx6HZ?= =?Windows-1252?Q?dFQ1ivUvmz3hPaS5WRZTNFCFxbAiCVBW6OqYN3x+6k8OZKq5At55JFCz?= =?Windows-1252?Q?DBAaQiM3QC/lReUbEWlUvJah8nhaN0DYjdM1p3uNdeSMP8Hk1rzK8gff?= =?Windows-1252?Q?9f9yF+8pKRT2hJZ5V6Go0m4vCYQrNDDnCP/hzF4IX/pikXo2O7vFMr6+?= =?Windows-1252?Q?A1fvBQ9RS0RqlP6xY7FHWxPuBY35KGy9EbF6z+WGezBf7D18nbU+N1y4?= =?Windows-1252?Q?iNtuZvbmUWC0h4IbMfQDroCmie1caVjhq1ZjzhRThqaptoATnTqTL3zs?= =?Windows-1252?Q?RLHlHCn9mocI474XlbNxSKwCtoW/tg10XNnr0HohzwCLxDRQ0Wm9Pnbo?= =?Windows-1252?Q?Z0Ci+CfU8Dku+jVA0v+RP5CCrPQKkLec34uPNuPP/tIGVELMeJRy42Ba?= =?Windows-1252?Q?3qeVr3Z6bZjt34A60/WDR+27LsEi0xKqZ0ACnSxiknaxJT91dAovWQm2?= =?Windows-1252?Q?iHvGF20qWe3wWv6HZpgtrUrY1yo93h4fKn3YtPPsi2qBd5/rY0EBMwCL?= =?Windows-1252?Q?cmBGmTy4x13Va4E2gJJnOQF0PO24AlDJiVDRSF4XiRpLEiQVKqv0Hs/1?= =?Windows-1252?Q?nNvDuth5yqbXYfhxEB3k8zijiYz08nER5RtgzM3aoDkXESnqAiU8BN37?= =?Windows-1252?Q?ce9TZOlJ38Zsc8uqhtmOAHuvQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 6:pI90lB3jgkv96SFQ8z9exNe4h/OSWxwBjePgYdLlxQVPIhieJw8UUImtibmIM/QOzDi3/oRP4wsU+HBkh0LJi1ldIsEvAPz+vDt7MtKDOaAaTouwFtkDZiHTc/l3yR2J2jILK0gV0g4wKcv7t6AElT0PE5ARkTnysYqt8j7b7vAFpQU0mWXeODQRF5rYEN/ZKX/lhqiKy8Wt2poSh3DlippYQYjLP89+ir+FTujGWPc8xaUOUR/XuBjDOloloQsfmpSg0uQXmoCxG3jFBTj+2injxjtB0JuoDvtFnTVWq46OKRK6/HrD2iLFU/rGu5z6Ia5V/P8Ft+B7kaItLQmP9gFzK9TR1CRfDoHnaInnPuITzU0frUOFU3x6HFWEyHvDh8Dbk1P0TMIsROj4VsIbKPeB30zUFUnIlQGULlFUpWRfiDVyhmxrRxSEPOaCuLZI; 5:u59wx9vEp9KuV4gqkGuokx7Auj5OwlIYqp4kmJgMRubH06yzJZJSbh/16ychLQ/FrPPjXpmeyAiuANP6neQkEAsmbYwTQH7x8OV75HFLCezEP6A1NlmUvqXeA6B8gJfU/7oB8kodqWljKD4Y0M5Uv3VN7cPhVCpYHc9ofNjWqFr7jDdInqpe41vaz8XrnZ7j; 24:CkzchV7QEh8+O2qo9eg15cACWwX1QDtYQUZwc4AQEqm7tjt5ajKnMqR9UyV5DRFz+SlkNaKRAHy47l3CJ5uCxK4TbwZZKFpfTbVgQmjTsuA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2479; 7:e8itz8O/MVxoQJGfFuzAHxwjeOuI21nrkZHRTMF95QViIOheNDItoAiol7eU0CYau5TuFvZ5dQ54lthhuMhj5QzDSJYcarRDtMZGZud5ZqfaxESLWdumy8OpUjZCRl3WNMEjx0TbR/XW8WqCIo6Lh0PVV0ASB09ynGLkhE7ehYiPCYnVRHZ6nq8InJrIi9zpCi1CexvcQUdi6oO6d/uX2UgwMki/3vaJNXQedJq4soGIl5jxUk/cakdsuap4VQVm1RnT0wMIZZEnZV4tAaCSSuPwCq/SJknZIuxBHpPLCU5q9M9jyWNC+oZkEsZcOLBz4codyNQ4ANjPTvYMKCz5vSwo7dQozvJYw0CmDnY3abgNgaVpg6UvSkimfLDG4IFcHhfUJnPVW6PVWB/PFj2nCDaRFYzf/9FE9mJfo5cw1lsYTEaj/NacEMrYvherVnjo2gvv58jTI9E5Lvs3z6MKag== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2017 13:17:57.0715 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2479 Subject: Re: [dpdk-dev] [PATCH v3 03/10] crypto/dpaa2_sec: add dpaa2_sec poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 13:18:00 -0000 On 1/20/2017 6:02 PM, Neil Horman wrote: > On Fri, Jan 20, 2017 at 07:35:02PM +0530, akhil.goyal@nxp.com wrote: >> From: Akhil Goyal >> >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Akhil Goyal >> --- >> config/common_base | 8 + >> config/defconfig_arm64-dpaa2-linuxapp-gcc | 12 + >> drivers/bus/Makefile | 3 + >> drivers/common/Makefile | 3 + >> drivers/crypto/Makefile | 1 + >> drivers/crypto/dpaa2_sec/Makefile | 77 +++++ >> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 374 +++++++++++++++++++++ >> drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h | 70 ++++ >> drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 225 +++++++++++++ >> .../crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 4 + >> drivers/net/dpaa2/Makefile | 1 + >> drivers/pool/Makefile | 4 + >> mk/rte.app.mk | 6 + >> 13 files changed, 788 insertions(+) >> create mode 100644 drivers/crypto/dpaa2_sec/Makefile >> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c >> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h >> create mode 100644 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h >> create mode 100644 drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map >> > NAK, you're trying to patch driver/bus/Makefile, which doesn't exist in the > upstream tree, please fix your patch. > > I'm also opposed to the inclusion of pmds that require non-open external > libraries as your documentation suggests that you require. If you need an out > of tree library to support your hardware, you will recieve no benefit from the > upstream community in terms of testing and maintenence, nor will the community > be able to work with your hardware on arches that your library doesn't support. > > Neil > Thanks for your comments Neil. dpaa2_sec driver is dependent on dpaa2 driver which is in review in other thread. I have mentioned that in the cover letter. Its latest version is http://dpdk.org/dev/patchwork/patch/19782/ Also there is no external library used. The libraries that are mentioned in the documentation are all part of the above dpaa2 driver patchset. -Akhil