From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Ding, Xuan" <xuan.ding@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables
Date: Fri, 6 Nov 2020 09:13:30 +0100 [thread overview]
Message-ID: <80fa84c9-5e25-42e0-6927-f48399e446c2@redhat.com> (raw)
In-Reply-To: <MN2PR11MB4063110D6A8446FCF462C5349CED0@MN2PR11MB4063.namprd11.prod.outlook.com>
On 11/6/20 3:53 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, November 5, 2020 7:46 PM
>> To: dev@dpdk.org; Ding, Xuan <xuan.ding@intel.com>;
>> stephen@networkplumber.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> thomas@monjalon.net; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: stable@dpdk.org; Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH 1/3] vhost: fix error path when setting memory tables
>>
>> If the an error is encountered before the memory regions
> 'the' should be deleted.
>
>> are parsed, the file descriptors for these shared buffers
>> is leaked.
> s/is/are/
>
>> This patch fixes this by closing the message file descriptors
>> on error, taking care of avoiding double closing of the file
>> descriptors. guest_pages is also freed, even though it was not
>> leaked as its pointer was not overiden on subsequent function
> s/overiden/overridden
>
> With above changes:
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
I agree with all above comments.
Will fix in v2.
Thanks,
Maxime
next prev parent reply other threads:[~2020-11-06 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 11:45 [dpdk-dev] [PATCH 0/3] vhost: fix fd an memory leaks Maxime Coquelin
2020-11-05 11:45 ` [dpdk-dev] [PATCH 1/3] vhost: fix error path when setting memory tables Maxime Coquelin
2020-11-06 2:53 ` Xia, Chenbo
2020-11-06 8:13 ` Maxime Coquelin [this message]
2020-11-05 11:45 ` [dpdk-dev] [PATCH 2/3] vhost: fix fd leak in dirty logging setup Maxime Coquelin
2020-11-06 2:53 ` Xia, Chenbo
2020-11-06 8:07 ` Maxime Coquelin
2020-11-05 11:45 ` [dpdk-dev] [PATCH 3/3] vhost: fix fd leak in kick setup Maxime Coquelin
2020-11-06 2:53 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fa84c9-5e25-42e0-6927-f48399e446c2@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).