From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, dev@dpdk.org
Cc: satishr@chelsio.com, indranil@chelsio.com
Subject: Re: [dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for including header files
Date: Tue, 18 Dec 2018 18:23:38 +0000 [thread overview]
Message-ID: <80fd308b-07a4-056b-60be-5fcd9143d6f4@intel.com> (raw)
In-Reply-To: <1544713333-32239-2-git-send-email-rahul.lakkireddy@chelsio.com>
On 12/13/2018 3:02 PM, Rahul Lakkireddy wrote:
> Explicitly state header file location using relative paths.
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> ---
> drivers/net/cxgbe/Makefile | 2 --
> drivers/net/cxgbe/base/adapter.h | 4 ++--
> drivers/net/cxgbe/base/common.h | 2 +-
> drivers/net/cxgbe/clip_tbl.c | 2 +-
> drivers/net/cxgbe/cxgbe.h | 4 ++--
> drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
> drivers/net/cxgbe/cxgbe_filter.c | 7 ++++---
> drivers/net/cxgbe/cxgbe_filter.h | 2 +-
> drivers/net/cxgbe/cxgbe_flow.c | 2 +-
> drivers/net/cxgbe/cxgbe_main.c | 6 +++---
> drivers/net/cxgbe/cxgbevf_ethdev.c | 2 +-
> drivers/net/cxgbe/cxgbevf_main.c | 6 +++---
> drivers/net/cxgbe/l2t.c | 3 ++-
> drivers/net/cxgbe/l2t.h | 2 +-
> drivers/net/cxgbe/mps_tcam.h | 2 +-
> drivers/net/cxgbe/sge.c | 6 +++---
> 16 files changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
> index 68466f13e..d809f4720 100644
> --- a/drivers/net/cxgbe/Makefile
> +++ b/drivers/net/cxgbe/Makefile
> @@ -9,8 +9,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
> #
> LIB = librte_pmd_cxgbe.a
>
> -CFLAGS += -I$(SRCDIR)/base/
> -CFLAGS += -I$(SRCDIR)
> CFLAGS += -O3
> CFLAGS += $(WERROR_FLAGS)
Hi Rahul,
What issue do you observe if you don't use relative paths?
next prev parent reply other threads:[~2018-12-18 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 15:02 [dpdk-dev] [PATCH 0/4] net/cxgbe: fix build for Microsoft Windows OS support Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 1/4] net/cxgbe: use relative paths for including header files Rahul Lakkireddy
2018-12-18 18:23 ` Ferruh Yigit [this message]
2018-12-19 12:42 ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for Windows Rahul Lakkireddy
2018-12-18 18:25 ` Ferruh Yigit
2018-12-19 12:39 ` Rahul Lakkireddy
2018-12-19 13:45 ` Ferruh Yigit
2018-12-19 14:11 ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 3/4] net/cxgbe: only redefine symbols when not available " Rahul Lakkireddy
2018-12-18 18:26 ` Ferruh Yigit
2018-12-19 12:41 ` Rahul Lakkireddy
2018-12-13 15:02 ` [dpdk-dev] [PATCH 4/4] net/cxgbe: fix other misc build issues " Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fd308b-07a4-056b-60be-5fcd9143d6f4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=indranil@chelsio.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=satishr@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).