From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id 301341B908 for ; Wed, 4 Jul 2018 14:57:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4j+q0V6BtrphMrEyA4Iq/HxJVGp/MBMwT9Yon1eStDQ=; b=Z8Y0suQhomyG+yc1gtynvSpKOnpFC4nnUWGgGjYj+BLMNcBM2lS8+wZtpzCj79yLILrpiujObn7BZX4SKNVklyEQSJQW8HewlG0FfczPE7/dW16SNJ2+fzZuda7PnaJkzjm+JTg8QQL9ocq0ckGdaoFX0OaszE583nzHYo6ByQM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.142.187.166) by HE1PR04MB1386.eurprd04.prod.outlook.com (2a01:111:e400:535b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.25; Wed, 4 Jul 2018 12:57:24 +0000 To: Pablo de Lara , declan.doherty@intel.com, shally.verma@caviumnetworks.com, ravi1.kumar@amd.com, jerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com, fiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com Cc: dev@dpdk.org References: <20180608220234.10170-1-pablo.de.lara.guarch@intel.com> <20180628005304.26544-1-pablo.de.lara.guarch@intel.com> <20180628005304.26544-14-pablo.de.lara.guarch@intel.com> From: Akhil Goyal Message-ID: <81216c1b-85c4-f3f6-ceae-415321df4349@nxp.com> Date: Wed, 4 Jul 2018 18:27:06 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180628005304.26544-14-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::20) To HE1PR04MB1386.eurprd04.prod.outlook.com (2a01:111:e400:535b::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b9a1521-d297-4e39-28ee-08d5e1adb72e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR04MB1386; X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 3:wT0swmRoGbI97GvcOSGnujpXvjAtIbPKNGh2Ihv76CKR9RbS50mwxCiqrZY6eK73xThoJl1O7+GnRKuFkLjMsWANbZOl5x3kMmFY0aULTTjvOgghebFkswu9p29lAvczjRaGK0vRycgmrjIrqv0kIEhytnPgQS8Hnsne5Uuuu5IEP22N2iJEXgPzO/hYkDU0RXnpsraP81sH81r4FV1CR+Ri4+QRHc7hAJDROlJRftg3iQwfEUo6Ii8e2B3/U8CJ; 25:su/MZSxM8KFB0yq9aMlq4beL380rM0rxoZNIgKu630/Da0WqXq1dfv50VpflnSYsOxnSpiNLe3ji3VY7P0ddDm56KyuPn7MmWIu8s0Y6rlc0Y2pRZRqBvCxo7jvYVSVcSd6U9kqWDOuwwDZeB/7mlqFbK944B0lSEhuqtfJLongxRQ5sbf0JHCsKTiDiocG4MrBtDXNtmuo6m6t/YZ+LAJn+Q5hoNSk+w2tFC4ImqY53g9YQH4j8aA19TccKY/qZ8Rj8cqV0Gy2CAKQiogQDXBF1eVhmvvwq09ZcHSowQfi5CuObb6tB5+TK1QPeSGX4P0PAL5VJNrHJdkFv4wLysw==; 31:Ea5Z2NojoWZFrsZdpGAEs8ZZ+w8g6C/6zszcbRdHVClwQgyc6iGcTEF2n/a/ukG5gQ+SnBmd4R4mewZpEPU6fYfIINfUNTeLA/YvGN6w+lmxlZF8588sWP8jiRko+4V2cauFrlOoH+HbcjdbWDJERtFzhSNkhatWB8r9FquxrL6Q10ZorwHzZ9HStD2Dfdjb9XM3342T3MF9z2+B3YN8dB96dVYGT1JowYpgjeVMzJ0= X-MS-TrafficTypeDiagnostic: HE1PR04MB1386: X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 20:+KtWo/WacXakm3zoMsAPEdKEGONryLviBp/+YaUJ/Y5UeE7ZR7YFcVwTpHxI/PIaIUN7pOIkby21eVVIIT5qRc30wcaDomsFEyI1VgjS2lyM6F0TnorZ0EtIJBNRRZWBTNmEjNcXbhHW1s7EEBXYsbkRnHvqtOWo8l4ESK5jRjp/DzMOWilN9zCuO1vk8F+1s9N2yTeAQDOBdHi908hLTBCOP67pC3wrUw9ssQmLWOVUkh3eJLhRZyt2QTjSw5ZPjLhnafk+n3oW8m/g9H+LVImclbLxZIOr2bG0KErmFAaxR+AJ0C7UQ/92uCacayZz2XFLxiNxeGyBgR189dAUewTarNIzz3obOI3DA5XPunde2YYSyhgsUaZRpxbK704D/7Fd8j88AzbPs6qmk8IqUfvLEmtpe4/1+ed8kCzUwVmxl4etaOPl2TP3ZHvgnUSGDJR1+EQFcW5qoDTBaF9iXwCUz2wDf88SrmiFR0J34O1OcDLbMh6Y0S4tCPYoxwAp; 4:N8DqSHGBswHtPCp/eBM5qcYMHXTamZhMDgmVEjq31deFMeuM/qeDEE1Annhh8dRTi0S0jmRNGWZW0ZhTkh4sj+u0xfBAAFfUg/smmCkd6lwLkADrtEFsNs6Jk2rQHttFVQcCquQ8x6tKXDFIZLPtdBb62mXGUhPLbws5xXaysaAVAwarUWGcKBW/YHaTSUlcceTvlOP1ilswdaXN3TF2LZYvYXdZeU5LNmcs2rsDPyB1aPGCAXoX3ZsNi0lgCRshu427ayLVw83JRu4l1ahMx6W3m94XCZJ4OXqztqmwhxqMBTNvzW3K2iu+EbMkMKOq4zqU/VAggnp8pSDyvoEnlQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:HE1PR04MB1386; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB1386; X-Forefront-PRVS: 0723A02764 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(376002)(346002)(396003)(136003)(366004)(189003)(199004)(25786009)(7736002)(47776003)(8936002)(65826007)(14444005)(305945005)(7416002)(53936002)(6666003)(486006)(476003)(6246003)(64126003)(68736007)(478600001)(3260700006)(44832011)(2906002)(956004)(97736004)(446003)(11346002)(575784001)(50466002)(65956001)(86362001)(2616005)(65806001)(229853002)(31696002)(5660300001)(66066001)(6116002)(386003)(26005)(55236004)(5009440100003)(106356001)(186003)(81156014)(316002)(6486002)(3846002)(67846002)(16526019)(76176011)(4326008)(81166006)(58126008)(105586002)(16576012)(8676002)(52146003)(23676004)(230700001)(53546011)(2486003)(77096007)(36756003)(31686004)(52116002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB1386; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0TUIxMzg2OzIzOkFGaFNnb20wU2hMd0Z6TStkVHdrREtLbUFT?= =?utf-8?B?OFdFR044T0x3YVQzMkhnT1h6aUpQZTRBVW14ejBEWjNadXp2OTNvWkFYYlU2?= =?utf-8?B?dWpNcTU1d2l5UVFweU9ybXE5bjRyMlNIOHFIamVVNVBlQis4ZjZja3N0MDBq?= =?utf-8?B?TDAyZ1oyVFFodjIrWHdDalJadVd1MWM1TXpwbE55TWs4THFHZXBQWEJQSC9n?= =?utf-8?B?b3RhMmE5SzRwbmRZUVhNaVJMYUo1dUVKUmFCZG1lKzVTMXN5Q1RJYUphTE5T?= =?utf-8?B?empWSmhHVENISTVEaSt0dkFWVXJjcGxzTWo2VVBpV0RSV2pHMWU3N2ozbUpE?= =?utf-8?B?WDdPcktyNytGMWExWlIwWk9pL21aV1plYUpNb2pZYkhUcFJtbnh1UnFlb0k4?= =?utf-8?B?MW9oR2RxTjJEMGRWTThZNCtoOWYraDRaTjZHSlRBWXV3Qy81NWNHNUgrVmFK?= =?utf-8?B?dU5IUmo2ZndFdXZWYno2ZXYzcnB3NXJpc1A0eU9tNENWTE84dW01TUt5dnc4?= =?utf-8?B?MFp2TnYzTGNTbTg0cUptZ0pCckNsVmRUYXNyNFlJemh0dXVVdWh3SjJ6S0JZ?= =?utf-8?B?azNZOUVkYTBaSnVTdnl4ODl3YkhyRU1WcG1TOXVtdjE3RzZMNnZTd3hnTHFN?= =?utf-8?B?M0pvNTRFeGR2VmhWczVmc2owb0QzVkNlOU5LcnYzR1JGU2UvSFU2dlRqc09G?= =?utf-8?B?c3llMWpaSTZZRFI1aEJua1Jtbm1wNmo4WG1kQzdPSFFhNDN5NnJFZllNOHpo?= =?utf-8?B?L1RRL2QvRVhLZk42L1RwRy9KeDhBWlVDRG00b2pJOG9IeTFCUDBWWDE2bko0?= =?utf-8?B?MGxSWkNqdUZLMHVkdTlHWHYxL3B1OVB4TDVjZjVGZ1MxT0I2eUlZeHRCUmlK?= =?utf-8?B?d3dmSWc0UnVwTVArQm1ORGZJd25MQVpCWWZiaktkcVRwTTg0QnhsbW1MTnNr?= =?utf-8?B?Vndyb3U5RUovNExFNEk5c09rejROa2tHSTZNNHZWY3NWNEpjRHpLN0NrVzFX?= =?utf-8?B?bUFYQVNVb2JocFJxcnVFSnRiWWs2RnZMZUkwRis1VmRpVk5GWmhWTjlORmUx?= =?utf-8?B?OXc0L2NqSHY0YUFDZ2paMWlJSldtRU56VTkwa3RtdkJHdGtjZTRBTHhiL1RN?= =?utf-8?B?V3JyYUx0Yk9QbEZxNnFIMEZydzVyejVCcVAzMEpKU2I0SHN0dXZyaFVOWXlU?= =?utf-8?B?eWJNSURVanc3VmxYWkRTSFc4YmJCd2JVc2dPWEtnS2IrSW9rTS8wYnF5TEor?= =?utf-8?B?Znh5T2NFWGY0WDkwYzNPbFltOXlCN1hiUHVCSEpQQjBMTkxtN0xZTmRhSXVY?= =?utf-8?B?SXVHcXp4ZUU2YlBncWdhL2haWmFSMmE4NCtHZW0zTGdxMXdFUEVmWTZidDVq?= =?utf-8?B?WE95alU2c1BFTWFuN3hqenVHSnB6cEtLaVkxSXdvcHJDcjJBWjVweHJ3VVlt?= =?utf-8?B?bU1RMGxTQ2d6YXl6NW1hMnJaSWh4Qjh4eFRDRmN0M3hSaVRPVnAvMDNwMGRS?= =?utf-8?B?c2JyekhKTld3UVZUZitmaitTaTdib05LaFlIUXUyczNIc045Z2VCUExybXZv?= =?utf-8?B?WHRmZ2wxS1pWWjJHTGx1Unh3QndhZ29wMk5CNHY5aGJTOFlPZFNzWHNtNS9h?= =?utf-8?B?Tno2MlpkREJqTjF3Sm5tM1ltdk5hZWoybW5SOUkzM1E1My9CYmNiQkFPWnFH?= =?utf-8?B?ZVVuK3dZb0EwOGlrMGc4UEpHL0F1NDNwMDJOK0Z5TEdvTG81L20vNWZCOEdJ?= =?utf-8?B?dlRkOXlwYnFLTHczM1RIczM3dzFlbHZ6Z2Q3U01NYzZRZlBDNGlheElTZ1pw?= =?utf-8?B?RWJZMWZpTm5Ycm05WDhjRGxvWlY1dmJ3ZGlqbVVxQmZoelkxM01QbkpUamlZ?= =?utf-8?B?UllVQllicjVqWmYyRWNBMkhjemU2dzBwU2RvZ2VKUWVVM3NnZ2FKU0EyMTBL?= =?utf-8?B?eVlMbW9hekVKeVRuNGlQc3lENGU2UjFDYXVBY2RuSUM4NVVDRzZWM3I2K1Uz?= =?utf-8?B?Mlh2WS8vdnZCYW4wRHZXQW5UeWpjSFl3N29zeXJ5NDdEa1hwMzBDaG9qb0tq?= =?utf-8?B?K3QyM25ML0xwTzU0aEgwY0ppdnk1NWdBN0h4YnMzMVlNb1poRXU4N09oUXBV?= =?utf-8?Q?9QfixnFQJo+80XHpusge/2F5vxTwZ4CpEZlgTLvVgmTw?= X-Microsoft-Antispam-Message-Info: 1mfcQxXGYhbshZzbpgaDZoKmg4/kljO+vRgKJD6QYZaCdimfThwtt4iDbMPSdpdgIBu9CqH8KXYDkdGyF/fwemG//M9TukDY7PYB7Pb/yQS5JPvnCQfn/VIxB/TND/U6a+uUZ7a48GBkncrCzs3rTw3SPXfL6qQy9GQHPZUT1Il+Y+smIQl0oxoAYbS72jQn+BmYjOgSIcLsO7LY2y9nGT/tqec32ccewaHdjDe05l75ILHAZ6eeR4QcWp1qgTf+ngJ9zwTgQHrT+GfA1HYW41QXlQIUjmI2gEns5mTQHqp6aOo6bu9JtCZB+Nn2Ni5X51UfLCeHLnpM3YLanmHWOAq2k/nSPYoK4huCVljtgZ0= X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 6:IlzL1ZIMAvwvHkY8TYShRRQWzvlaavH/RjctLWXBti18R6jBgx/7+wgrwDKmoCFUV3M6Rtaz01Ct8XpDi1Xwtw30wiWHtI6RcvmaR9AozJfiQPWWmqe8Y9NkIatNXrtTGt6Mzs5CHcFRCKNetGLLzUaWgLUTM8liYAD35auWHpAh9uH6Jez4b0fvx/bExHhtq7lOC6kHHZsVXBrAuJR5lIF3s3IbelEQiWtpDsY2p9tDb0j8yX8mnVDua3rH971X3pDZjHFHEZ5HjH/jfYhQz8dIkvDQbofmai6Hku+XhPL7qo0yi27tz1PNdhpNDQ/DttxgFAIucegYycQVOUSQC+cCcYTwK4UHBC2qB9bCNGzbcN10HcWYXXo7tQvRjiQqkVsMlrF4pIDH3mIK95LTXw4/qHIz/FhH7G9vgbx6oRYKzXqoUhoqbgIVY/zSK6qHFknyZ0olgyhJOc6bpbxKXQ==; 5:u3n2roGJpCqeuI8DpfeUR+0iJGl6Q7EqxrF5ZNHSp9MvkyIRdr6o+WtfydPemPctevA6UccoNlcHMQWHzsoAQUhxW9GVpxh+GKj241CEAKk+VR983mBPmkQ/91gVPTCRv7NCodBewLSdaCLdFwC9K9KtXscf9lWh5x/NMxnU4Pw=; 24:/i7k0QKoJubo0kuUVdzPdlYzLqDPCyNhqsH5rOKbVMg/yiD60gGTpPzcaTU5UmptwpqrkmS+efHdrNjSr+STviqUK3lIy/f69iWschiXT4k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR04MB1386; 7:5pdefGDZpuIzgjbaUBGlkV9J3Hb7RG9qstjy7IM0YEL2Sy9lsZxyUgus4kiLHwMS5eCNxwLQQrvsp1Oir7pRJKyZGRa7wJu+SzflvfSwpwsunR3A0fxhvlki7gIN8DrHFB2sY1Ia2ktDhGL/0Q1x5UW5mRmC7Js3iVs/sPPdgIBJTp7xzhK5vNFp7tmgSzkBqw7Sa0BHu1EoKVm3feuFxC+UrdJ8iV/qnAM5jsZaJISObSRVC+ilKuZoIBY3PA1m X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2018 12:57:24.3080 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b9a1521-d297-4e39-28ee-08d5e1adb72e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1386 Subject: Re: [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 12:57:38 -0000 Hi Pablo, On 6/28/2018 6:23 AM, Pablo de Lara wrote: > The current mbuf scatter gatter feature flag is > too ambiguous, as it is not clear if input and/or output > buffers can be scatter gather mbufs or not, plus > if in-place and/or out-of-place is supported. > > Therefore, five new flags will replace this flag: > - RTE_CRYPTODEV_FF_IN_PLACE_SGL > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT > - RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT It is better to have OOP instead of OUT_OF_PLACE and IP for INPLACE? I guess RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT is supported in most of the drivers which support OOP, I can see some of them are missing. > > Signed-off-by: Pablo de Lara > --- > doc/guides/rel_notes/deprecation.rst | 2 -- > doc/guides/rel_notes/release_18_08.rst | 8 +++++ > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 6 +++- > drivers/crypto/dpaa_sec/dpaa_sec.c | 6 +++- > drivers/crypto/null/null_crypto_pmd.c | 2 +- > drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- > drivers/crypto/qat/qat_sym_pmd.c | 6 +++- > lib/librte_cryptodev/rte_cryptodev.c | 12 ++++++-- > lib/librte_cryptodev/rte_cryptodev.h | 46 +++++++++++++++++++---------- > test/test/test_cryptodev.c | 31 +++++++++++++------ > test/test/test_cryptodev_blockcipher.c | 21 ++++++++++--- > 12 files changed, 106 insertions(+), 38 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 9a73b1d8e..62d635b74 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -105,5 +105,3 @@ Deprecation Notices > ``rte_cryptodev_queue_pair_dettach_sym_session()`` will be deprecated from > 18.05 and removed in 18.08, as there are no drivers doing anything useful > with them. > - - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous, > - so some will be replaced by more explicit flags. > diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst > index e482d3d5f..2a136d88c 100644 > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -78,6 +78,14 @@ API Changes > - ``rte_cryptodev_get_private_session_size`` is replaced with > ``rte_cryptodev_sym_get_private_session_size`` > > +* cryptodev: Feature flag ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` is > + replaced with the following more explicit flags: > + - ``RTE_CRYPTODEV_FF_IN_PLACE_SGL`` > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT`` > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT`` > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT`` > + - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT`` > + > > ABI Changes > ----------- > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > index cd5b1952b..03917f220 100644 > --- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > +++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > @@ -492,7 +492,7 @@ aesni_gcm_create(const char *name, > dev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_CPU_AESNI | > - RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT; RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT ?? > > switch (vector_mode) { > case RTE_AESNI_GCM_SSE: > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 1b1c30d85..4daee5f59 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2762,7 +2762,11 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev) > RTE_CRYPTODEV_FF_HW_ACCELERATED | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_SECURITY | > - RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; > + RTE_CRYPTODEV_FF_IN_PLACE_SGL | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT; > > internals = cryptodev->data->dev_private; > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c > index b96552c57..8ad25f2be 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -2271,7 +2271,11 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev) > RTE_CRYPTODEV_FF_HW_ACCELERATED | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_SECURITY | > - RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; > + RTE_CRYPTODEV_FF_IN_PLACE_SGL | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT | > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT; > > internals = cryptodev->data->dev_private; > internals->max_nb_queue_pairs = RTE_DPAA_MAX_NB_SEC_QPS; > diff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c > index 478ac0b62..224ba7233 100644 > --- a/drivers/crypto/null/null_crypto_pmd.c > +++ b/drivers/crypto/null/null_crypto_pmd.c > @@ -177,7 +177,7 @@ cryptodev_null_create(const char *name, > > dev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > - RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; > + RTE_CRYPTODEV_FF_IN_PLACE_SGL; > > internals = dev->data->dev_private; > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c > index 972e2adfe..94b6e2de9 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -1660,7 +1660,7 @@ cryptodev_openssl_create(const char *name, > dev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_CPU_AESNI | > - RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; > + RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT; RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_FB_OUT is supported here.