From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1D3FA0562; Sun, 18 Apr 2021 00:35:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8EF740682; Sun, 18 Apr 2021 00:35:41 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id EE4D14014F for ; Sun, 18 Apr 2021 00:35:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 3A8335811AC; Sat, 17 Apr 2021 18:35:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 17 Apr 2021 18:35:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ERh0Xeyy0onkJGs9d19fU3sbK4cqQt2Ny9MKVaYaTUM=; b=ecGyRn5/nqt0E08a NYzz4XXE7zfYULroCEH/ZQldlMTqm9jWOes20wC+Y+2hVdUeZ+fmFrD7nRZC2jhJ 9zJin91KI34AB3vG/PxtcMytpxlHH4p9Ez36td6ktLAllpN1O9NLmeh1EHrpChkY vrYxBDbLlSuWUnivluL1aT1mWiETrUdgbvN0ixz9bm/NK98DzOiJvUuUT5qi78tz wGp4aPnJ5rWvg0bLRxJ0xSYbBCRxG8qk8ngkI4BUnnOpcd7VablF/r0xpDtRYHpz gZ8zqkgMcbu5kYff5zaC/S/Z/suzjFXE+pfFWPuLJLhiHOlTrShknxfduQFcDNfI fP3KNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ERh0Xeyy0onkJGs9d19fU3sbK4cqQt2Ny9MKVaYaT UM=; b=oCqSgIRUp9BqKJn3OhDZjintq1khSAakCGcx3S9SYeaNtbI9TXrUJdCqn r0hZ1/Yvdh3jtH7E+G3t8Z+foPi+GQ0i5viQIXZzLMPlpNPXYjpiV/vo4GV1QDGS E5JOnQpPU4jgRg66ZzT1rqf3/M7NCR+yTnHA1D0AIAFaoViRSeVfhmB2D5bCMfSq eRuJKLlbGvNvXlbJ9QJ+rdwWbugxJLCzxLeqKNwYx7vWylHNdYaw6Bi5P7OZyqn5 ACej+AzMl1g5GetPx7Knq8m6pMj4J+lYTy+QwGAt185SXvis3n2Rq9pZlVBlBy+a LkE0HtrUsjseIGFaMcAAZZ4YHb30w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeljedgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED6231080057; Sat, 17 Apr 2021 18:35:36 -0400 (EDT) From: Thomas Monjalon To: rasland@nvidia.com, Li Zhang Cc: orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, cristian.dumitrescu@intel.com, lironh@marvell.com, jerinj@marvell.com, ferruh.yigit@intel.com, ajit.khaparde@broadcom.com, Andrew Rybchenko , dev@dpdk.org, roniba@nvidia.com, asafp@nvidia.com Date: Sun, 18 Apr 2021 00:35:35 +0200 Message-ID: <8136882.BepHeGY5Mf@thomas> In-Reply-To: <20210413155958.2024584-2-lizh@nvidia.com> References: <20210331085405.1445546-1-lizh@nvidia.com> <20210413155958.2024584-1-lizh@nvidia.com> <20210413155958.2024584-2-lizh@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add packet mode in meter profile structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2021 17:59, Li Zhang: > Currently meter algorithms only supports rate is bytes per second(BPS). > Add packet_mode flag in meter profile parameters data structure. > So that it can meter traffic by packet per second. > > When packet_mode is 0, the profile rates and bucket sizes are > specified in bytes per second and bytes > when packet_mode is not 0, the profile rates and bucket sizes are > specified in packets and packets per second. > > The below structure will be extended: > rte_mtr_meter_profile > rte_mtr_capabilities > > Signed-off-by: Li Zhang > Acked-by: Matan Azrad > Acked-by: Cristian Dumitrescu > Acked-by: Jerin Jacob > Acked-by: Ajit Khaparde > --- > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -163,6 +163,18 @@ New Features > ``show port (port_id) rxq (queue_id) desc used count`` > > > +* **Added support for meter PPS profile.** > + > + Currently meter algorithms only supports bytes per second(BPS). > + Add packet_mode in the meter profile parameters data structures > + to support packet per second (PPS) mode. > + So that it can meter traffic by packet per second. > + Packet_mode must be 0 when it is bytes mode. It is supposed to be in past tense. Reworded as follow: + Added packet mode in the meter profile parameters data structures + to support metering traffic by packet per second (PPS), + in addition to the initial bytes per second (BPS) mode (value 0). > + > +* **Updated MLX5 driver.** > + > + * Added support for meter profile packet per second mode (packet_mode). The mlx5 implementation is not part of this patch. This sentence will be removed. Please add a similar line in the mlx5 patch.