From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>, Rosen Xu <rosen.xu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features
Date: Tue, 15 Oct 2019 12:08:05 +0100 [thread overview]
Message-ID: <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> (raw)
In-Reply-To: <20190730155726.26450-1-thomas@monjalon.net>
On 7/30/2019 4:57 PM, Thomas Monjalon wrote:
> As legacy filter API "filter_ctrl" is superseded since 2017
> by the rte_flow API, and got the deprecated attribute in DPDK 19.05,
> it is time to remove the associated features from the matrix.
> Not documenting deprecated features as supported will avoid confusion.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
<...>
> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
> index f1a39d0f0..dfbdf084e 100644
> --- a/doc/guides/nics/features/default.ini
> +++ b/doc/guides/nics/features/default.ini
> @@ -36,13 +36,6 @@ VMDq =
> SR-IOV =
> DCB =
> VLAN filter =
> -Ethertype filter =
> -N-tuple filter =
> -SYN filter =
> -Tunnel filter =
> -Flexible filter =
> -Hash filter =
> -Flow director =
> Flow control =
> Flow API =
> Rate limitation =
I suggest adding these features back!
"Flow director" and other filters are features that device/driver supports.
And "Flow API" and "filter_ctrl" are methods used to implement these features.
Indeed they are only different APIs to get input from application/user.
It doesn't really mean much to say "Flow API" is supported? So what is really
supported? It matters more what feature is supported.
Since we are saying old method is deprecated, we can update the feature list of
drivers which implements filtering features using old method as not supported.
And that is the case with this patch since old APIs are marked as deprecated,
users can't use them to enable a filtering feature.
Indeed I am for removing the "Flow API" from feature list, first it is not a
feature, second if it is only method to enable a filtering, and if filtering is
enabled in a driver, what is the point of redundant "Flow API" listing?
I can make a quick patch if there is no objection, thanks.
next prev parent reply other threads:[~2019-10-15 11:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 15:57 Thomas Monjalon
2019-07-31 9:34 ` Andrew Rybchenko
2019-07-31 10:35 ` Jerin Jacob Kollanukkaran
2019-07-31 10:47 ` Ajit Khaparde
2019-08-06 21:42 ` Thomas Monjalon
2019-07-31 9:45 ` David Marchand
2019-07-31 13:00 ` Thomas Monjalon
2019-10-15 11:08 ` Yigit, Ferruh [this message]
2019-10-15 12:31 ` Andrew Rybchenko
2019-10-15 12:58 ` Ferruh Yigit
2019-10-15 14:16 ` Jerin Jacob
2019-10-15 15:55 ` Ferruh Yigit
2019-10-15 16:19 ` Jerin Jacob
2019-10-15 20:00 ` Ajit Khaparde
2019-10-16 10:02 ` Ferruh Yigit
2019-10-16 10:08 ` Jerin Jacob
2019-10-16 10:16 ` Ferruh Yigit
2019-10-16 10:20 ` Jerin Jacob
2019-10-25 12:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com \
--to=ferruh.yigit@linux.intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hyonkim@cisco.com \
--cc=john.mcnamara@intel.com \
--cc=johndale@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=shahafs@mellanox.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).